Commits · d8c896cac5b3e31cbffb3da2c657dd59c83fbfeb · github.com / v8-riscv / node

Dec 09, 2017

test: use common.expectsError in tests · d8c896ca

Mithun Sasidharan authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17484


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

d8c896ca

test: replace assert.throws w/ common.expectsError · eae0c056

Mithun Sasidharan authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17498


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

eae0c056

test: use Countdown in http test · 20d6b8c6

idandagan1 authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17506


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

20d6b8c6

doc: add "Hello world" example for N-API · 5279035d

Franziska Hinkelmann authored Dec 02, 2017

Our Addons documentation has a "Hello world" example that
outlines all steps to build it. Adding the sources for this
"Hello world" example for N-API.

PR-URL: https://github.com/nodejs/node/pull/17425


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5279035d

test: fix flaky async-hooks/test-graph.signal · 8997026d

Rich Trott authored Dec 06, 2017

Make sure event loop remains open long enough for signal to be received.

PR-URL: https://github.com/nodejs/node/pull/17509
Fixes: https://github.com/nodejs/node/issues/14568


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

8997026d

doc: immprove inode text in fs.md · 25385ef2

Rich Trott authored Dec 06, 2017

Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: https://github.com/nodejs/node/pull/17519


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

25385ef2

doc: improve text for Console constructor · c3a99703

Rich Trott authored Dec 06, 2017

Make text for Console constructor more precise.

PR-URL: https://github.com/nodejs/node/pull/17519


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

c3a99703

doc: improve readability of README.md · af5cfaf4

Rich Trott authored Dec 06, 2017

Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: https://github.com/nodejs/node/pull/17519


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

af5cfaf4

doc: improve readability of COLLABORATOR_GUIDE.md · 5b4a5c82

Rich Trott authored Dec 06, 2017

* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: https://github.com/nodejs/node/pull/17519


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

5b4a5c82

test: use Number.isNaN instead of global isNaN · b681d8d1

Mithun Sasidharan authored Dec 07, 2017

PR-URL: https://github.com/nodejs/node/pull/17515


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

b681d8d1

test: use Countdown in http-response-statuscode · f3f66a8d

Mandeep Singh authored Nov 26, 2017

PR-URL: https://github.com/nodejs/node/pull/17327
Refs: https://github.com/nodejs/node/issues/17169


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

f3f66a8d

test: use Countdown in test-http-set-cookies · 6a089f93

Shilo Mangam authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17504


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

6a089f93

fs: use rest param & Reflect.apply in makeCallback · 0a0fbd54

Mithun Sasidharan authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17486


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

0a0fbd54

test: replace assert.throws w/ common.expectsError · acd42771

Mithun Sasidharan authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17497


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

acd42771

test: replace assert.throws w/ common.expectsError · 20a8e83e

Mithun Sasidharan authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17494


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

20a8e83e

test: Use common.mustCall in http test · f81bb7b5

sreepurnajasti authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17487
Refs: https://github.com/nodejs/node/issues/17169


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

f81bb7b5

doc: add info on post-publishing ARM6 builds · 4e65f9d5

Michael Dawson authored Dec 04, 2017

ARM6 takes longer, more often fails builds than other
platforms.  Add instructions for how to recover in this
case.

PR-URL: https://github.com/nodejs/node/pull/17455


Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

4e65f9d5

2017-12-08 Version 9.2.1 (Current) · 7f086dd6

Evan Lucas authored Dec 07, 2017

Notable changes:

* **buffer**:
  * buffer allocated with an invalid content will now be zero filled (Anna Henningsen) https://github.com/nodejs/node/pull/17428
* **deps**:
  * openssl updated to 1.0.2n (Shigeki Ohtsu) https://github.com/nodejs/node/pull/17526

PR-URL: https://github.com/nodejs/node/pull/17531

7f086dd6

2017-12-08, Version 8.9.3 'Carbon' (LTS) · 2ac4718a

Myles Borins authored Dec 07, 2017

This is a security release. All Node.js users should consult the
security release summary at
https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/
for details on patched vulnerabilities.

Fixes for the following CVEs are included in this release:

* CVE-2017-15896
* CVE-2017-15897
* CVE-2017-3738 (from the openssl project)

Notable Changes:

* buffer:
  * buffer allocated with an invalid content will now be zero filled
    (Anna Henningsen)
    https://github.com/nodejs/node/pull/17428
* deps:
  * openssl updated to 1.0.2n (Shigeki Ohtsu)
    https://github.com/nodejs/node/pull/17526

PR-URL: https://github.com/nodejs/node/pull/17532

2ac4718a

Dec 08, 2017

2017-12-08, Version 6.12.2 'Boron' (LTS) · 6fa9cae8

Myles Borins authored Dec 07, 2017

This is a security release. All Node.js users should consult the
security release summary at
https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/
for details on patched vulnerabilities.

Fixes for the following CVEs are included in this release:

* CVE-2017-15896
* CVE-2017-3738 (from the openssl project)

Notable Changes:

* deps:
  * openssl updated to 1.0.2n (Shigeki Ohtsu)
    https://github.com/nodejs/node/pull/17526

PR-URL: https://github.com/nodejs/node/pull/17533

6fa9cae8

2017-12-08, Version 4.8.7 'Argon' (LTS) · e832743f

Myles Borins authored Dec 07, 2017

This is a security release. All Node.js users should consult the
security release summary at
https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/
for details on patched vulnerabilities.

Fixes for the following CVEs are included in this release:

* CVE-2017-15896
* CVE-2017-3738 (from the openssl project)

Notable Changes:

* deps:
  * openssl updated to 1.0.2n (Shigeki Ohtsu)
    https://github.com/nodejs/node/pull/17526

PR-URL: https://github.com/nodejs/node/pull/17534

e832743f

test: update http test to use Countdown · 07549c6a

Francisco Gerardo Neri Andriano authored Dec 05, 2017

PR-URL: https://github.com/nodejs/node/pull/17477
Refs: https://github.com/nodejs/node/issues/17169


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

07549c6a

test: improve coverage for Cipheriv and Decipheriv · 6707903f

Leko authored Dec 05, 2017

PR-URL: https://github.com/nodejs/node/pull/17458


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

6707903f

test: improve coverage for Cipher and Decipher · 84b7a867

Leko authored Dec 04, 2017

Cipher
- Call constructor withour new keyword
- Call constructor with cipher is not string
- Call constructor with cipher is string and password is not string
- Call Cipher#update with data is not string
- Call Cipher#setAuthTag with tagbuf is not string
- Call Cipher#setAAD with aadbuf is not string

Decipher
- Call constructor withour new keyword
- Call constructor with cipher is not string
- Call constructor with cipher is string and password is not string

PR-URL: https://github.com/nodejs/node/pull/17449


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

84b7a867

doc: mention node-test-pull-request-lite job · de3a7dbb

Jon Moss authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17513


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

de3a7dbb

util: remove check for global.process · 59711abf

Gus Caplan authored Dec 03, 2017

process is explicitly passed by NativeModule now.

PR-URL: https://github.com/nodejs/node/pull/17435


Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

59711abf

test: improve crypto test coverage · 0ab98f1e

Leko authored Dec 02, 2017

- Call Sign without new
- Call Verify without new
- Call Verify#verify with options.padding !== options.padding >> 0
- Call Verify#verify with options.saltLength !== options.saltLength >> 0

PR-URL: https://github.com/nodejs/node/pull/17426


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

0ab98f1e

test: replace fs.accessSync with fs.existsSync · bf26d92c

Leko authored Dec 04, 2017

PR-URL: https://github.com/nodejs/node/pull/17446


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

bf26d92c

src: remove unused variable in node_contextify · 51c6737d

Daniel Bevenius authored Dec 06, 2017

Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]

    bool display_errors = maybe_display_errors.ToChecked();

This commit removes the unused variable which became unused in commit
aeddc367 ("src: remove tracking for
exception arrow data").

PR-URL: https://github.com/nodejs/node/pull/17491
Refs: https://github.com/nodejs/node/pull/17394


Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

51c6737d

crypto: declare int return type for set_field · abc28017

Daniel Bevenius authored Dec 06, 2017

This commit updates the set_field function pointer to return an int, and
also updates the lambdas with a return statement.

PR-URL: https://github.com/nodejs/node/pull/17468


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

abc28017

test: fix flaky test-benchmark-querystring · 09e9e2bd

Rich Trott authored Dec 06, 2017

Allow zero iterations for short benchmark in test.

PR-URL: https://github.com/nodejs/node/pull/17517


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

09e9e2bd

timers: improvements to TimersList management · e55b7d62

Anatoli Papirovski authored Nov 29, 2017

Move all the TimersList instantiation code into the constructor.

Compare values to undefined & null as appropriate instead of
truthy or falsy.

PR-URL: https://github.com/nodejs/node/pull/17429


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

e55b7d62

doc: fix typo in repl.md · a413df40

Rich Trott authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17502


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

a413df40

doc: fix common typo involving one-time listeners · de06dc92

Rich Trott authored Dec 06, 2017

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: https://github.com/nodejs/node/pull/17502


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

de06dc92

doc: fix typo in dns.md · 86d386a0

Rich Trott authored Dec 06, 2017

PR-URL: https://github.com/nodejs/node/pull/17502


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

86d386a0

deps: update openssl asm and asm_obsolete files · 68726900

Shigeki Ohtsu authored Dec 07, 2017

Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
version was 5.4.0 and nasm version was 2.11.08.

Also asm files in asm_obsolete dir to support old compiler and
assembler are regenerated without CC and ASM envs.

PR-URL: https://github.com/nodejs/node/pull/17526


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

68726900

deps: add -no_rand_screen to openssl s_client · d269e07f

Shigeki Ohtsu authored May 27, 2015

In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: https://github.com/nodejs/io.js/issues/1461
PR-URL: https://github.com/nodejs/io.js/pull/1836


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

d269e07f

openssl: fix keypress requirement in apps on win32 · af446a98

Shigeki Ohtsu authored Feb 17, 2015

Reapply b9106137 .

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389


Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

af446a98

deps: fix asm build error of openssl in x86_win32 · 87c29b52

Shigeki Ohtsu authored Feb 13, 2015

See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389


Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

87c29b52

deps: fix openssl assembly error on ia32 win32 · 15dd596b

Fedor Indutny authored Jan 08, 2014

`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389


Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

15dd596b