- Mar 07, 2018
-
-
Aaron Bieber authored
Add stack_trace_posix to 'sources' as well. Fixes https://github.com/nodejs/node/issues/15784 Fixes https://github.com/nodejs/help/issues/992 add stack_trace_posix to OpenBSD's sources PR-URL: https://github.com/nodejs/node/pull/18448 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
cjihrig authored
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of https://github.com/v8/v8/commit/7a159da151e5f5437d6924de4fd142f854d3df4e Refs: https://github.com/nodejs/node-v8/pull/34 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By:
-
Luigi Pinca authored
`Socket.prototype.destroySoon()` is called as soon as `UV_EOF` is read if the `allowHalfOpen` option is disabled. This already works as a "no-half-open enforcer" so there is no need to inherit another from `stream.Duplex`. PR-URL: https://github.com/nodejs/node/pull/18974 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Chen Gang <gangc.cxy@foxmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Luigi Pinca authored
Add ability to subclass `stream.Duplex` without inheriting the "no-half-open enforcer" regardless of the value of the `allowHalfOpen` option. PR-URL: https://github.com/nodejs/node/pull/18974 Reviewed-By:
-
Joyee Cheung authored
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes PR-URL: https://github.com/nodejs/node/pull/19108 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19137 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19124 Reviewed-By:
-
Gibson Fahnestock authored
Notable changes: * deps: * update V8 to 6.2.414.46 (Michaël Zasso) [#16413](https://github.com/nodejs/node/pull/16413) * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [#16413](https://github.com/nodejs/node/pull/16413) * upgrade libuv to 1.19.1 (cjihrig) [#18260](https://github.com/nodejs/node/pull/18260) * re land npm 5.6.0 (Myles Borins) [#18625](https://github.com/nodejs/node/pull/18625) * ICU 60 bump (Steven R. Loomis) [#16876](https://github.com/nodejs/node/pull/16876) * crypto: * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [#16130](https://github.com/nodejs/node/pull/16130) * warn on invalid authentication tag length (Tobias Nießen) [#17566](https://github.com/nodejs/node/pull/17566) * async_hooks: * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [#18004](https://github.com/nodejs/node/pull/18004) * use typed array stack as fast path (Anna Henningsen) [#17780](https://github.com/nodejs/node/pull/17780) * use scope for defaultTriggerAsyncId (Andreas Madsen) [#17273](https://github.com/nodejs/node/pull/17273) * separate missing from default context (Andreas Madsen) [#17273](https://github.com/nodejs/node/pull/17273) * rename initTriggerId (Andreas Madsen) [#17273](https://github.com/nodejs/node/pull/17273) * deprecate undocumented API (Andreas Madsen) [#16972](https://github.com/nodejs/node/pull/16972) * add destroy event for gced AsyncResources (Sebastian Mayr) [#16998](https://github.com/nodejs/node/pull/16998) * add trace events to async_hooks (Andreas Madsen) [#15538](https://github.com/nodejs/node/pull/15538) * set HTTPParser trigger to socket (Andreas Madsen) [#18003](https://github.com/nodejs/node/pull/18003) * add provider types for net server (Andreas Madsen) [#17157](https://github.com/nodejs/node/pull/17157) * n-api: * add helper for addons to get the event loop (Anna Henningsen) [#17109](https://github.com/nodejs/node/pull/17109) * cli: * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [#16495](https://github.com/nodejs/node/pull/16495) * console: * add support for console.debug (Benjamin Zaslavsky) [#17033](https://github.com/nodejs/node/pull/17033) * module: * add builtinModules (Jon Moss) [#16386](https://github.com/nodejs/node/pull/16386) * replace default paths in require.resolve() (cjihrig) [#17113](https://github.com/nodejs/node/pull/17113) * src: * add helper for addons to get the event loop (Anna Henningsen) [#17109](https://github.com/nodejs/node/pull/17109) * add process.ppid (cjihrig) [#16839](https://github.com/nodejs/node/pull/16839) * http: * support generic `Duplex` streams (Anna Henningsen) [#16267](https://github.com/nodejs/node/pull/16267) * add rawPacket in err of `clientError` event (XadillaX) [#17672](https://github.com/nodejs/node/pull/17672) * better support for IPv6 addresses (Mattias Holmlund) [#14772](https://github.com/nodejs/node/pull/14772) * net: * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [#17662](https://github.com/nodejs/node/pull/17662) * process: * fix reading zero-length env vars on win32 (Anna Henningsen) [#18463](https://github.com/nodejs/node/pull/18463) * tls: * unconsume stream on destroy (Anna Henningsen) [#17478](https://github.com/nodejs/node/pull/17478) * process: * improve unhandled rejection message (Madara Uchiha) [#17158](https://github.com/nodejs/node/pull/17158) * stream: * remove usage of *State.highWaterMark (Calvin Metcalf) [#12860](https://github.com/nodejs/node/pull/12860) * trace_events: * add executionAsyncId to init events (Andreas Madsen) [#17196](https://github.com/nodejs/node/pull/17196) PR-URL: https://github.com/nodejs/node/pull/18336
-
Ruben Bridgewater authored
Minor performance improvement. PR-URL: https://github.com/nodejs/node/pull/17574 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Myles Borins authored
Notable Changes: * http, tls: - better support for IPv6 addresses (Mattias Holmlund) https://github.com/nodejs/node/pull/14772 PR-URL: https://github.com/nodejs/node/pull/19027 -
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/19162 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
- Mar 06, 2018
-
-
Timothy Gu authored
Fixes: https://github.com/nodejs/node/issues/17892 Fixes: https://github.com/nodejs/node/issues/17893 Fixes: https://github.com/nodejs/node/issues/18992 PR-URL: https://github.com/nodejs/node/pull/18993 Reviewed-By:
-
Steven R. Loomis authored
iculslocs uses stdio, but didn't include the header. PR-URL: https://github.com/nodejs/node/pull/19150 Reviewed-By:
-
Joyee Cheung authored
- Moves the creation of `process.binding()`, `process._linkedBinding()` `internalBinding()` and `NativeModule` into a separate file `lib/internal/bootstrap_loaders.js`, and documents them there. This file will be compiled and run before `bootstrap_node.js`, which means we now bootstrap the internal module & binding system before actually bootstrapping Node.js. - Rename the special ID that can be used to require `NativeModule` as `internal/bootstrap_loaders` since it is setup there. Also put `internalBinding` in the object exported by `NativeModule.require` instead of putting it inside the `NativeModule.wrapper` - Use the original `getBinding()` to get the source code of native modules instead of getting it from `process.binding('native')` so that users cannot fake native modules by modifying the binding object. - Names the bootstrapping functions so their names show up in the stack trace. PR-URL: https://github.com/nodejs/node/pull/19112 Reviewed-By:Gus Caplan <me@gus.host>
-
Matteo Collina authored
See: https://github.com/nodejs/node/pull/18438 PR-URL: https://github.com/nodejs/node/pull/19169 Reviewed-By:
-
Mathias Buus authored
This improves error handling for streams in a few ways. 1. It ensures that no user defined methods (_read, _write, ...) are run after .destroy has been called. 2. It introduces an explicit error to tell the user if they are write to write, etc to the stream after it has been destroyed. 3. It makes streams always emit close as the last thing after they have been destroyed 4. Changes the default _destroy to not gracefully end streams. It also updates net, http2, zlib and fs to the new error handling. PR-URL: https://github.com/nodejs/node/pull/18438 Reviewed-By:
-
Daniel Bevenius authored
Currently test-http2-client-write-empty-string.js will throw "Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support" when configured --without-ssl. This commit moves the require of http2 to after the crypto check to avoid this error. PR-URL: https://github.com/nodejs/node/pull/19111 Reviewed-By:
-
Ben Noordhuis authored
Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: https://github.com/nodejs/node/pull/19087 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19087 Reviewed-By:
-
Rich Trott authored
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: https://github.com/nodejs/node/pull/19125 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Rev...
-
Rich Trott authored
There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) PR-URL: https://github.com/nodejs/node/pull/19123 Reviewed-By:
-
Rich Trott authored
Update default files to be linted with ESLint to include .eslintrc.js. PR-URL: https://github.com/nodejs/node/pull/19122 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/19099 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/19088 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
Allow users to switch to the table of contents for older versions of Node.js. This gets rid of the "Failed to add alternative version link" warnings when building docs. PR-URL: https://github.com/nodejs/node/pull/19113 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Jakob Kummerow authored
Original commit message: Introduce --disallow-code-generation-from-strings Exposing the existing Context::AllowCodeGenerationFromStrings(false) API to the command line. Bug: v8:7134 Change-Id: I062ccff0b03c5bcf6878c41c455c0ded37a1d743 Reviewed-on: https://chromium-review.googlesource.com/809631 Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49911} PR-URL: https://github.com/nodejs/node/pull/18212 Refs: https://github.com/v8/v8/commit/0bcb1d6f2de9b278b1de7de1b5333e7f47fdce8e Reviewed-By:
-
Rich Trott authored
I have never found it useful that the ESLint rules (in the configuration file) are organized by the categorization the rules are given in the ESLint documentation. It has only been a source of annoyance as one has to look up where the rule is in the docs to figure out where it should go in the configuration file. This change re-orders the rules so they are in alphabetical order. Simple! PR-URL: https://github.com/nodejs/node/pull/19100 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Michael Dawson authored
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: https://github.com/nodejs/node/pull/19098 Reviewed-By:
-
punteek authored
Added a simple example showing how to rename a file. Refs: https://github.com/nodejs/node/issues11135 PR-URL: https://github.com/nodejs/node/pull/18812 Reviewed-By:
-
Michaël Zasso authored
This is a first batch of updates that touches non-underscored modules in lib. PR-URL: https://github.com/nodejs/node/pull/19034 Reviewed-By:
-
Bradley Farias authored
ensures that instantiation result is only used during initial loading PR-URL: https://github.com/nodejs/node/pull/18965 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/18415 PR-URL: https://github.com/nodejs/node/pull/19149 Reviewed-By:
-
Anna Henningsen authored
Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on `process.binding('util')`. PR-URL: https://github.com/nodejs/node/pull/18415 Reviewed-By:Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18415 Reviewed-By:
-
Michael Dawson authored
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: https://github.com/nodejs/node/pull/19094 Reviewed-By:
-
- Mar 05, 2018
-
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/19056 Reviewed-By:
-
