- Nov 04, 2015
-
-
James M Snell authored
significant updates: * [[`777ba4eded`](https://github.com/nodejs/node/commit/777ba4eded)] - **src**: introduce `http_parser_url_init` (Fedor Indutny) [nodejs/http-parser#225](https://github.com/nodejs/http-parser/pull/225) * [[`e557b62744`](https://github.com/nodejs/node/commit/e557b62744)] - **src**: support LINK/UNLINK (RFC 2068, draft-snell-link-method) (Olivier Mengué) [nodejs/http-parser#267](https://github.com/nodejs/http-parser/pull/267) * [[`eb5e9928b4`](https://github.com/nodejs/node/commit/eb5e9928b4)] - **src**: support ACL (WebDAV, RFC3744, Section 8.1). (Ivan Enderlin) [joyent/http-parser#260](https://github.com/joyent/http-parser/pull/260) * [[`8b1d652322`](https://github.com/nodejs/node/commit/8b1d652322)] - **src**: support BIND/REBIND/UNBIND (WebDAV, RFC5842) (Ivan Enderlin) [joyent/http-parser#242](https://github.com/joyent/http-parser/pull/242) * [[`7d75dd7325`](https://github.com/nodejs/node/commit/7d75dd7325)] - **src**: support IPv6 Zone ID as per RFC 6874 (Tatsuhiro Tsujikawa) [joyent/http-parser#253](https://github.com/joyent/http-parser/pull/253) PR-URL: https://github.com/nodejs/node/pull/3569 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Sam P Gallagher-Bishop authored
Minor typo fix in the list of keys Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/3649
-
James M Snell authored
-
- Nov 03, 2015
-
-
Evan Lucas authored
Previously, if we are unable to open the history file, an error would be thrown. Now, print an error message that we could not open the history file, but don't fail. Fixes: https://github.com/nodejs/node/issues/3610 PR-URL: https://github.com/nodejs/node/pull/3630 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Ben Noordhuis authored
Check that tls.connect() fails in the expected way when passing in invalid minDHSize options. PR-URL: https://github.com/nodejs/node/pull/3629 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
Check that trying to use a < 1024 bits DH key throws an exception. parallel/test-tls-dhe tests this as well but it feels incongruous not to do it here when both tests have similar logic for 1024/2048 bits keys. PR-URL: https://github.com/nodejs/node/pull/3629 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
test-http-pipeline-flood has been flaky on Windows for some time. Hopefully, https://github.com/nodejs/node/pull/2862 fixes it and lands soon, but until then, let's mark it as flaky. PR-URL: https://github.com/nodejs/node/pull/3616 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Guilherme Souza authored
When setTimeout() and setInterval() are called with `delay` greater than TIMEOUT_MAX (2147483647), the supplied value is ignored and 1 is used instead. Add a note about this in the timers docs. PR-URL: https://github.com/nodejs/node/pull/3512 Reviewed-By:
Trevor Norris <trev.norris@gmai.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: https://github.com/nodejs/node/issues/2554 PR-URL: https://github.com/nodejs/node/pull/3620 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rebecca Turner authored
PR-URL: https://github.com/nodejs/node/pull/3599 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rebecca Turner authored
PR-URL: https://github.com/nodejs/node/pull/3599 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rebecca Turner authored
PR-URL: https://github.com/nodejs/node/pull/3599 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Nov 02, 2015
-
-
Fedor Indutny authored
Neuter external `nullptr` buffers, otherwise their contents will be materialized on access, and the buffer instance will be internalized. This leads to a crash like this: v8::ArrayBuffer::Neuter Only externalized ArrayBuffers can be neutered Fix: #3619 PR-URL: https://github.com/nodejs/node/pull/3624 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Jason Gerfen authored
Fix regarding description of the following functions: Certificate.exportPublicKey(spkac) Certificate.exportChallenge(spkac) The descriptions were applied incorrectly. PR-URL: https://github.com/nodejs/node/pull/3614 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Oct 31, 2015
-
-
Emily Aviva Kapor-Mater authored
PR-URL: https://github.com/nodejs/node/pull/3576 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Oct 30, 2015
-
-
Shigeki Ohtsu authored
This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Imran Iqbal authored
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: https://github.com/nodejs/node/pull/3487 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Rich Trott authored
Previous change reinstated returning boolean from child.send() but missed one instance where undefined might be returned instead. PR-URL: https://github.com/nodejs/node/pull/3577 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
phijohns authored
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: https://github.com/nodejs/node/pull/3573 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rod Vagg authored
Notable changes: * buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer, these have been deprecated for a long time (Sakthipriyan Vairamani) #2859. * console: (Breaking) Values reported by console.time() now have 3 decimals of accuracy added (Michaël Zasso) #3166. * fs: - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file descriptor as their first argument (Johannes Wüller) #3163. - (Breaking) In fs.readFile(), if an encoding is specified and the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) #3485. - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding, callback) form), if the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) #3503. * http: - Fixed a bug where pipelined http requests would stall (Fedor Indutny) #3342. - (Breaking) When parsing HTTP, don't add duplicates of the following headers: Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition to the following headers which already block duplicates: Content-Type, Content-Length, User-Agent, Referer, Host, Authorization, Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location, Max-Forwards (James M Snell) #3090. - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a function or a TypeError is thrown (James M Snell) #3090. - (Breaking) HTTP methods and header names must now conform to the RFC 2616 "token" rule, a list of allowed characters that excludes control characters and a number of separator characters. Specifically, methods and header names must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown (James M Snell) #2526. * node: - (Breaking) Deprecated the _linklist module (Rich Trott) #3078. - (Breaking) Removed require.paths and require.registerExtension(), both had been previously set to throw Error when accessed (Sakthipriyan Vairamani) #2922. * npm: Upgraded to version 3.3.6 from 2.14.7, see https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a major version bump for npm and it has seen a significant amount of change. Please see the original npm v3.0.0 release notes for a list of major changes (Rebecca Turner) #3310. * src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary due to the V8 upgrade. Native add-ons will need to be recompiled (Rod Vagg) #3400. * timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes a long-standing known issue where unrefed timers would perviously hold beforeExit open (Fedor Indutny) #3407. * tls: - Added ALPN Support (Shigeki Ohtsu) #2564. - TLS options can now be passed in an object to createSecurePair() (Коренберг Марк) #2441. - (Breaking) The default minimum DH key size for tls.connect() is now 1024 bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS option can be used to override the default. (Shigeki Ohtsu) #1831. * util: - (Breaking) util.p() was deprecated for years, and has now been removed (Wyatt Preul) #3432. - (Breaking) util.inherits() can now work with ES6 classes. This is considered a breaking change because of potential subtle side-effects caused by a change from directly reassigning the prototype of the constructor using `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })` to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)` (Michaël Zasso) #3455. * v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) #3351. - Implements the spread operator, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator for further information. - Implements new.target, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target for further information. * zlib: Decompression now throws on truncated input (e.g. unexpected end of file) (Yuval Brik) #2595. PR-URL: https://github.com/nodejs/node/pull/3466 -
Evan Lucas authored
This is to ensure that it is evaluated the same way it would be if it were to be run by node or required. Before, the following would pass if run by node, but fail if run via the syntax check flag: if (true) { return; } Now, this will pass the syntax check PR-URL: https://github.com/nodejs/node/pull/3587 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Oct 29, 2015
-
-
Ben Noordhuis authored
Check that `node --debug-brk -e 0` immediately quits. PR-URL: https://github.com/nodejs/node/pull/3585 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
This reverts commit ff877e93. Reverted for breaking `node --debug-brk -e 0`. It should immediately quit but instead it hangs now. PR-URL: https://github.com/nodejs/node/pull/3585 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
Remove the `-e` argument from process.execArgv in child_process.fork() to keep `node -e 'require("child_process").fork("empty.js")'` from spawning itself recursively. Fixes: https://github.com/nodejs/node/issues/3574 PR-URL: https://github.com/nodejs/node/pull/3575 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Myles Borins authored
Currently util.format is being used for string templating in tls. By replacing all of the instances of util.format with backtick string we can remove the need to require util in tls all together. PR-URL: https://github.com/nodejs/node/pull/3456 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rich Trott authored
The documentation indicates that child.send() returns a boolean but it has returned undefinined at since v0.12.0. It now returns a boolean per the (slightly updated) documentation. PR-URL: https://github.com/nodejs/node/pull/3516 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Junliang Yan authored
Fix the following error message in windows using VS 2013: LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const v8::OutputStream::`vftable'" (__imp_??_7OutputStream@v8@@6B@)'; link without /DELAYLOAD:node.exe PR-URL: https://github.com/nodejs/node/pull/3572 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl>
-
Junliang Yan authored
PR-URL: https://github.com/nodejs/node/pull/3532 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
Move ENOENT related tests out of general fs.watch() test file and into its own file. This may help diagnose https://github.com/nodejs/node/issues/3541. PR-URL: https://github.com/nodejs/node/pull/3548 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
- Oct 28, 2015
-
-
Myles Borins authored
There is currently no information in the Collaborators guide regarding LTS. This commit adds some basic copy explaining what LTS is, what is considered for LTS, and a simple way collaborators can help. Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Steven R. Loomis <srloomis@us.ibm.com> PR-URL: https://github.com/nodejs/node/pull/3442
-
Ali Ijaz Sheikh authored
This is a reland of https://github.com/nodejs/node/pull/3165. The patch abates the truncation of script filenames in the perf-event output produced by V8. V8 commits: Original: https://github.com/v8/v8/commit/03ef3cd004c2fd31ae7e48772f106df67b8c2feb Reland: https://github.com/v8/v8/commit/010897c16adb46d3fe403eab525502a63e174b0c Original commit message: improve perf_basic_prof filename reporting The buffer used for appending filenames to the string printed to the perf_basic_prof log was unnecessarily too small. Bump it up to be at least kUtf8BufferSize. Truncation of filenames makes it really hard to work with profiles gathered on Node.js. Because of the way Node.js works, you can have node module dependencies in deeply nested directories. The last thing you want when investigating a performance problem is to have script names be truncated. This patch is a stop-gap. Ideally, I want no truncation of the filename at all and use a dynamically growing buffer. That would be a larger change, and I wanted to have a quick fix available that can be back-ported to Node.js LTS release. R=yangguo@chromium.org,yurys@chromium.org BUG= Review URL: https://codereview.chromium.org/1388543002 PR-URL: https://github.com/nodejs/node/pull/3520 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Stefan Budeanu authored
Tests normally use common.PORT to allow the user to select which port number to listen on. Hardcoding the port number will cause parallel instances of the test to fail. PR-URL: https://github.com/nodejs/node/pull/3557 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Sakthipriyan Vairamani authored
The `tls` module's `createServer` and `createSecureContext` accept `key` option and it can be an array of keys as well. This patch explains the format of the entries in that array. Corresponding code: https://github.com/nodejs/node/blob/v4.1.1/lib/_tls_common.js#L73-L90 PR-URL: https://github.com/nodejs/node/pull/3123 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Sakthipriyan Vairamani authored
As it is, the comments are not handled properly in REPL. So, if the comments have `'` or `"`, then they are treated as incomplete string literals and the error is thrown in REPL. This patch refactors the existing logic and groups everything in a class. Fixes: https://github.com/nodejs/node/issues/3421 PR-URL: https://github.com/nodejs/node/pull/3515 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Fedor Indutny authored
Original commit message: [heap] fix crash during the scavenge of ArrayBuffer Scavenger should not attempt to visit ArrayBuffer's storage, it is a user-supplied pointer that may have any alignment. Visiting it, may result in a crash. BUG= R=jochen Review URL: https://codereview.chromium.org/1406133003 Cr-Commit-Position: refs/heads/master@{#31611} PR-URL: https://github.com/nodejs/node/pull/3549 Reviewed-By:Trevor Norris <trev.norris@gmail.com>
-
Sakthipriyan Vairamani authored
As per the `prefer-const` eslint rule, few instances of `let` have been identified to be better with `const`. This patch updates all those instances. Refer: https://github.com/nodejs/node/issues/3118 PR-URL: https://github.com/nodejs/node/pull/3152 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Sakthipriyan Vairamani authored
Description from: http://eslint.org/docs/rules/prefer-const.html If a variable is never modified, using the `const` declaration is better. `const` declaration tells readers, "this variable is never modified," reducing cognitive load and improving maintainability. Refer: https://github.com/nodejs/node/issues/3118 PR-URL: https://github.com/nodejs/node/pull/3152 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Rich Trott authored
It is possible to cause a resource leak in SharedHandle. This commit fixes the leak. Fixes: https://github.com/nodejs/node/issues/2510 PR-URL: https://github.com/nodejs/node/pull/3510 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
ronkorving authored
PR-URL: https://github.com/nodejs/node/pull/2947 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
- Oct 27, 2015
-
-
Ben Noordhuis authored
Before this commit, sending a SIGUSR1 at program exit could trigger a hard to reproduce race condition where `v8::Debug::DebugBreak(isolate)` got called when the isolate was in the process of being torn down. A similar race condition is in theory possible when sending signals to two threads simultaneously but I haven't been able to reproduce that myself (and I tried, oh how I tried.) This commit fixes the race condition by turning `node_isolate` into a `std::atomic` and using it as an ad hoc synchronization primitive in places where that is necessary. A bare minimum std::atomic polyfill is added for OS X because Apple wouldn't be Apple if things just worked out of the box. PR-URL: https://github.com/nodejs/node/pull/3528 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-