- Nov 21, 2019
-
-
Marcel Laverdet authored
Adds a new abstract class for module authors and embedders to register arbitrary isolates with `node::MultiIsolatePlatform`. PR-URL: https://github.com/nodejs/node/pull/30324 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/29292 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Sam Roberts authored
Debugging HTTPS or TLS connections from a Node.js app with (for example) Wireshark is unreasonably difficult without the ability to get the TLS key log. In theory, the application can be modified to use the `'keylog'` event directly, but for complex apps, or apps that define there own HTTPS Agent (like npm), this is unreasonably difficult. Use of the option triggers a warning to be emitted so the user is clearly notified of what is happening and its effect. PR-URL: https://github.com/nodejs/node/pull/30055 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
- Nov 20, 2019
-
-
David OLIVIER authored
PR-URL: https://github.com/nodejs/node/pull/30381 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
VinceOPS authored
PR-URL: https://github.com/nodejs/node/pull/30377 Reviewed-By:
-
Sam Roberts authored
The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: https://github.com/nodejs/node/pull/30053 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
- Nov 19, 2019
-
-
Robert Nagy authored
Ensure that the callback passed into end() is always invoke in order to avoid bug such as deadlock the user. PR-URL: https://github.com/nodejs/node/pull/29747 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Lucas Holmquist authored
An instance of FSStatWatcher is returned when a user calls fs.watchFile, which will call the start method. A user can't create an instance of a FSStatWatcher directly. If the start method is called by a user it is a noop since the watcher has already started. This "Class" is currently undocumented. PR-URL: https://github.com/nodejs/node/pull/29971 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Jeremy Apthorp authored
PR-URL: https://github.com/nodejs/node/pull/30125 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Jesse O'Connor authored
This commit is addressing the problem in issue #29948. Fixes: https://github.com/nodejs/node/issues/29948 PR-URL: https://github.com/nodejs/node/pull/30155 Reviewed-By:
-
Anna Henningsen authored
This can be useful to create `Buffer` instances for already-existing `ArrayBuffer`s, e.g. ones created manually from a backing store with a free callback (of which our variant in the public API has some limitations). PR-URL: https://github.com/nodejs/node/pull/30476 Reviewed-By:
-
Anna Henningsen authored
More precisely, make them untransferable if they were created through *our* APIs, because those do not follow the improved free callback mechanism that V8 uses now. All other ArrayBuffers can be transferred between threads now, the assumption being that they were created in a clean way that follows the V8 API on this. This addresses a TODO comment. Refs: https://github.com/nodejs/node/pull/30339#issuecomment-552225353 PR-URL: https://github.com/nodejs/node/pull/30475 Reviewed-By:
-
Anna Henningsen authored
This allows keeping `BaseObjectPtr`s to `HandleWrap` instances. Previously, the pointer kept the `HandleWrap` object alive, leaving the Environment cleanup code that waits for the handle list to drain in a busy loop, because only the `HandleWrap` destructor removed the item from the list. Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By:
-
Anna Henningsen authored
This is no longer necessary now that the copyable `BaseObjectPtr` is available (as opposed to the only-movable `v8::Global`). PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/quic/pull/141 Reviewed-By:
-
Anna Henningsen authored
Referring to `BaseObject` instances using standard C++ smart pointers can interfere with BaseObject’s own cleanup mechanisms (explicit delete, delete-on-GC and delete-on-cleanup). Introducing custom smart pointers allows referring to `BaseObject`s safely while keeping those mechanisms intact. Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Reviewed-By:
-
Joyee Cheung authored
Previously `internal/bootstrap/pre_execution.js` requires `internal/modules/cjs/loader.js` which in turn requires `internal/bootstrap/pre_execution.js`. This patch moves the entry point execution logic out of `pre_execution.js` and puts it into `internal/modules/run_main.js`. It also tests that `Module.runMain` can be monkey-patched before further deprecation/refactoring can be done. Also added an internal assertion `hasLoadedAnyUserCJSModule` for documentation purposes. PR-URL: https://github.com/nodejs/node/pull/30349 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
C1 control characters will from now on also be escaped to prevent altering the terminal behavior. Fixes: https://github.com/nodejs/node/issues/29450 PR-URL: https://github.com/nodejs/node/pull/29826 Reviewed-By:
-
Guilherme Goncalves authored
Refs: https://github.com/nodejs/node/issues/29766 PR-URL: https://github.com/nodejs/node/pull/30447 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Notable changes: * Experimental support for building Node.js with Python 3 is improved. * ICU time zone data is updated to version 2019c. This fixes the date offset in Brazil. PR-URL: https://github.com/nodejs/node/issues/30352
-
Artem Maksimov authored
PR-URL: https://github.com/nodejs/node/pull/30286 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Rongjian Zhang authored
PR-URL: https://github.com/nodejs/node/pull/30492 Fixes: https://github.com/nodejs/node/issues/25885 Reviewed-By:
-
telenord authored
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: https://github.com/nodejs/node/pull/30279 Reviewed-By:
Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/30466 Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/30465 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
- Nov 18, 2019
-
-
Shobhit Chittora authored
Co-Authored-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: https://github.com/nodejs/node/pull/30483 Refs: https://github.com/nodejs/node/issues/30484 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/30493 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
dnlup authored
PR-URL: https://github.com/nodejs/node/pull/30470 Reviewed-By:
-
Kyriakos Markakis authored
PR-URL: https://github.com/nodejs/node/pull/30430 Reviewed-By:
-
Raoul Jaeckel authored
PR-URL: https://github.com/nodejs/node/pull/30429 Reviewed-By:
-
Jure Stepisnik authored
PR-URL: https://github.com/nodejs/node/pull/30431 Reviewed-By:
-
JL Phillips authored
PR-URL: https://github.com/nodejs/node/pull/30443 Reviewed-By:
-
daern91 authored
PR-URL: https://github.com/nodejs/node/pull/30379 Reviewed-By:
-
Anna Henningsen authored
This adds `CHECK`s verifying that bootstrapping has finished before environment variables are accessed or handles/requests are created. The latter complements a pair of existent checks, but fails earlier and thus gives information about the call site, effectively addressing the TODO comment there. PR-URL: https://github.com/nodejs/node/pull/30452 Reviewed-By:
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/30469 Reviewed-By:
-
Richard Lau authored
Building Node.js without a ccache cache takes longer than the 50 minute Travis time limit for jobs for public repositories. To mitigate this we added a job to compile V8 on the basis that in the worst case it would complete within 50 minutes and provide a cache that could be used by a restarted `Compile Node.js` job. Recent PRs have exceeded the 50 minute time limit for the `Compile V8` job. When Travis times out a build the cache is not stored. This commit drops the `Compile V8` job and adds a manual timeout to the `Compile Node.js` job which will allow the cache to be stored and used in restarts of the job. PR-URL: https://github.com/nodejs/node/pull/30469 Reviewed-By:
-
- Nov 17, 2019
-
-
Artem Maksimov authored
If there is a file 'path' in the root dir, the test will fail with the 'ENOTDIR' instead of 'ENOENT'. Change path to something more unlikely. PR-URL: https://github.com/nodejs/node/pull/30280 Reviewed-By:
-
Nikolay Krashnikov authored
PR-URL: https://github.com/nodejs/node/pull/30314 Reviewed-By:
-
nathias authored
PR-URL: https://github.com/nodejs/node/pull/30444 Reviewed-By:
-
