- Oct 21, 2017
-
-
Paul Marion Camantigue authored
PR-URL: https://github.com/nodejs/node/pull/15976 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Anatoli Papirovski authored
Add updateWriteQueueSize which updates and returns queue size (net & tls). Make _onTimeout check whether an active write is ongoing and if so, call _unrefTimer rather than emitting a timeout event. Add http & https test that checks whether long-lasting (but active) writes timeout or can finish writing as expected. PR-URL: https://github.com/nodejs/node/pull/15791 Fixes: https://github.com/nodejs/node/issues/15082 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Anatoli Papirovski authored
Make writeQueueSize represent the actual size of the write queue within the TLS socket. Add tls test to confirm that bufferSize works as expected. PR-URL: https://github.com/nodejs/node/pull/15791 Fixes: https://github.com/nodejs/node/issues/15005 Refs: https://github.com/nodejs/node/pull/15006 Reviewed-By:
-
Anatoli Papirovski authored
Due to changes in V8 in 6.0 & 6.1, it's no longer necessary to copy arguments to avoid deopt. Just call .apply with arguments. Retains fast cases for 0-3 arguments. events/ee-once-4-args.js n=20000000 11.58 % *** 1.310379e-05 PR-URL: https://github.com/nodejs/node/pull/16212 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
With recent changes in V8, it is now as performant or faster to use spread parameter within EventEmitter.prototype.emit, especially in cases where looping over arguments is required. events/ee-emit.js n=2000000 4.40 % *** 1.505543e-06 events/ee-emit-1-arg.js n=2000000 2.16 % *** 2.434584e-10 events/ee-emit-2-args.js n=2000000 1.05 % ** 0.001764852 events/ee-emit-3-args.js n=2000000 2.18 % *** 3.234954e-08 events/ee-emit-6-args.js n=2000000 17.17 % *** 1.298702e-103 events/ee-emit-10-args.js n=2000000 17.14 % *** 1.144958e-97 This has a knock-on effect for modules that use events extensively, such as http2: http2/headers.js nheaders=0 n=1000 2.10 % *** 6.792106e-11 PR-URL: https://github.com/nodejs/node/pull/16212 Reviewed-By:
-
Anatoli Papirovski authored
Each conditional branch in EventEmitter.prototype.listeners assigns its return value to a variable ret which is returned at the end. Instead just return from within each branch. This is both clearer and more performant. events/ee-listeners.js n=5000000 3.65 % *** 3.359171e-10 PR-URL: https://github.com/nodejs/node/pull/16212 Reviewed-By:
-
Anatoli Papirovski authored
Previously, console had to be compiled in case it was not available but this is no longer necessary - remove it. PR-URL: https://github.com/nodejs/node/pull/16212 Refs: https://github.com/nodejs/node/pull/15111 Reviewed-By:
-
Anatoli Papirovski authored
Replace truthy/falsey checks of _events and _events[type] with comparisons to undefined for better performance: events/ee-add-remove.js n=250000 5.30 % *** 4.260028e-07 events/ee-emit.js n=2000000 4.18 % *** 1.026649e-05 This has a knock-on effect on modules that use lots of events, e.g.: http2/headers.js nheaders=0 n=1000 2.60 % *** 0.000298338 PR-URL: https://github.com/nodejs/node/pull/16212 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16340 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Refs: https://github.com/nodejs/node/pull/16339#issuecomment-338240029
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/16333 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/16351 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/16313 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/16251 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/16251 Reviewed-By:
-
Weijia Wang authored
lib/url.js and lib/events.js are using the same spliceOne function. This change is to move it into the internal/util for avoiding duplicate code. PR-URL: https://github.com/nodejs/node/pull/16221 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
- Oct 20, 2017
-
-
aayush.a authored
PR-URL: https://github.com/nodejs/node/pull/16339 Fixes: https://github.com/nodejs/node/issues/16332 Reviewed-By:
-
umatoma authored
PR-URL: https://github.com/nodejs/node/pull/16335 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
tpurcell authored
PR-URL: https://github.com/nodejs/node/pull/16262 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Diego Rodríguez Baquero authored
child_process IPC channel note PR-URL: https://github.com/nodejs/node/pull/16334 Reviewed-By:
-
Refael Ackermann authored
This reverts commit b9a55a93. PR-URL: https://github.com/nodejs/node/pull/16270 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Lance Ball authored
This method is only useful for the internal mechanics of the REPLServer and does not need to be exposed in user space. It was previously not documented, so I believe a Runtime deprecation makes sense. PR-URL: https://github.com/nodejs/node/pull/16242 Reviewed-By:
-
André Føyn Berge authored
PR-URL: https://github.com/nodejs/node/pull/15947 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Anatoli Papirovski authored
Enable additional rules that node either already adheres to or it makes sense to do so going forward: for-direction, accessor-pairs, no-lonely-if and symbol-description. Fix all instances of no-lonely-if in lib & test and disable accessor-pairs in test-util-inspect. PR-URL: https://github.com/nodejs/node/pull/16243 Refs: https://eslint.org/docs/rules/for-direction Refs: https://eslint.org/docs/rules/accessor-pairs Refs: https://eslint.org/docs/rules/no-lonely-if Refs: https://eslint.org/docs/rules/symbol-description Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16268 Reviewed-By:
-
mog422 authored
A web server such as nginx assumes that upstream is dead if upstream closes the socket without any response. PR-URL: https://github.com/nodejs/node/pull/15324 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Rich Trott authored
Use `make doc-only` instead of `make doc` where applicable. PR-URL: https://github.com/nodejs/node/pull/16309 Reviewed-By:
-
Rich Trott authored
`test-make-doc` fails in CI on Raspberry Pi devices where `test-ci-js` runs the test but does not build the docs. We do not want to build the docs in these cases. Move the test to the `doctool` suite and add that suite to `IGNORED_SUITES` in `test.py`. Specify `doctool` as a test suite to run with `make test` or `make test-ci` but not with the `make test-ci-js` job run on cross-compiled fanned CI tests like we do with Raspberry Pi devices in CI. PR-URL: https://github.com/nodejs/node/pull/16301 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16158 Reviewed-By:
-
Anna Henningsen authored
This makes a subsequent possible deprecation easier. PR-URL: https://github.com/nodejs/node/pull/16158 Reviewed-By:
-
elisa lee authored
PR-URL: https://github.com/nodejs/node/pull/16095 Reviewed-By:
-
- Oct 19, 2017
-
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/16311 Reviewed-By:
Nicu Micleușanu <micnic90@gmail.com> Reviewed-By:
-
jBarz authored
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: https://github.com/nodejs/node/pull/16273 Fixes: https://github.com/nodejs/node/issues/16319 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/16199 Reviewed-By:
-
Anatoli Papirovski authored
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it. PR-URL: https://github.com/nodejs/node/pull/16199 Reviewed-By:
-
Trivikram Kamat authored
This simplifies validation of te header and adds a test case in which array with two values is passed to param value in isIllegalConnectionSpecificHeader PR-URL: https://github.com/nodejs/node/pull/16246 Refs: https://github.com/nodejs/node/issues/14985 Reviewed-By:
-
Gibson Fahnestock authored
Deletes the old test-npm.sh script. PR-URL: https://github.com/nodejs/node/pull/11540 Refs: https://github.com/nodejs/node/pull/7867 Reviewed-By:
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/15454 Ref: https://github.com/nodejs/node/pull/14387 Ref: https://github.com/nodejs/node/pull/14722 Ref: https://github.com/nodejs/node/issues/14717 Ref: https://github.com/nodejs/node/issues/15448 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16307 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/16289 Fixes: https://github.com/nodejs/node/issues/16288 Reviewed-By:
-
Gabriel Schulhof authored
* namespaced functions such as v8impl::JsHandleScopeFromV8HandleScope become part of Node's public symbols unless they are declared static. * the class uvimpl::Work needs to be enclosed in an anonymous namespace else it, too becomes part of Node's public symbols. * remove references to EXTERNAL_NAPI. PR-URL: https://github.com/nodejs/node/pull/16234 Reviewed-By:
-
