- Dec 15, 2018
-
-
Joyee Cheung authored
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ``` PR-URL: https://github.com/nodejs/node/pull/24826 Refs: https://github.com/nodejs/node/issues/24823 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Joyee Cheung authored
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter. PR-URL: https://github.com/nodejs/node/pull/24826 Refs: https://github.com/nodejs/node/issues/24823 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/issues/23277 PR-URL: https://github.com/nodejs/node/pull/25042 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
cjihrig authored
Remove an eslint-disable comment by using a strict comparison instead of a Boolean cast. PR-URL: https://github.com/nodejs/node/pull/24995 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
cjihrig authored
Remove the eslint-disable comments by using a strict comparison instead of a Boolean cast. PR-URL: https://github.com/nodejs/node/pull/24995 Reviewed-By:
-
Mikko Rantanen authored
If a readable stream was set up with `highWaterMark 0`, the while-loop in `maybeReadMore_` function would never execute. The while loop now has an extra or-condition for the case where the stream is flowing and there are no items. The or-condition is adapted from the emit-condition of the `addChunk` function. The `addChunk` also contains a check for `state.sync`. However that part of the check was omitted here because the `maybeReadMore_` is executed using `process.nextTick`. `state.sync` is set and then unset within the `read()` function so it should never be in effect in `maybeReadMore_`. Fixes: https://github.com/nodejs/node/issues/24915 PR-URL: https://github.com/nodejs/node/pull/24918 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/issues/25028 PR-URL: https://github.com/nodejs/node/pull/25032 Reviewed-By:
-
Ruben Bridgewater authored
This simplifies the `format()` code and significantly improves the performance. PR-URL: https://github.com/nodejs/node/pull/24981 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rich Trott authored
Refs: https://github.com/nodejs/node/issues/24921 PR-URL: https://github.com/nodejs/node/pull/25031 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
- Dec 14, 2018
-
-
Rich Trott authored
If there is an error, but not the error code the test expects, display more information about the error. PR-URL: https://github.com/nodejs/node/pull/25021 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: https://github.com/nodejs/node/pull/24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By:
-
Kelvin Jin authored
PR-URL: https://github.com/nodejs/node/pull/24949 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Gireesh Punathil authored
Add a static function GetLoadedLibraries under NativeSymbolDebuggingContext abstraction that provides a list of shared objects - either the current process depended on or loaded. PR-URL: https://github.com/nodejs/node/pull/24825 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/25022 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Mitch Hankins authored
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: https://github.com/nodejs/node/pull/24976 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Rich Trott authored
Make the Collaborator Guide section "Internal vs. Public API" more concise and clear. Remove repetition. Clarify some ambiguity. wordy, repetitive, and somewhat PR-URL: https://github.com/nodejs/node/pull/24975 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/24969 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/24960 Refs: https://github.com/nodejs/node/pull/22101 Reviewed-By:
-
Joyee Cheung authored
Instead use `require('internal/options')` lazily. Also refactor the call site a bit so that the option is queried only once since it's synchronous anyway. PR-URL: https://github.com/nodejs/node/pull/24959 Reviewed-By: -
cclauss authored
$ __make lint-py__ # When run on Python 3 ``` PYTHONPATH=tools/pip python -m flake8 . \ --count --show-source --statistics --select=E901,E999,F821,F822,F823 \ --exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip ./test/testpy/__init__.py:119:37: F821 undefined name 'reduce' file_path = join(self.root, reduce(join, test[1:], "")) ^ ./test/testpy/__init__.py:161:37: F821 undefined name 'reduce' file_path = join(self.root, reduce(join, test[1:], "") + ".js") ^ 2 F821 undefined name 'reduce' 2 make: *** [lint-py] Error 1 ``` PR-URL: https://github.com/nodejs/node/pull/24954 Reviewed-By: -
Ruben Bridgewater authored
The onboarding docs still contained an outdated description of the `author-ready` label. Now it references the main description to prevent any future conflicts. PR-URL: https://github.com/nodejs/node/pull/25015 Reviewed-By:
-
- Dec 13, 2018
-
-
Ruben Bridgewater authored
This makes sure these two properties are non-enumerable. This aligns them with all other globals that are not enumerable by spec. Refs: https://github.com/nodejs/node/issues/20565 PR-URL: https://github.com/nodejs/node/pull/24874 Refs: https://github.com/nodejs/node/issues/20565 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Rich Trott authored
Split test-cli-syntax into multiple files to improve reliability and/or isolate unreliable test cases. Move test cases back to parallel as appropriate. PR-URL: https://github.com/nodejs/node/pull/24922 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Yael Hermon authored
When the worker thread exits, drain the messages also from the internal message port so that the call to 'kDispose' will occur only after all the messages from the worker were processed in the parent, so stdio messages from the worker will be successfully pushed to their target streams in the parent. PR-URL: https://github.com/nodejs/node/pull/24932 Fixes: https://github.com/nodejs/node/issues/24636 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently, if configured --without-ssl the following compiler error will be generated: ../src/node_metadata.cc:29:12: error: use of undeclared identifier 'llhttp_version' llhttp = llhttp_version; ^ ../src/node_metadata.cc:30:17: error: use of undeclared identifier 'http_parser_version' http_parser = http_parser_version; This commit includes the node_internals.h header so that llhttp_version and http_parser_versions are always available. PR-URL: https://github.com/nodejs/node/pull/24933 Reviewed-By: -
Beni von Cheni authored
In places of process.binding('inspector'), migrate code to adapt internalBinding. PR-URL: https://github.com/nodejs/node/pull/24931 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: -
Joyee Cheung authored
Previously we create env->inspector_console_api_object() when `process.binding('inspector')` is called, which may be too late if the inspector console is used before the first call to `process.binding('inspector')` - that is possible when using `--inspect-brk-node`. Setting a breakpoint and using the inspector console before that would crash the process. This patch moves the initialization of the console API object to the point when Environment is initialized so that `installAdditionalCommandLineAPI()` can be essentially a noop if we use the inspector console before the inspector binding is initialized instead of crashing on an empty object. PR-URL: https://github.com/nodejs/node/pull/24906 Reviewed-By:Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Anna Henningsen authored
Get a proper stack trace when no callback is passed. PR-URL: https://github.com/nodejs/node/pull/24929 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
- Dec 12, 2018
-
-
Ilarion Halushka authored
* change 'for' loop to 'for of' loop * remove unused parameters passed to functions * remove unnecessary 'assert.ok' PR-URL: https://github.com/nodejs/node/pull/24927 Reviewed-By:
-
Ruben Bridgewater authored
Currently it is not possible to inspect getters. To prevent any side effects this should not become a default but under lots of circumstances it would still be useful to inspect getters. This way it is possible to actively opt into inspecting those. PR-URL: https://github.com/nodejs/node/pull/24852 Reviewed-By:
-
Sam Roberts authored
Support the same PEM certificate formats for the ca: option to tls.createSecureContext() that are supported by openssl when loading a CAfile. Fixes: https://github.com/nodejs/node/issues/24761 PR-URL: https://github.com/nodejs/node/pull/24733 Reviewed-By:
-
Sam Roberts authored
TLS client authentication should be tested, including failure scenarios. PR-URL: https://github.com/nodejs/node/pull/24733 Reviewed-By:
-
Anna Henningsen authored
HTTP/2 streams call `.end()` on themselves from their `.destroy()` method, which might be queued (e.g. due to network congestion) and not processed before the stream itself is destroyed. In that case, the `_writableState.ended` property could be set before the stream emits its `'close'` event, and never actually emits the `'finished'` event, confusing the end-of-stream implementation so that it wouldn’t call its callback. This can be fixed by watching for the end events themselves using the existing `'finish'` and `'end'` listeners rather than relying on the `.ended` properties of the `_...State` objects. These properties still need to be checked to know whether stream closure was premature – My understanding is that ideally, streams should not emit `'close'` before `'end'` and/or `'finished'`, so this might be another bug, but changing this would require modifying tests and almost certainly be a breaking change. Fixes: https://github.com/nodejs/node/issues/24456 PR-URL: https://github.com/nodejs/node/pull/24926 Reviewed-By:
-
Rich Trott authored
Revise the Useful CI Jobs section of the Collaborator Guide to be more clear and concise. PR-URL: https://github.com/nodejs/node/pull/24916 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
cjihrig authored
The V8 platform's CallOnForegroundThread() method is deprecated. This commit replaces its use with GetForegroundTaskRunner() functionality instead. PR-URL: https://github.com/nodejs/node/pull/24925 Reviewed-By:
-
Shubham Urkade authored
PR-URL: https://github.com/nodejs/node/pull/24866 Reviewed-By:
-
yoshimoto koki authored
Add documentation about Worker class inherits from EventEmitter. PR-URL: https://github.com/nodejs/node/pull/24849 Reviewed-By:
-
cjihrig authored
This fixes a deprecation warning. PR-URL: https://github.com/nodejs/node/pull/24924 Reviewed-By:
-
Shelley Vohr authored
Notable changes: * deps: * upgrade to c-ares v1.15.0 (Ben Noordhuis) https://github.com/nodejs/node/pull/23854 * Windows: * A crashing process will now show the names of stack frames if the node.pdb file is available. (Refael Ackermann) https://github.com/nodejs/node/pull/23822 * Added new collaborators: * Peter Marshall. https://github.com/nodejs/node/pull/24170 * Masashi Hirano. https://github.com/nodejs/node/pull/24136 PR-URL: https://github.com/nodejs/node/pull/24727 -
Richard Lau authored
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: https://github.com/nodejs/node/pull/24967 Reviewed-By:
-
