- Apr 17, 2018
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/19855 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Include the exit code in test failures. This will give us more information during the currently-puzzling failures that provide no information in CI such as: ``` 03:10:10 not ok 563 parallel/test-fs-truncate 03:10:10 --- 03:10:10 duration_ms: 1.119 03:10:10 severity: fail 03:10:10 stack: |- 03:10:10 ... ``` PR-URL: https://github.com/nodejs/node/pull/19855 Reviewed-By:
-
Rich Trott authored
Improve description of `encoding` option. (This change is also applied to `buf.indexOf()`.) Improve punctuation. Wrap at 80 characters. PR-URL: https://github.com/nodejs/node/pull/19904 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Shigeki Ohtsu authored
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly. Fixes: https://github.com/nodejs/node/issues/19918 PR-URL: https://github.com/nodejs/node/pull/19943 Refs: https://github.com/nodejs/node/pull/19930 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19955 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19951 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Evan Lucas authored
I no longer have the time to dedicate to being on the TSC. I am still planning to contribute when time permits. PR-URL: https://github.com/nodejs/node/pull/19953 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Adds `isBigInt64Array` and `isBigUint64Array`. PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Malcolm White authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Yang Guo authored
Even if we only use v8_monolith build target, other targets in v8.gyp with possibly outdated file lists are parsed and could cause build to fail even with --build-v8-with-gn. PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Joyee Cheung authored
Refs: https://github.com/v8/v8/commit/f9934aa9cf77b76c5fa78137e32939f30d9e2f81 Fixes: https://github.com/nodejs/node-v8/issues/36 PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Michaël Zasso authored
Synchronize source files list with upstream's BUILD.gn. PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Myles Borins authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.6. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19942 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19938 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19881 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Luigi Pinca authored
Fix test-http-dump-req-when-res-ends and move it back to test/parallel/ PR-URL: https://github.com/nodejs/node/pull/19866 Refs: https://github.com/nodejs/node/pull/19823 Reviewed-By:
-
Pieter Mees authored
PR-URL: https://github.com/nodejs/node/pull/19842 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Pieter Mees authored
PR-URL: https://github.com/nodejs/node/pull/19842 Reviewed-By:
-
Daniel Bevenius authored
This test currently fails when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit moves the require of http2 to come after the crypto check to avoid the error. PR-URL: https://github.com/nodejs/node/pull/19907 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Daniel Bevenius authored
Currently this test fails if run as the root user: Mismatched innerFn function calls. Expected exactly 62, actual 42. The motivation for this is that when building node in a docker container it is convenient to be able to build as root. PR-URL: https://github.com/nodejs/node/pull/19850 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/19682 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/19684 Reviewed-By:
Jackson Tian <shyvo1987@gmail.com> Reviewed-By:
-
- Apr 11, 2018
-
-
cjihrig authored
This commit adds basic functionality testing of the help URL printed when the inspector starts. PR-URL: https://github.com/nodejs/node/pull/19887 Refs: https://github.com/nodejs/node/pull/19871 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
- Apr 10, 2018
-
-
Jesse Gorzinski authored
PR-URL: https://github.com/nodejs/node/pull/19667 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19913 Reviewed-By:
-
Luigi Pinca authored
Strip the enclosing square brackets from the parsed hostname. PR-URL: https://github.com/nodejs/node/pull/19720 Reviewed-By:
-
juggernaut451 authored
PR-URL: https://github.com/nodejs/node/pull/18985 Reviewed-By:
-
juggernaut451 authored
Added common.mustCall and replaced function with arrow function. PR-URL: https://github.com/nodejs/node/pull/19096 Fixes: https://github.com/nodejs/node/issues/14544 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Nick Filatov authored
PR-URL: https://github.com/nodejs/node/pull/19871 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Kohei Hiraga authored
fs.ReadStream / fs.WriteStream destroy([error]) function should emit 'error' event if `error` is set. PR-URL: https://github.com/nodejs/node/pull/19735 Fixes: https://github.com/nodejs/node/issues/19727 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure acorn is only loaded in case it is necessary. PR-URL: https://github.com/nodejs/node/pull/19863 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
`assert.throws` also accepts objects and errors as input. This fixes the error message accodingly. PR-URL: https://github.com/nodejs/node/pull/19865 Reviewed-By:
-
Joyee Cheung authored
The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users. PR-URL: https://github.com/nodejs/node/pull/19864 Refs: https://github.com/nodejs/node/pull/19739 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
