- Feb 25, 2021
-
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.9. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
- Feb 24, 2021
-
-
Antoine du Hamel authored
Original commit message: Fix GetSharedLibraryAddresses This patch fixes a segmentation fault which occurs when using `--prof` flag on a Darwin ARM64 architecture. See https://github.com/nodejs/node/issues/36656 Change-Id: Idc3ce6c8fd8a24f76f1b356f629e37340045b51e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609413 Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72886} Refs: https://github.com/v8/v8/commit/8957d4677aa794c230577f234071af0dadb88f7b Fixes: https://github.com/nodejs/node/issues/36656 PR-URL: https://github.com/nodejs/node/pull/37471 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Ash Cripps <acripps@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
Ikko Ashimine authored
settting -> setting PR-URL: https://github.com/nodejs/node/pull/37469 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37204 Fixes: https://github.com/nodejs/node/issues/26588 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
As far as I know, this test hasn't failed since around the time it was first reported in 2019. Closes: https://github.com/nodejs/node/issues/30847 PR-URL: https://github.com/nodejs/node/pull/37462 Fixes: https://github.com/nodejs/node/issues/30847 Reviewed-By:
-
James M Snell authored
The time assertion was inaccurate. Just remove it as it's not strictly necessary PR-URL: https://github.com/nodejs/node/pull/37493 Reviewed-By:
-
Michael Dawson authored
Refs: https://github.com/nodejs/node/issues/31763 This test would have helped us catch the noisy output from http2 earlier. Currently none of the tests fail if there is unexpected debug output. Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/37447 Reviewed-By:
Beth Griggs <bgriggs@redhat.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37478 Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37479 Reviewed-By:
-
- Feb 23, 2021
-
-
Richard Lau authored
This is a security release. Notable changes Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/255 -
Richard Lau authored
This is a security release. Notable changes Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/256 -
Beth Griggs authored
This is a security release. Notable changes: Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/254 -
Beth Griggs authored
This is a security release. Notable changes: Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/253 -
Daniel Bevenius authored
This commit add a configuration options named unknownProtocolTimeout which can be specified to set a value for the timeout in milliseconds that a server should wait when an unknowProtocol is sent to it. When this happens a timer will be started and the if the socket has not been destroyed during that time the timer callback will destoy it. Refs: https://hackerone.com/reports/1043360 CVE-ID: CVE-2021-22883 PR-URL: https://github.com/nodejs-private/node-private/pull/246 Reviewed-By:
-
Matteo Collina authored
CVE-ID: CVE-2021-22884 Refs: https://hackerone.com/bugs?report_id=1069487 PR-URL: https://github.com/nodejs-private/node-private/pull/244 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
-
Darshan Sen authored
Fixes: https://github.com/nodejs/node/issues/37442 PR-URL: https://github.com/nodejs/node/pull/37443 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Rich Trott authored
The test hasn't failed in a long time as far as I can tell. The issue may have been fixed by various event updates/changes to http2 and related systems. PR-URL: https://github.com/nodejs/node/pull/37461 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/37458 Reviewed-By:
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/37362 Reviewed-By:
Ian Sutherland <ian@iansutherland.ca> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
-
James M Snell authored
* Update the user timing implementation to conform to User Timing Level 3. * Reimplement user timing and timerify with pure JavaScript implementations * Simplify the C++ implementation for gc and http2 perf * Runtime deprecate additional perf entry properties in favor of the standard detail argument * Disable the `buffered` option on PerformanceObserver, all entries are queued and dispatched on setImmediate. Only entries with active observers are buffered. * This does remove the user timing and timerify trace events. Because the trace_events are still considered experimental, those can be removed without a deprecation cycle. They are removed to improve performance and reduce complexity. Old: `perf_hooks/usertiming.js n=100000: 92,378.01249733355` New: perf_hooks/usertiming.js n=100000: 270,393.5280638482` PR-URL: https://github.com/nodejs/node/pull/37136 Refs: https://github.com/nodejs/diagnostics/issues/464 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/37451 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/37450 Reviewed-By:
-
- Feb 22, 2021
-
-
Michael Dawson authored
Change links in api docs to use HEAD when they refer to the primary branch. Signed-off-by:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Michael Dawson authored
fix alignment of parameters in napi_fatal_error Signed-off-by:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37400 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37398 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/37388 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
Darshan Sen authored
This emphasizes that `tmpdir.refresh()` must be called only once in each test file when needed. PR-URL: https://github.com/nodejs/node/pull/37383 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37344 Reviewed-By:
-
Dan Čermák authored
Signed-off-by:
Dan Čermák <dcermak@suse.com> Co-authored-by:
-
dr-js authored
Note: this only add checks for async spawn, as the sync spawn do not return a `subProcess`. PR-URL: https://github.com/nodejs/node/pull/37014 Reviewed-By:
-
dr-js authored
From the code `nodejs@8` and up should behave the same: github.com/nodejs/node/blame/v8.17.0/lib/internal/child_process.js#L290 And a short test snippet: ```js const { spawn } = require('child_process') const subProcess = spawn('non-exist-command') subProcess.on('error', (error) => console.warn('mute Unhandled "error" event:', error)) console.log('- pid:', subProcess.pid) process.nextTick(() => console.log('- after error emit')) console.log('== end of test ==') ``` Note: the sync spawn result `pid` currently do not follow this pattern. Co-authored-by:
-
