- Nov 23, 2020
-
-
Rich Trott authored
https://github.com/cpplint/cpplint/releases/tag/1.5.2 PR-URL: https://github.com/nodejs/node/pull/36213 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Rich Trott authored
In preparation for a cpplint version bump, move labels to be unindented. The one space indentation we use now is flagged in cpplint 1.5.2. Refs: https://softwareengineering.stackexchange.com/q/151806/26510 PR-URL: https://github.com/nodejs/node/pull/36213 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-1 PR-URL: https://github.com/nodejs/node/pull/36187 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
- Nov 22, 2020
-
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/36189 Refs: https://github.com/nodejs/build/issues/2474 Reviewed-By:
Ash Cripps <acripps@redhat.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36175 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Hollow Man authored
alredy -> already PR-URL: https://github.com/nodejs/node/pull/36193 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
rexagod authored
This adds support for error handling in readline.createInterface() for cases where the input object is not supplied, the input stream is invalid, or the underlying buffer emits an error. Now, the 'error' emissions by the readline module are thrown but in order to log those in the specific case of await for loops, we still need to fix silent rejections (TODO added there) inside async iterators for the thenables to work. Fixes: https://github.com/nodejs/node/issues/30831 PR-URL: https://github.com/nodejs/node/pull/31603 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
- Nov 21, 2020
-
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/35912 Refs: https://github.com/nodejs/node/issues/22610 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36163 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
Rich Trott authored
Update comment to refer to the correct ASCII code (120 rather than 66). All other changes are cosmetic. PR-URL: https://github.com/nodejs/node/pull/36152 Reviewed-By:
-
Madara Uchiha authored
- Add support - Add test - Docs once PR is up PR-URL: https://github.com/nodejs/node/pull/36070 Reviewed-By:
-
Gabriel Schulhof authored
* Remove dead code for `GetterCallbackWrapper` and `SetterCallbackWrapper`. * Factor out creation of new `v8::Function`s. * Factor out creation of new `v8::FunctionTemplate`s. * Turn `CallbackBundle` into a class, internalizing creation of new instances and garbage collection. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/36170 Reviewed-By:
-
Gabriel Schulhof authored
Signed-off-by:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By:
-
Rich Trott authored
Two minor punctuation fixes for v8.md. PR-URL: https://github.com/nodejs/node/pull/36192 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36168 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36142 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
-
- Nov 20, 2020
-
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/35323 Reviewed-By:
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/36153 Reviewed-By:
-
Baruch Odem authored
PR-URL: https://github.com/nodejs/node/pull/36033 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36106 Reviewed-By:
-
Gabriel Schulhof authored
Change the documentation for `napi_define_class` in such a way that it mentions wrapping C++ class instances as a possible use for the API, rather than making the assumption that it is the use case for the API. Signed-off-by:
-
Gabriel Schulhof authored
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by:
-
Myles Borins authored
There are only 2 cores available so we shouldn't be using -j8 Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: https://github.com/nodejs/node/pull/36169 Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36118 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36140 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36141 Reviewed-By:
-
Anders Kaseorg authored
This was missed in commit 35b17d9a. Refs: https://github.com/nodejs/node/issues/34278 Refs: https://github.com/nodejs/node/pull/35171 Signed-off-by:
Anders Kaseorg <andersk@mit.edu> PR-URL: https://github.com/nodejs/node/pull/36131 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
- Nov 19, 2020
-
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36115 Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36048 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36149 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36135 Reviewed-By:
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36128 Reviewed-By:
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/26317 PR-URL: https://github.com/nodejs/node/pull/36032 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35781 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Andrew Casey authored
For consumers that aren't interested in *why* a `statSync` call failed, allocating and throwing an exception is an unnecessary expense. This PR adds an option that will cause it to return `undefined` in such cases instead. As a motivating example, the JavaScript & TypeScript language service shared between Visual Studio and Visual Studio Code is stuck with synchronous file IO for architectural and backward-compatibility reasons. It frequently needs to speculatively check for the existence of files and directories that may not exist (and cares about file vs directory, so `existsSync` is insufficient), but ignores file system entries it can't access, regardless of the reason. Benchmarking the language service is difficult because it's so hard to get good coverage of both code bases and user behaviors, but, as a representative metric, we measured batch compilation of a few hundred popular projects (by star count) from GitHub and found that, on average, we saved about 1-2% of total compilation time. We speculate that the savings could be even more significant in interactive (language service or watch mode) scenarios, where the same (non-existent) files need to be polled over and over again. It's not a huge improvement, but it's a very small change and it will affect a lot of users (and CI runs). For reference, our measurements were against `v12.x` (3637a061 at the time) on an Ubuntu Server desktop with an SSD. PR-URL: https://github.com/nodejs/node/pull/33716 Reviewed-By:
-
Anna Henningsen authored
Because the following gives basically no actionable information on its own, neither in the error message nor in the stack trace: (node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead. at emitMakeCallbackDeprecation (domain.js:123:13) at process.topLevelDomainCallback (domain.js:135:5) at process.callbackTrampoline (internal/async_hooks.js:124:14) PR-URL: https://github.com/nodejs/node/pull/36136 Reviewed-By: -
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36122 Reviewed-By:
-
Rishabh Mehan authored
PR-URL: https://github.com/nodejs/node/pull/33735 Reviewed-By:
-
Nikola Glavina authored
PR-URL: https://github.com/nodejs/node/pull/34180 Fixes: https://github.com/nodejs/node/issues/34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
