- Mar 19, 2021
-
-
ExE Boss authored
Refs: https://github.com/nodejs/node/pull/37178 PR-URL: https://github.com/nodejs/node/pull/37246 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
ExE Boss authored
Fixes: https://github.com/nodejs/node/issues/36098 Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by:
Guy Bedford <guybedford@gmail.com> Co-authored-by:
Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37246 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37773 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
marsonya authored
'referred' was spelled as 'refered' PR-URL: https://github.com/nodejs/node/pull/37741 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
dbachko authored
PR-URL: https://github.com/nodejs/node/pull/37738 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
Ian Kerins authored
PR-URL: https://github.com/nodejs/node/pull/37716 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
marsonya authored
Instead of writing each Math function and keeping track, loop over Math functions and test each one of them. PR-URL: https://github.com/nodejs/node/pull/37670 Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Nitzan Uziely authored
Add support for timeout to spawn and fork. Fixes: https://github.com/nodejs/node/issues/27639 PR-URL: https://github.com/nodejs/node/pull/37256 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Gabriel Schulhof authored
A gc may happen during environment teardown. Thus, during finalization initiated by environment teardown we must remove the V8 finalizer before calling the Node-API finalizer. Fixes: https://github.com/nodejs/node/issues/37236 PR-URL: https://github.com/nodejs/node/pull/37616 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Filip Skokan authored
fixes https://github.com/nodejs/node/issues/37794 PR-URL: https://github.com/nodejs/node/pull/37795 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37529 Fixes: https://github.com/nodejs/node/issues/3462 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37529 Fixes: https://github.com/nodejs/node/issues/3462 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
- Mar 18, 2021
-
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/37765 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Add a known_issues test for a known Windows issue. Refs: https://github.com/nodejs/node/issues/13683 PR-URL: https://github.com/nodejs/node/pull/37744 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Rich Trott authored
Move Y2K38-specific parts of test-fs-utimes to test-fs-utimes-y2K38.js. On non-Windows, check for Y2K38 support and skip if it is unsupported. Fixes: https://github.com/nodejs/node/issues/36591 PR-URL: https://github.com/nodejs/node/pull/37707 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Danielle Adams authored
PR-URL: https://github.com/nodejs/node/pull/37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) https://github.com/nodejs/node/pull/37500 * support JWK objects in create\*Key (Filip Skokan) https://github.com/nodejs/node/pull/37254 * deps: * update to cjs-module-lexer@1.1.0 (Guy Bedford) https://github.com/nodejs/node/pull/37712 * switch openssl to quictls/openssl (James M Snell) https://github.com/nodejs/node/pull/37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) https://github.com/nodejs/node/pull/37610 * improve fsPromises readFile performance (Nitzan Uziely) https://github.com/nodejs/node/pull/37608 * lib: * implement AbortSignal.abort() (James M Snell) https://github.com/nodejs/node/pull/37693 * node-api: * define version 8 (Gabriel Schulhof) https://github.com/nodejs/node/pull/37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) https://github.com/nodejs/node/pull/37486
-
James Addison authored
This indicates to GNU binutils that it can unset the executable stack flag on the binary that it is building. PR-URL: https://github.com/nodejs/node/pull/37688 Refs: https://github.com/nodejs/node/issues/17933 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
- Mar 17, 2021
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/37712 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
cjihrig authored
Update ESLint to 7.22.0 PR-URL: https://github.com/nodejs/node/pull/37734 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Antoine du Hamel authored
The `lint-md` job on GitHub Actions parses the changelogs to determine if the version numbers referenced in the YAML comments in the docs match actual releases of Node.js. Changelogs are sometimes not backported to release branches; this commit disables changelog parsing on branches other than the default one. Refs: https://github.com/nodejs/node/pull/37767 PR-URL: https://github.com/nodejs/node/pull/37768 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
Ruy Adorno <ruyadorno@github.com>
-
- Mar 16, 2021
-
-
marsonya authored
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that. PR-URL: https://github.com/nodejs/node/pull/37667 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com>
-
Daniel Bevenius authored
This commit enables node to dynamically link against OpenSSL 3.0. The motivation for opening this PR even though OpenSSL 3.0 has not been released yet is to allow a nightly CI job to be created. This will allow us stay on top of changes required for OpenSSL 3.0, and also to make sure that changes to node crypto do not cause issues when linking to OpenSSL 3.0. PR-URL: https://github.com/nodejs/node/pull/37669 Refs: https://github.com/nodejs/node/issues/29817 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Ruy Adorno authored
The scripts `./tools/update-babel-eslint.sh` and `./tools/update-eslint.sh` are relying on the version of `npm` found in the local-defined `$PATH` env. This changeset proposes to modify these scripts to run the version of npm bundled in the current branch (found at `./deps/npm`) - in order to: a) Standardize the version of npm that should be use to install these deps, avoids the pitfall of having an inadverted user run these scripts with an unsupported/incompatible npm version. b) Given that npm7 has a different install algorithm than npm6 that takes into account and install peer dependencies, it might be a safer choice to ensure what version of npm should be use during this transitional period in which users might still have npm6 by default in their local system. c) Avoids the possible extra churn of having different resulting files being shuffled around between installs due to usage of a disparate version of the npm cli. PR-URL: https://github.com/nodejs/node/...
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/37743 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
Ian Sutherland <ian@iansutherland.ca> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/37745 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Ash Cripps authored
PR-URL: https://github.com/nodejs/node/pull/37677 Refs: https://github.com/nodejs/build/issues/2445 Reviewed-By:
Stewart X Addison <sxa@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Mar 15, 2021
-
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37693 Refs: https://github.com/whatwg/dom/pull/960 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
James M Snell authored
Refs: https://github.com/whatwg/dom/pull/960 PR-URL: https://github.com/nodejs/node/pull/37693 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Michaël Zasso authored
Fixes: https://github.com/nodejs/node-v8/issues/193 PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
cjihrig authored
V8 has removed argument adapter frames. This commit removes them from the Node.js codebase as well. PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michaël Zasso authored
The script versions are no longer available. PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michaël Zasso authored
Original commit message: torque: workaround stod() limitations on Solaris std::stod() on Solaris does not currently handle hex strings. This commit provides a workaround based on strtol() until proper stod() support is available. This was encountered while updating Node.js to V8 8.8. For more details see the following comment: https://github.com/nodejs/node/pull/36139#issuecomment-740131942 Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746 Reviewed-by:Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#73255} Refs: https://github.com/v8/v8/commit/1648e050cade0e0803714a488ab0c8817d9eaf5c PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-