- Oct 04, 2018
-
-
Joyee Cheung authored
This patch: - Refactors the `MemoryRetainer` API so that the impementer no longer calls `TrackThis()` that sets the size of node on the top of the stack, which may be hard to understand. Instead now they implements `SelfSize()` to provide their self sizes. Also documents the API in the header. - Refactors `MemoryTracker` so it calls `MemoryInfoName()` and `SelfSize()` of `MemoryRetainer` to retrieve info about them, and separate `node_names` and `edge_names` so the edges can be properly named with reference names and the nodes can be named with class names. (Previously the nodes are named with reference names while the edges are all indexed and appear as array elements). - Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and `SET_NO_MEMORY_INFO()` convenience macros - Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track their references properly. - Refactors the heapdump tests to check both node names and edge names, distinguishing between wrapped JS nodes (without prefixes) and embedder wrappers (prefixed with `Node / `). PR-URL: https://github.com/nodejs/node/pull/23072 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anna Henningsen authored
Give the callback a more specific name, explain what it does and why it is necessary, and move it to a location much closer to its use site. PR-URL: https://github.com/nodejs/node/pull/23187 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
Verify that worker.process.kill() can terminate a cluster worker stuck in an infinite loop. PR-URL: https://github.com/nodejs/node/pull/23165 Fixes: https://github.com/nodejs/node/issues/22703 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
cjihrig authored
worker.kill() relies on a graceful disconnect, which might not always be possible. This commit calls this out in the docs, and specifies worker.process.kill() as a non-graceful alternative. PR-URL: https://github.com/nodejs/node/pull/23165 Fixes: https://github.com/nodejs/node/issues/22703 Reviewed-By:
-
Anna Henningsen authored
Split the existing `Write()` method into one that takes care of translating the arguments from JS to C++, and a non-static method for the actual write operations, as well as some minor stylistic drive-by fixes. PR-URL: https://github.com/nodejs/node/pull/23183 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Daniel Bevenius authored
This commit adds -Wno-strict-aliasing to the icu_implementation target. The motivation for this is that this flags is enabled when building with macosx, and will make the output a little cleaner when building on other operating systems. PR-URL: https://github.com/nodejs/node/pull/23112 Reviewed-By:
-
Gus Caplan authored
internalBinding is used so often that it should just automatically be available for usage in internals. PR-URL: https://github.com/nodejs/node/pull/23025 Refs: https://github.com/nodejs/node/commit/2a9eb31 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Refael Ackermann authored
* Make inspector.gypi and v8_external_snapshot.gypi includible targets. * Make `v8_dump_build_config` an action * Better separate `js2c` and `natives_blob` * process action outputs as sources * trigger v8.gyp:postmortem-metadata from v8.gyp PR-URL: https://github.com/nodejs/node/pull/23182 Refs: https://github.com/nodejs/node/pull/23156 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/23176 Reviewed-By:
-
Denys Otrishko authored
* decrease number of requests 500 -> 300 * extract 'cb' to a file-local function This should make test more reliable and less resource intensive. PR-URL: https://github.com/nodejs/node/pull/23184 Refs: https://github.com/nodejs/node/issues/23066 Reviewed-By:
-
Sam Ruby authored
Building on Mac OS/X as follows: ``` ./configure --shared make -j4 test ``` Results in: ``` dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not found make: *** [cctest] Abort trap: 6 ``` This change adds the loader path to the runtime path for the `cctest` executable. PR-URL: https://github.com/nodejs/node/pull/23168 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/23198 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/23197 Reviewed-By:
-
Anna Henningsen authored
This method, like all other methods which use `Isolate::GetCurrent()`, should be avoided. This was probably overlooked in 75adde07. PR-URL: https://github.com/nodejs/node/pull/23175 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
These helpers provide no benefit over the existing V8 API, and at least one of them fetches the current `Isolate` through `Isolate::GetCurrent()` (which should be avoided). PR-URL: https://github.com/nodejs/node/pull/23179 Reviewed-By:
-
Rich Trott authored
Simplify and clarify text in the Download section of the README file. PR-URL: https://github.com/nodejs/node/pull/23212 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
The Google Analytics tracking wasn't wholly uncontroversial and hasn't been used in practice. Remove it. PR-URL: https://github.com/nodejs/node/pull/23083 Fixes: https://github.com/nodejs/node/issues/22652 Refs: https://github.com/nodejs/node/pull/6601 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Matteo Collina authored
PR-URL: https://github.com/nodejs/node/pull/23051 Fixes: https://github.com/nodejs/node/issues/22814 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
George Adams <george.adams@uk.ibm.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/23069 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Anna Henningsen authored
For all classes descending from `AsyncWrap`, use JS inheritance instead of manually adding methods to the individual classes. This allows cleanup of some code around transferring handles over IPC. PR-URL: https://github.com/nodejs/node/pull/23094 Reviewed-By:
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/23238 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Franziska Hinkelmann authored
PR-URL: https://github.com/nodejs/node/pull/22759 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
- Oct 03, 2018
-
-
Rich Trott authored
Simplify text and improve clarity. PR-URL: https://github.com/nodejs/node/pull/23190 Reviewed-By:
-
David Halls authored
PR-URL: https://github.com/nodejs/node/pull/23134 Fixes: https://github.com/nodejs/node/issues/23116 Reviewed-By:
-
Josh Broomfield authored
PR-URL: https://github.com/nodejs/node/pull/23118 Reviewed-By:
-
shisama authored
Added tests to occur error when empty buffer is passed to fs.read() to increase coverage. PR-URL: https://github.com/nodejs/node/pull/23141 Reviewed-By:
-
André Cruz authored
There is a race condition between onStreamCloseResponse(), which removes the wantTrailers listener, and Http2Stream.close(), which will invalidate the connection. IE, sendTrailers can be called on a closed connection which would crash with a: Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed PR-URL: https://github.com/nodejs/node/pull/23146 Reviewed-By:
-
Daniel Bevenius authored
This commit extracts the throwing of ERR_INVALID_ARG_TYPE which is done in identical ways in a few places in cipher.js. The motivation for this is that I think it improves readability enough to warrant a commit even though I'm aware that we should avoid commits with only these sort of refactoring. PR-URL: https://github.com/nodejs/node/pull/22947 Reviewed-By:
-
cjihrig authored
Approved for fast-tracking by: Rich Trott <rtrott@gmail.com> Colin Ihrig <cjihrig@gmail.com> Refael Ackermann <refack@gmail.com> James M Snell <jasnell@gmail.com> Gireesh Punathil <gpunathi@in.ibm.com> Anna Henningsen <anna@addaleax.net> Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/23232 Reviewed-By:
-
Rich Trott authored
Make the Support section of the README file easier to read and understand. PR-URL: https://github.com/nodejs/node/pull/23170 Reviewed-By:
-
Refael Ackermann authored
Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal. Adding it makes the action run alway, even when there are no changes. (refack): AFAICT because `*.intermediate` files don't have build rules. PR-URL: https://github.com/nodejs/node/pull/23156 Reviewed-By:
-
Refael Ackermann authored
Puts the compilation target upfront for easy reading. PR-URL: https://github.com/nodejs/node/pull/23156 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23156 Reviewed-By:
-
Refael Ackermann authored
Run `node_js2c` and `mkssldef` as actions and not as targets makes sure they are run only once, just before processing the rest of `node_lib`. This helps `make` based dependency change detection be more accurate. Add comments with tagrget names for readability. Use `process_outputs_as_sources` for automatic inclution of outputs. PR-URL: https://github.com/nodejs/node/pull/23156 Reviewed-By:
-
Ruben Bridgewater authored
Since the default for depth is changed to `20` it is logical to change the %o default as well. It will now always use the default depth. PR-URL: https://github.com/nodejs/node/pull/17907 Refs: https://github.com/nodejs/node/issues/12693 PR-URL: https://github.com/nodejs/node/pull/22846 Reviewed-By:
-
Ruben Bridgewater authored
The current default is not ideal in most use cases. Therefore it is changed to inspect objects to a maximum depth of 20 in case util.inspect is called with it's defaults. The default is kept at 2 when using console.log() and similar in the repl. PR-URL: https://github.com/nodejs/node/pull/17907 Refs: https://github.com/nodejs/node/issues/12693 PR-URL: https://github.com/nodejs/node/pull/22846 Reviewed-By:
-
Rich Trott authored
For tab completion, a REPLServer instance will sometimes create another REPLServer instance. If a callback is sent to the `.complete()` function and that callback throws an error, it will be swallowed by the nested REPLs domain. Re-throw the error so that processes don't silently exit without any indication of an error (including a status code). Fixes: https://github.com/nodejs/node/issues/21586 PR-URL: https://github.com/nodejs/node/pull/23004 Reviewed-By:
-
Richard Lau authored
npm test directories are excluded on other platforms by `tools/install.py`. Do the same on Windows. Fixes: https://github.com/nodejs/node/issues/22901 PR-URL: https://github.com/nodejs/node/pull/23001 Reviewed-By:
João Reis <reis@janeasystems.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23208 Reviewed-By:
-
Anto Aravinth authored
This makes sure the `null` prototype is always detected properly. PR-URL: https://github.com/nodejs/node/pull/22331 Fixes: https://github.com/nodejs/node/issues/22141 Reviewed-By:
-
