- Oct 18, 2018
-
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/23657 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Nancy Truong authored
PR-URL: https://github.com/nodejs/node/pull/23519 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
Anatoli Papirovski authored
In order to better match the browser behaviour, run nextTicks (and subsequently the microtask queue) after each individual Timer and Immediate, rather than after the whole list is processed. The current behaviour is somewhat of a performance micro-optimization and also partly dictated by how timer handles were implemented. PR-URL: https://github.com/nodejs/node/pull/22842 Fixes: https://github.com/nodejs/node/issues/22257 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/23662 Refs: https://github.com/nodejs/node/pull/22675 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Roman Reiss authored
Two changes here which bring us closer to the console standard: - Arguments to `util.format` are no longer formatted differently depending on their order, with format strings being an exception. - Format specifier formatting is now only triggered if the string actually contains a format string. Under the hood, we now use a single shared function to format the given arguments which will make the code easier to read and modify. PR-URL: https://github.com/nodejs/node/pull/23162 Fixes: https://github.com/nodejs/node/issues/23137 Reviewed-By:
-
Steven Auger authored
PR-URL: https://github.com/nodejs/node/pull/23615 Reviewed-By:
Sam Ruby <rubys@intertwingly.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
cjihrig authored
onConnectEnd(), which is called by TLSSocket, has a guard to prevent being called multiple times, but it does not prevent the OpenSSL error handler from being called, leading to multiple error events. This commit adds that piece of missing logic. PR-URL: https://github.com/nodejs/node/pull/23636 Fixes: https://github.com/nodejs/node/issues/23631 Reviewed-By:
Wyatt Preul <wpreul@gmail.com> Reviewed-By:
-
Tobias Nießen authored
Uninitialized instances are not exposed to users, so this condition should always be true. PR-URL: https://github.com/nodejs/node/pull/23648 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Tobias Nießen authored
The type of the argument is being checked within JS which makes the type checking in C++ unnecessary. PR-URL: https://github.com/nodejs/node/pull/23647 Reviewed-By:
-
cjihrig authored
Use the non-deprecated version of GetPropertyNames(). PR-URL: https://github.com/nodejs/node/pull/23660 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
- Oct 17, 2018
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23650 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Shelley Vohr authored
Electron uses BoringSSL which does not support OCB . It is also possible to build OpenSSL without support for OCB for Node.js. This commit disables OCB if OPENSSL_NO_OCB is defined. PR-URL: https://github.com/nodejs/node/pull/23635 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/7.0.276.25...7.0.276.28 PR-URL: https://github.com/nodejs/node/pull/23424 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Chi-chi Wang authored
also... return TextDecoder directly from factories PR-URL: https://github.com/nodejs/node/pull/23625 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
- Oct 16, 2018
-
-
Refael Ackermann authored
they will be skipped if run with `--flaky-tests=skip` PR-URL: https://github.com/nodejs/node/pull/23251 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Refael Ackermann authored
* Hoist common code to base class (`GetTestStatus`, and the `section` property to `TestConfiguration`) * Replace ListSet with the built in set * Remove ClassifiedTest * Inline PrintReport * How cases_to_run are filtered PR-URL: https://github.com/nodejs/node/pull/23251 Reviewed-By:
-
Jonathan Samines authored
Fix strictEqual assertion arguments order to conform to the function signature in buffer tests PR-URL: https://github.com/nodejs/node/pull/23486 Reviewed-By:
-
Dolapo Toki authored
PR-URL: https://github.com/nodejs/node/pull/23597 Reviewed-By:
-
Anna Henningsen authored
Split out things that are specific to zlib as a specific compression library, vs. the interface that is common to most C compression libraries. This should pave the way for including support for e.g. brotli. PR-URL: https://github.com/nodejs/node/pull/23360 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
christian-bromann authored
Add test to check: - for `null` as len parameter - if error is propagated into callback if file doesn't exist - if an error is actually thrown if len is not a number PR-URL: https://github.com/nodejs/node/pull/23620 Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Andreas Madsen authored
While it doesn't make any difference now. In the future PromiseHooks could be refactored to provide an asyncId instead of the promise object. That would make escape analysis on promises possible. Escape analysis on promises could lead to a more efficient destroy hook, if provide by PromiseHooks as well. But at the very least would allow the destroy hook to be emitted earlier. The destroy hook not being emitted on promises frequent enough is a known and reported issue. See https://github.com/nodejs/node/issues/14446 and https://github.com/Jeff-Lewis/cls-hooked/issues/11. While all this is speculation for now, it all depends on the promise object not being a part of the PromiseWrap resource object. Ref: https://github.com/nodejs/node/issues/14446 Ref: https://github.com/nodejs/diagnostics/issues/188 PR-URL: https://github.com/nodejs/node/pull/23443 Refs: https://github.com/nodejs/node/issues/14446 Refs: https://github.com/nodejs/diagnostics/issues/188 Reviewed-By:
Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By:
-
Sam Roberts authored
On my machine, this brings test execution time down from about 2 seconds to 0.2 seconds. PR-URL: https://github.com/nodejs/node/pull/23430 Reviewed-By:
-
- Oct 15, 2018
-
-
Jared Haines authored
Added test coverage for 4 un-covered if statements in slowCases PR-URL: https://github.com/nodejs/node/pull/23592 Reviewed-By:
-
Amanuel Ghebreweldi authored
PR-URL: https://github.com/nodejs/node/pull/23594 Reviewed-By:
-
Derek authored
PR-URL: https://github.com/nodejs/node/pull/23598 Reviewed-By:
-
Ian Sutherland authored
PR-URL: https://github.com/nodejs/node/pull/23599 Reviewed-By:
-
Chuck Theobald authored
Fix assert.strictEquals argument order. Arguments were actual first, expected second, contrary to the documentation. Now, actual value is first and expected value is second. PR-URL: https://github.com/nodejs/node/pull/23600 Reviewed-By:
-
David Jiang authored
PR-URL: https://github.com/nodejs/node/pull/23602 Reviewed-By:
-
Gino Notto authored
Change base64_encoded_size and unbase64 to inline functions. The base64_encoded_size is a constexpr to be used in function declarations. PR-URL: https://github.com/nodejs/node/pull/23603 Reviewed-By:
-
Emily Kolar authored
PR-URL: https://github.com/nodejs/node/pull/23604 Reviewed-By:
-
Paul Tichonczuk authored
PR-URL: https://github.com/nodejs/node/pull/23607 Reviewed-By:
-
Milton Sosa authored
PR-URL: https://github.com/nodejs/node/pull/23608 Reviewed-By:
-
Israel Ortiz authored
fixed order of parameters in assert.strictEqual() assertion functions, first argument provided was the expected value and the second value was the actual value. this is backwards from the documentation for assertions like assert.strictEqual() where the first value being tested and the second value is the expected value PR-URL: https://github.com/nodejs/node/pull/23609 Reviewed-By:
-
Vsevolod Geraskin authored
assert.strictEqual() had incorrect order of arguments with expected and actual values reversed. PR-URL: https://github.com/nodejs/node/pull/23613 Reviewed-By:
-
Sean Healy authored
Update assertions to be `value`, `expectedValue`. PR-URL: https://github.com/nodejs/node/pull/23614 Reviewed-By:
-
Stéphane Vasseur authored
PR-URL: https://github.com/nodejs/node/pull/23616 Reviewed-By:
-
vchoubey08 authored
PR-URL: https://github.com/nodejs/node/pull/23617 Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By:
-
Jeff Marvin authored
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: https://github.com/nodejs/node/pull/23618 Reviewed-By:
-
Martin Omander authored
The variable problemChecking was not used. Removed it. PR-URL: https://github.com/nodejs/node/pull/23624 Reviewed-By:
-
erickwendel authored
PR-URL: https://github.com/nodejs/node/pull/23626 Reviewed-By:
-
