- May 03, 2019
-
-
Ruben Bridgewater authored
This makes sure the `%d`, `%f`, `%i` and `%s` formatters properly visualize `-0`. On top, this also switches to using a safer symbol toString function by using the primordial function. PR-URL: https://github.com/nodejs/node/pull/27499 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Boxuan Li authored
PR-URL: https://github.com/nodejs/node/pull/27474 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
I asked Stefan if they would mind being moved to Collaborator Emeritus. They responded that they were not active in Node.js right now and that moving them was fine. PR-URL: https://github.com/nodejs/node/pull/27502 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/27507 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/27504 Refs: https://mobile.twitter.com/refack/status/1118484079077482498 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
cjihrig authored
EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: https://github.com/nodejs/node/pull/27500 Fixes: https://github.com/nodejs/node/issues/27487 Reviewed-By:
-
Ruben Bridgewater authored
This commit contains the following changes: 1) Add null prototype support for functions. 2) Safely detect async and generator functions. 3) Mark anonymous functions as such instead of just leaving out the name. PR-URL: https://github.com/nodejs/node/pull/27227 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
After looking into this it turned out that these two errors are sanity checks that should not be reached. It is unfortunate that we assigned error codes for these but changing it into an assertion seems to be a hassle for `readable-streams`. PR-URL: https://github.com/nodejs/node/pull/27086 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
cjihrig authored
This commit adds a --trace-tls command-line flag. The purpose is to enable tracing of TLS connections without the need to modify existing application code. PR-URL: https://github.com/nodejs/node/pull/27497 Reviewed-By:
-
cjihrig authored
This commit adds the enableTrace option to the TLSSocket constructor. It also plumbs the option through other relevant APIs. PR-URL: https://github.com/nodejs/node/pull/27497 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/27497 Reviewed-By:
-
- May 02, 2019
-
-
Gerhard Stoebich authored
Seems at least some windows versions interpret symlinks not as folders therefore .gitignore needs some extra entries. PR-URL: https://github.com/nodejs/node/pull/27484 Refs: https://github.com/nodejs/node/pull/27149 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Joyee Cheung authored
Now the subclasses only need to override methods to - Get the profile node from the profiler response message object - Return the directory and file path And the V8ProfilerConnection() would handle the rest of profile serialization and message parsing. This makes it easier to add other types of profiles in the future. PR-URL: https://github.com/nodejs/node/pull/27475 Refs: https://github.com/nodejs/node/issues/27421 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Joyee Cheung authored
- Process and store --cpu-prof-dir and --cpu-prof-name during Environment creation - Start profilers in one `profiler::StartProfilers()` PR-URL: https://github.com/nodejs/node/pull/27475 Refs: https://github.com/nodejs/node/issues/27421 Reviewed-By:
-
Joyee Cheung authored
Rename `ENVIRONMENT_STRONG_PERSISTENT_PROPERTIES` to `ENVIRONMENT_STRONG_PERSISTENT_TEMPLATES`, and move `context` out of the list, so that the data can be iterated separately. PR-URL: https://github.com/nodejs/node/pull/27430 Reviewed-By:
-
Luigi Pinca authored
- Run all tests in parallel. - Move `socket.end()` call to client. - Use `common.mustCall()` and `common.mustNotCall()`. Fixes: https://github.com/nodejs/node/issues/27219 Refs: https://github.com/nodejs/node/pull/27300 PR-URL: https://github.com/nodejs/node/pull/27426 Reviewed-By:
-
Gilles De Mey authored
Fixes: https://github.com/nodejs/node/issues/23710 PR-URL: https://github.com/nodejs/node/pull/23818 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
ptaylor authored
Prevents alignment issues when creating a typed array from a buffer. Fixes: https://github.com/nodejs/node/issues/24817 PR-URL: https://github.com/nodejs/node/pull/24838 Reviewed-By:
-
Ruben Bridgewater authored
This fixes flaky `util.inspect` tests by making sure that the inspected WeakMap and WeakSet only contains objects that still have other hard references. Otherwise the garbage collection could collect these objects to early. PR-URL: https://github.com/nodejs/node/pull/27482 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/27479 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/27479 Reviewed-By:
-
- May 01, 2019
-
-
Jeremy Apthorp authored
PR-URL: https://github.com/nodejs/node/pull/27288 Reviewed-By:
-
Ruben Bridgewater authored
This improves the error message from `ERR_OUT_OF_RANGE` by closer inspecting the value and logging numbers above 2 ** 32 by adding commas to the output for integer and bigint. BigInt is now also marked if used. Buffer errors also format the range as 2 ** n instead of showing a huge number. PR-URL: https://github.com/nodejs/node/pull/27228 Reviewed-By:
-
Michael Dawson authored
refs: https://github.com/nodejs/TSC/issues/694 PR-URL: https://github.com/nodejs/node/pull/27411 Refs: https://github.com/nodejs/TSC/issues/694 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
imhype authored
* add mustcall() on createServerListener * add mustcall() on listenPortListener * add mustCall() on onConnectListener * add mustCallAtLeast() on onDataListener PR-URL: https://github.com/nodejs/node/pull/27471 Reviewed-By:
Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
Ruwan Geeganage authored
PR-URL: https://github.com/nodejs/node/pull/27468 Reviewed-By:
-
Anna Henningsen authored
Skipping the test is not needed now that the underlying cause has been addressed in V8. This reverts commit b66f01d9. Refs: https://github.com/nodejs/node/pull/27423 PR-URL: https://github.com/nodejs/node/pull/27469 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/27470 Reviewed-By:
-
Luigi Pinca authored
Refs: https://github.com/nodejs/node/pull/27300 PR-URL: https://github.com/nodejs/node/pull/27425 Reviewed-By:
-
cclauss authored
PR-URL: https://github.com/nodejs/node/pull/27381 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Shuhei Kagawa authored
PR-URL: https://github.com/nodejs/node/pull/27442 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Shelley Vohr authored
Notable changes: * deps: add s390 asm rules for OpenSSL-1.1.1 (Shigeki Ohtsu) [#19794](https://github.com/nodejs/node/pull/19794) * src: add .code and SSL specific error properties (Sam Roberts) [#25093](https://github.com/nodejs/node/pull/25093) * tls: * add --tls-min-v1.2 CLI switch (Sam Roberts) [#26951](https://github.com/nodejs/node/pull/26951) * supported shared openssl 1.1.0 (Sam Roberts) [#26951](https://github.com/nodejs/node/pull/26951) * revert default max toTLSv1.2 (Sam Roberts) [#26951](https://github.com/nodejs/node/pull/26951) * revert change to invalid protocol error type (Sam Roberts) [#26951](https://github.com/nodejs/node/pull/26951) * support TLSv1.3 (Sam Roberts) [#26209](https://github.com/nodejs/node/pull/26209) * add code for ERR\_TLS\_INVALID\_PROTOCOL\_METHOD (Sam Roberts) [#24729](https://github.com/nodejs/node/pull/24729) PR-URL: https://github.com/nodejs/node/pull/27314
-
- Apr 30, 2019
-
-
Sam Roberts authored
ERR_INVALID_PROTOCOL docs should describe the API it relates to. See: https://github.com/nodejs/node/pull/27390/files#r278246361 PR-URL: https://github.com/nodejs/node/pull/27393 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/27400 Reviewed-By:
-
Ruben Bridgewater authored
This adds stage-3 language features to acorn so that the REPL is able to parse these features properly. Otherwise these would cause SyntaxErrors. PR-URL: https://github.com/nodejs/node/pull/27400 Fixes: https://github.com/nodejs/node/issues/27391 Fixes: https://github.com/nodejs/node/issues/25835 Reviewed-By:
-
Ruben Bridgewater authored
This adds stage-3 language features to acorn so that it's possible to parse these features when using top level await in the REPL. PR-URL: https://github.com/nodejs/node/pull/27400 Refs: https://github.com/nodejs/node/issues/27391 Refs: https://github.com/nodejs/node/issues/25835 Reviewed-By:
-
Ruben Bridgewater authored
This adds new language features to acorn. Otherwise BigInt and other input would not be parsed correct and would not result in nice error messages when using simple assert. PR-URL: https://github.com/nodejs/node/pull/27400 Refs: https://github.com/nodejs/node/issues/27391 Refs: https://github.com/nodejs/node/issues/25835 Reviewed-By:
-
Ruben Bridgewater authored
This adds bigint, class-fields, numeric-separators, static-class features, private class methods and fields as dependency. That way it's possible to use these in combination with acorn to parse these language features. This also removes a couple of files that were not necessary for Node.js to reduce the code base. PR-URL: https://github.com/nodejs/node/pull/27400 Refs: https://github.com/nodejs/node/issues/27391 Refs: https://github.com/nodejs/node/issues/25835 Reviewed-By:
-
Fedor Indutny authored
There is no way to disable SNI extension when sending a request to HTTPS server. Setting `options.servername` to a falsy value would make Node.js core override it with either hostname or ip address. This change introduces a way to disable SNI completely if this is required for user's application. Setting `options.servername` to `` in `https.request` would disable overrides and thus disable the extension. PR-URL: https://github.com/nodejs/node/pull/27316 Reviewed-By:
-
Rich Trott authored
Remove unreachable code from lib/buffer.js. PR-URL: https://github.com/nodejs/node/pull/27445 Reviewed-By:
-
