- Jul 15, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33727 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Sagar Jadhav authored
Convert callback functions that are anonymous to arrow functions for better readability. PR-URL: https://github.com/nodejs/node/pull/33711 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Daniel Bevenius authored
This commit replaces the IsEmpty call to use ToLocal instead which allows for the following ToLocalChecked function call to be avoided. PR-URL: https://github.com/nodejs/node/pull/33695 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33683 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Nick Schonning authored
Related to https://github.com/nodejs/remark-preset-lint-node/pull/94 PR-URL: https://github.com/nodejs/node/pull/33692 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: https://github.com/nodejs/remark-preset-lint-node/pull/96 Signed-off-by:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
- Jul 09, 2020
-
-
Sebastien Ahkrin authored
PR-URL: https://github.com/nodejs/node/pull/31205 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
cjihrig authored
"occasionally" was spelled incorrectly. PR-URL: https://github.com/nodejs/node/pull/33677 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
cjihrig authored
The other issue templates are wrapped at 80 characters. This commit updates the flaky test template to be consistent. PR-URL: https://github.com/nodejs/node/pull/33677 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/33472 Reviewed-By:
-
Xu Meng authored
Since the PR https://github.com/libuv/libuv/pull/2753 has been landed, we need to revert the code change in PR https://github.com/nodejs/node/pull/32338. PR-URL: https://github.com/nodejs/node/pull/33629 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/33602 Reviewed-By:
-
Anna Henningsen authored
This is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL: https://github.com/nodejs/node/pull/33640 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Lucas Holmquist authored
PR-URL: https://github.com/nodejs/node/pull/33590 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
sapics authored
Replace redirected urls with the final ones. Replace http urls with https ones. PR-URL: https://github.com/nodejs/node/pull/33614 Reviewed-By:
-
Daniel Bevenius authored
This commit suggest using MaybeLocal.ToLocal and passing in the Local<String> node_opts. It also introduces a variable, arg_v8, of type Local<String> to enable the use of ToLocal. The motivation for doing this is that the following MaybeLocal::ToLocalChecked and MaybeLocal::FromMaybe calls can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33599 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/33597 Reviewed-By:
-
Tom Nagle authored
PR-URL: https://github.com/nodejs/node/pull/33547 Reviewed-By:
-
cjihrig authored
This commit adds stdin, stderr, and stdout options to WASI, which allow the stdio streams to be configured. PR-URL: https://github.com/nodejs/node/pull/33544 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Derek Lewis authored
Prior to this commit, Markdown fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the one shown in the CommonMark spec. Refs: https://github.com/commonmark/commonmark-spec/blob/1103710025f340702edcb070be41f9982b6544d5/spec.txt#L131 PR-URL: https://github.com/nodejs/node/pull/33542 Reviewed-By:
-
Maciej Kacper Jagiełło authored
PR-URL: https://github.com/nodejs/node/pull/33541 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, JavaScript fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the one with the highest frequency in the doc/api/ dir. Stats: > 'js' => 1091, > 'javascript' => 2, PR-URL: https://github.com/nodejs/node/pull/33531 Reviewed-By:
-
Ruben Bridgewater authored
The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: https://github.com/nodejs/node/issues/32907 Signed-off-by:
-
Ruben Bridgewater authored
The current name of most of the global console functions is "bound consoleCall". This is changed to the actual functions name e.g., "log" or "error". Signed-off-by:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Ruben Bridgewater authored
This makes sure internal console properties are not visible during default inspection. They are still visible when inspecting the console with `showHidden` set to `true`. These properties are confusing while working with the REPL and easily show up. Signed-off-by:
-
Ruben Bridgewater authored
This check is always truthy. Thus, it's removed. Signed-off-by:
-
Ruben Bridgewater authored
This makes sure errors are fully inspected during exit. That is important to provide as many debugging information to the user as possible. Signed-off-by:
-
Pranshu Srivastava authored
added writableHighWaterMark, writableLength, and writableFinished properties with test. Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33506 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33146 Reviewed-By:
-
Zeke Sikelianos authored
These are changed to either ```text or ```console. PR-URL: https://github.com/nodejs/node/pull/33028 Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/33592 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Richard Lau authored
s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python Refs: https://github.com/nodejs/node/pull/32609 PR-URL: https://github.com/nodejs/node/pull/33589 Reviewed-By:
-
Pranshu Srivastava authored
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33188 Reviewed-By:
Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: https://github.com/nodejs/node/pull/33570 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
Daniel Bevenius authored
This commit removes the unused using declarations reported by lint-cpp. PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Ash Cripps authored
Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: https://github.com/nodejs/node/pull/33500 Reviewed-By:
-
Richard Lau authored
`check-imports.py` was missing some unused `using` statements as it was not matching on word boundaries (e.g. `MaybeLocal` was considered a use of `Local`). Fix that and add some unit tests (which required the script to be renamed to drop the `-` so it could be imported into the test script). PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By:
-
Daniel Bevenius authored
This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fn. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33554 Reviewed-By:
-
Robert Nagy authored
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: https://github.com/nodejs/node/issues/4066 PR-URL: https://github.com/nodejs/node/pull/33539 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33555 Reviewed-By:
-
