- Feb 08, 2018
-
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/18270 Fixes: https://github.com/nodejs/node/issues/8307 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Vse Mozhet Byt authored
developer.mozilla.org/en/... -> developer.mozilla.org/en-US/... PR-URL: https://github.com/nodejs/node/pull/18631 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18630 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
cjihrig authored
This test was added over six years ago, and the behavior seems to have changed since then. When the test was originally written, common.mustCall() did not exist. The only assertion in this test was not actually executing. Instead of an 'error' event being emitted as expected, an 'abort' event was emitted. PR-URL: https://github.com/nodejs/node/pull/18508 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anatoli Papirovski authored
Instead of separately calling into C++ from JS to retrieve the Timer.now() value, pass it in as an argument. PR-URL: https://github.com/nodejs/node/pull/18562 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/18562 Reviewed-By:
-
- Feb 07, 2018
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/18578 Refs: https://github.com/v8/v8/compare/6.4.388.41...6.4.388.42 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Anatoli Papirovski authored
The readline module wants a truthy time while using Timer.now() doesn't necessarily guarantee that early on in the process' life. It also doesn't actually resolve the timing issues experienced in an earlier issue. Instead, this PR fixes the related tests and moves them back to parallel. Refs: https://github.com/nodejs/node/issues/14674 PR-URL: https://github.com/nodejs/node/pull/18563 Reviewed-By:
-
Bhavani Shankar authored
PR-URL: https://github.com/nodejs/node/pull/18498 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Tim O. Peters authored
Assuming less knowledge on the part of the reader, making it easier to get start using Node.js. PR-URL: https://github.com/nodejs/node/pull/17977 Fixes: https://github.com/nodejs/node/issues/17970 , Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/18596 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary. PR-URL: https://github.com/nodejs/node/pull/18589 Fixes: https://github.com/nodejs/node/issues/18587 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Joyee Cheung authored
google.com added another TXT record which broke this test. This removes the check on the content of the TXT record since that depends on an external state subject to change. PR-URL: https://github.com/nodejs/node/pull/18547 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Shobhit Chittora authored
PR-URL: https://github.com/nodejs/node/pull/16648 Refs: https://github.com/nodejs/node/issues/16636 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Joyee Cheung authored
This commit moves error creation helpers scattered around under lib/ into lib/internal/errors.js in the hope of being clearer about the differences of errors that we throw into the user land. - Move util._errnoException and util._exceptionWithHostPort into internal/errors.js and simplify their logic so it's clearer what the properties these helpers create. - Move the errnoException helper in dns.js to internal/errors.js into internal/errors.js and rename it to dnsException. Simplify it's logic so it no longer calls errnoException and skips the unnecessary argument checks. PR-URL: https://github.com/nodejs/node/pull/18546 Reviewed-By:
-
Joyee Cheung authored
We cannot make uvException a proper class due to compatibility reasons for now, so there is no need to call new since it only returns a newly-created Error. PR-URL: https://github.com/nodejs/node/pull/18546 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18546 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18601 Refs: https://github.com/nodejs/node/pull/18407 Refs: https://github.com/nodejs/node/pull/18444 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18516 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Anna Henningsen authored
The complicated `awaitDrain` machinery can be made a bit slimmer, and more correct, by just resetting the value each time `stream.emit('data')` is called. By resetting the value before emitting the data chunk, and seeing whether any pipe destinations return `.write() === false`, we always end up in a consistent state and don’t need to worry about odd situations (like `dest.write(chunk)` emitting more data). PR-URL: https://github.com/nodejs/node/pull/18516 Fixes: https://github.com/nodejs/node/issues/18484 Fixes: https://github.com/nodejs/node/issues/18512 Refs: https://github.com/nodejs/node/pull/18515 Reviewed-By: -
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/18605 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18602 Reviewed-By:
-
- Feb 06, 2018
-
-
Vse Mozhet Byt authored
This seems to be slipped in https://github.com/nodejs/node/pull/18297 PR-URL: https://github.com/nodejs/node/pull/18599 Refs: https://github.com/nodejs/node/pull/18309 Reviewed-By:
-
Peter Marton authored
This adds the Http1IncomingMessage and Http1ServerReponse options to http2.createServer(). PR-URL: https://github.com/nodejs/node/pull/15752 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Peter Marton authored
This adds the optional options argument to `http.createServer()`. It contains two options: the `IncomingMessage` and `ServerReponse` option. PR-URL: https://github.com/nodejs/node/pull/15752 Reviewed-By:
-
Anna Henningsen authored
Overlooked when landing the respective PRs. PR-URL: https://github.com/nodejs/node/pull/18564 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Gus Caplan authored
Mention the new modules team. PR-URL: https://github.com/nodejs/node/pull/18545 Reviewed-By:
-
陈刚 authored
PR-URL: https://github.com/nodejs/node/pull/18526 Reviewed-By:
-
BufoViridis authored
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: https://github.com/nodejs/node/pull/18458 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
Luca Maraschi authored
Added a test to ensure input validation for FD and mode for fs.fchmod. Removed check for values lower than 0 for `mode` as it's already checked by `validateUint32`. PR-URL: https://github.com/nodejs/node/pull/18217 Reviewed-By:
-
Ruben Bridgewater authored
The generatedMessage was wrong in case simple assert was used and a message was auto generated. This fixed the TODO. PR-URL: https://github.com/nodejs/node/pull/18322 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Ruben Bridgewater authored
Prevent reading a Node.js module. That could theoretically lead to false errors being thrown otherwise. PR-URL: https://github.com/nodejs/node/pull/18322 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18590 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Camilo Gonzalez authored
Fixes: https://github.com/nodejs/node/issues/18466 PR-URL: https://github.com/nodejs/node/pull/18472 Reviewed-By:
-
Mathias Buus authored
PR-URL: https://github.com/nodejs/node/pull/18515 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/18475 Reviewed-By:
-
Ben Noordhuis authored
Replace `v8::Isolate::GetCpuProfiler()` with `v8::CpuProfiler::New()` and cache the instance; creating and disposing an instance every loop tick is too expensive. PR-URL: https://github.com/nodejs/node/pull/18534 Fixes: https://github.com/nodejs/node/issues/18039 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/18523 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/18558 Reviewed-By:
-
Daniel Bevenius authored
This commit add SetUpTestCase and TearDownTestCase functions that will be called once per test case. Currently we only have SetUp/TearDown which are called for each test. This commit moves the initialization and configuration of Node and V8 to be done on a per test case basis, but gives each test a new Isolate. PR-URL: https://github.com/nodejs/node/pull/18558 Reviewed-By:
-
