- Sep 14, 2015
-
-
Jeremiah Senkpiel authored
`process.stdout` always blocks as of 20176a98 `WritableState.buffer` is `getBuffer()` as of 91586661 PR-URL: https://github.com/nodejs/node/pull/2549 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Tristian Flanagan authored
Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2846
-
- Sep 13, 2015
-
-
Rich Trott authored
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: https://github.com/nodejs/node/pull/2802 Fixes: https://github.com/nodejs/node/issues/2468 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rich Trott authored
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: https://github.com/nodejs/node/pull/2808 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Sep 12, 2015
-
-
Sakthipriyan Vairamani authored
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: https://github.com/nodejs/node/pull/2718 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Oleksandr Chekhovskyi authored
Ensure that samples are evenly distributed, which is required for v8::CpuProfiler users to work correctly (v8-profiler / node-inspector). PR-URL: https://github.com/nodejs/node/pull/2324 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Saúl Ibarra Corretgé authored
PR-URL: https://github.com/nodejs/node/pull/2817 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Sep 11, 2015
-
-
Minwoo Jung authored
"Calls" is used frequently throughout the docs except for this line. Use "Calls" over "Executes" to make it consistent. PR-URL: https://github.com/nodejs/node/pull/2800 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: https://github.com/nodejs/node/issues/2468 PR-URL: https://github.com/nodejs/node/pull/2785 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Anne-Gaelle Colom authored
behaviour -> behavior PR-URL: https://github.com/nodejs/node/pull/2784 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Fedor Indutny authored
Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: https://github.com/nodejs/node/issues/2463 PR-URL: https://github.com/nodejs/node/pull/2801 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: https://github.com/nodejs/node/pull/2792 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com>
-
- Sep 10, 2015
-
-
Anne-Gaelle Colom authored
PR-URL: https://github.com/nodejs/node/pull/2765 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/2779 PR-URL: https://github.com/nodejs/node/pull/2781 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Sam Roberts authored
Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/1978
-
- Sep 09, 2015
-
-
Rich Trott authored
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for https://github.com/nodejs/node/issues/2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: https://github.com/nodejs/node/pull/2724 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Fixes: https://github.com/nodejs/node/issues/2468
-
Rod Vagg authored
This list of changes is relative to the last io.js v3.x branch release, v3.3.0. Please see the list of notable changes in the v3.x, v2.x and v1.x releases for a more complete list of changes from 0.12.x. Note, that some changes in the v3.x series as well as major breaking changes in this release constitute changes required for full convergence of the Node.js and io.js projects. * child_process: ChildProcess.prototype.send() and process.send() operate asynchronously across all platforms so an optional callback parameter has been introduced that will be invoked once the message has been sent, i.e. .send(message[, sendHandle][, callback]) (Ben Noordhuis) #2620. * node: Rename "io.js" code to "Node.js" (cjihrig) #2367. * node-gyp: This release bundles an updated version of node-gyp that works with all versions of Node.js and io.js including nightly and release candidate builds. From io.js v3 and Node.js v4 onward, it will only download a headers tarball when building addons rather than the entire source. (Rod Vagg) #2700. * npm: Upgrade to version 2.14.2 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) #2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) #2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 * util: The util.is*() functions have been deprecated, beginning with deprecation warnings in the documentation for this release, users are encouraged to seek more robust alternatives in the npm registry, (Sakthipriyan Vairamani) #2447. * v8: Upgrade to version 4.5.103.30 from 4.4.63.30 (Ali Ijaz Sheikh) #2632. - Implement new TypedArray prototype methods: copyWithin(), every(), fill(), filter(), find(), findIndex(), forEach(), indexOf(), join(), lastIndexOf(), map(), reduce(), reduceRight(), reverse(), slice(), some(), sort(). See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. - Implement new TypedArray.from() and TypedArray.of() functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. - Implement arrow functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions for further information. - Full ChangeLog available at https://github.com/v8/v8-git-mirror/blob/4.5.103/ChangeLog PR-URL: https://github.com/nodejs/node/pull/2742 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: https://github.com/nodejs/node/pull/2728 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
- Sep 08, 2015
-
-
Karl Skomski authored
It was previously ignored by features.gypi and therefore enabled by default for release builds. See https://code.google.com/p/chromium/issues/detail?id=318206 PR-URL: https://github.com/nodejs/node/pull/2731 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2737 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Fedor Indutny authored
This a backport of the following commits from the v8's upstream: * 1a8c38c50513f9af07ada479629a653e1cf36ff3 * 206f12abee3f1e7eda8fc6521d48f3c319460ee1 * 9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 Original commit message: heap: make array buffer maps disjoint Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. The results of benchmarks are: $ ./node-slow bench && ./node-fast bench 4997.4 ns/op 4685.7 ns/op NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. PR-URL: https://github.com/nodejs/node/pull/2732 Reviewed-By:Rod Vagg <rod@vagg.org> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Fedor Indutny authored
Allow listening on reused dgram ports in cluster workers. Fix: https://github.com/joyent/node/issues/9261 PR-URL: https://github.com/nodejs/node/pull/2548 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2717 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
* support process.release * support all io.js versions * support node v4+ including new download locations * enable delay-load hook by default by default * download header-only tarballs instead of full source See https://github.com/nodejs/node-gyp/pull/711 for full details PR-URL: https://github.com/nodejs/node/pull/2700 Reviewed-By:
Forrest L Norvell <forrest@npmjs.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2699 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Evan Lucas authored
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: https://github.com/nodejs/node/issues/2721 PR-URL: https://github.com/nodejs/node/pull/2727 Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com>
-
Ben Noordhuis authored
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: https://github.com/nodejs/node/pull/2723 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Sep 07, 2015
-
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2701 Reviewed-By:
Joao Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Sep 06, 2015
-
-
Ben Noordhuis authored
cpplint uses the top-level .git directory to determine what the root is for #include guards. If it doesn't find a .git directory, it walks up all the way to the system root and subsequently complains that guards must be written as HOME_USER_SRC_NODE_SRC_FILENAME_H_. This commit replaces the .git-based path munging with a fixed root path relative to the location of the cpplint script, making it possible to successfully run `make test` from an extracted tarball. Fixes: https://github.com/nodejs/node/issues/2693 PR-URL: https://github.com/nodejs/node/pull/2710 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Kat Marchán authored
This patch should make the tests pass on the downstreamed npm. PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
saper authored
Note: When this was cherry-picked for v8 v4.4 (landed in nodejs#2636), test-heap.cc:1989 chunk did not exist. It now exists in v8 v4.5.103.30. This PR completes the cherry pick of the whole commit from v8. PR-URL: https://github.com/nodejs/node/pull/2692 Reviewed-By:
ofrobots - Ali Ijaz Sheikh <ofrobots@google.com> Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103}
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2687 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2674 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Roman Reiss authored
- Added NODE_REPL_HISTORY to the environment variables in the --help and made all descriptions start with lower case for consistency. - Added NODE_REPL_HISTORY and NODE_ICU_DATA to the man page. PR-URL: https://github.com/nodejs/node/pull/2690 Reviewed-By:
fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
evanlucas - Evan Lucas <evanlucas@me.com>
-
Karl Skomski authored
The version used before returned -1 on truncation which does not conform to the standard. PR-URL: https://github.com/nodejs/node/pull/2404 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Karl Skomski authored
Long exception lines resulted in a stack buffer overflow or assertion because it was assumed snprintf not counts discarded chars or the assertion itself was incorrect: `(off) >= sizeof(arrow)` PR-URL: https://github.com/nodejs/node/pull/2404 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Sakthipriyan Vairamani authored
Recursive file watching is supported by libuv since 1.7.0. Refer https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This patch notes that in the docs and enables testing this feature. It also adds proper TAP plugin parsable message for other platforms. PR-URL: https://github.com/nodejs/node/pull/2649 Fixes: https://github.com/nodejs/node/issues/375 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io>
-
Michaël Zasso authored
Fixes a regression that appeared with the new Buffer implementation in v3. Without this change, calling the SlowBuffer constructor with something else than a number would abort on the C++ side. This makes sure that the length argument is coerced to number or is 0. Fixes: https://github.com/nodejs/node/issues/2634 PR-URL: https://github.com/nodejs/node/pull/2635 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-