- Feb 03, 2021
-
-
Rich Trott authored
test/parallel/test-heapsnapshot-near-heap-limit.js is timing out in CI on low-memory and slow-CPU devices. Split off the worker test to its own test file to allow the test to finish in time. Refs: https://github.com/nodejs/node/issues/36961 PR-URL: https://github.com/nodejs/node/pull/37189 Reviewed-By:
Ash Cripps <acripps@redhat.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
- Feb 02, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37185 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
James Addison authored
There was an unexpected and hard-to-spot issue here: the /sys/kernel/mm/transparent_hugepage/enabled file contains three entries, and the std::ifstream reader was reading two values on each loop iteration, resulting in incorrect behaviour. Fixes: https://github.com/nodejs/node/issues/37064 PR-URL: https://github.com/nodejs/node/pull/37065 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/37181 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Michaël Zasso authored
The flag is going to be removed upstream in V8 9.0. Refs: https://github.com/v8/v8/commit/0a480c30d553c1b8dddb0dddcbdec5fb6f3101ff PR-URL: https://github.com/nodejs/node/pull/37151 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/37177 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Joyee Cheung authored
So that the debugger does not have to hard-code the number of internal fields of BaseObjects. PR-URL: https://github.com/nodejs/node/pull/37111 Refs: https://github.com/nodejs/node/pull/36943 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Feb 01, 2021
-
-
Akash Negi authored
This corresponds to the format at https://developercertificate.org/. PR-URL: https://github.com/nodejs/node/pull/37138 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37125 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Tobias Nießen authored
The previous description incorrectly explained the behavior of options.add and options.rem for primes that are not safe. PR-URL: https://github.com/nodejs/node/pull/37085 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Anna Henningsen authored
If we have an estimate of the file size available from the previous stat call, use that for the size of the first chunk to be read. This increases performance by reading more data (and, most likely, all data) at once without incurring memory overhead in most situations. PR-URL: https://github.com/nodejs/node/pull/37127 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/37127 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37126 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36346 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Rich Trott authored
Change `<a id"...` to `<a id="...` (missing equal sign) and move entry to correct location in alphabetical order. PR-URL: https://github.com/nodejs/node/pull/37144 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
The REPL documentation does not list prohibited inputs, but it does explain the conditions under which ERR_INVALID_REPL_INPUT is used. Update the error doc to indicate that. PR-URL: https://github.com/nodejs/node/pull/37143 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37124 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
The sample code demonstrating ERR_INVALID_REPL_INPUT is confusing, I think. This simplifies and clarifies it a bit, I hope. PR-URL: https://github.com/nodejs/node/pull/37142 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Turner Jabbour authored
PR-URL: https://github.com/nodejs/node/pull/35046 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
- Jan 31, 2021
-
-
Rich Trott authored
Remove the table of contents summary for pages with no table of contents. Currently, this affects at least index.html. PR-URL: https://github.com/nodejs/node/pull/37043 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
cjihrig authored
https://github.com/nodejs/node/pull/36918 landed with references to DEP0150, which is already used for a different deprecation. This commit updates the code to use DEP0151. PR-URL: https://github.com/nodejs/node/pull/37147 Refs: https://github.com/nodejs/node/pull/36918 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/37147 Refs: https://github.com/nodejs/node/pull/36918 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 30, 2021
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/37067 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/37067 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
This reverts commit 06c5b531. PR-URL: https://github.com/nodejs/node/pull/37067 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
This reverts commit b0d5bfe7. PR-URL: https://github.com/nodejs/node/pull/37067 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
This reverts commit 548790ab. PR-URL: https://github.com/nodejs/node/pull/37067 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/36918 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Dave Cardwell authored
https://github.com/nodejs/node/pull/36952 added the `base64url` encoding option. Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future. PR-URL: https://github.com/nodejs/node/pull/37102 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/37117 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/37083 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Jan 29, 2021
-
-
cjihrig authored
The pattern of resolving/rejecting a Promise from outside of its executor happens numerous times throughout the codebase (more than what is updated here in fact). This commit abstracts that logic into an internal utility function. PR-URL: https://github.com/nodejs/node/pull/37095 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
This commit avoids exposing a new underscored property on readline Interface instances. PR-URL: https://github.com/nodejs/node/pull/37094 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
question() checks for objects passed as the recently added options argument. This commit improves that logic to also check for null. PR-URL: https://github.com/nodejs/node/pull/37089 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/37092 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Richard Lau authored
Remove links to End-of-Life versions of the BUILDING.md document. Add a link to the version for Node.js 14.x. PR-URL: https://github.com/nodejs/node/pull/37082 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
ExE Boss authored
PR-URL: https://github.com/nodejs/node/pull/37005 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
ExE Boss authored
Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37005 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Jan 28, 2021
-
-
ZiJian Liu authored
Co-authored-by:
ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37028 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/36972 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-