- Oct 22, 2015
-
-
Michael Dawson authored
Add Benchmarking and Post-Mortem workgroups as they were missing. Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <ben@strongloop.com> PR-URL: https://github.com/nodejs/node/pull/3450
-
- Oct 21, 2015
-
-
Rod Vagg authored
For Node.js v5.0.0, due to upgrade to V8 4.6 which has an incompatible ABI PR-URL: https://github.com/nodejs/node/pull/3400 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/3235 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
Require the test setup to obtain an EMFILE error and not ENFILE as ENFILE means there is a race condition with other processes that may close files before `spawn()` is called by the test. Fixes: https://github.com/nodejs/node/issues/2666 PR-URL: https://github.com/nodejs/node/pull/3430 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Ido Ben-Yair authored
Remove the Watchdog class' dependency on Environment. No functional changes, only code cleanup. PR-URL: https://github.com/nodejs/node/pull/3274 Reviewed-By:
-
Glen Keane authored
PR-URL: https://github.com/nodejs/node/pull/3388 Reviewed-By:
-
Yuval Brik authored
Upon creating a TLSSocket object, set the default isServer option to false Updated tls docs and added test-tls-socket-default-options PR-URL: https://github.com/nodejs/node/pull/2614 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
Reviewed-By:
-
Rich Trott authored
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: https://github.com/nodejs/node/issues/2672 Reviewed-By:
Rod Vagg <r@va.gg> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
fansworld-claudio authored
Adds the "shell" option from child_process.exec to child_process.execSync on the api docs. Fixes: #3387 Reviewed-By:
-
Junliang Yan authored
Test should be skipped if ipv6 is unavailable on the running system. Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
-
Fedor Indutny authored
Instead of creating new timer - reuse the timer from the freelist. This won't make the freelist timer active for the duration of `uv_close()`, and will let the event-loop exit properly. Fix: #1264 PR-URL: https://github.com/nodejs/node/pull/3407 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
-
Trevor Norris authored
When v8 implemented proper one-byte string support Node's internal "binary" encoding implementation was removed in favor of it. The result was that "binary" encoding effectively became "latin-1" encoding. Because of this and because one-byte strings are natively supported by v8 the buffer encoding is not deprecated and will not be removed. Ref: 83261e78 "deps: update v8 to 3.17.13" PR-URL: https://github.com/nodejs/node/pull/3441 Reviewed-By:
-
Rich Trott authored
If the symlink portion of the test was being skipped due to a combination of OS support and user privileges, then an assertion would always fail. This fixes that problem, improves assertion error reporting and splits the test to make it clear that it is a test for links and symlinks. Fixes: https://github.com/nodejs/node/issues/3311 PR-URL: https://github.com/nodejs/node/pull/3418 Reviewed-By:
-
- Oct 20, 2015
-
-
P.S.V.R authored
PR-URL: https://github.com/nodejs/node/pull/3379 Reviewed-By:
-
Jeremiah Senkpiel authored
The race conditions were fixed in 286ef1da PR-URL: https://github.com/nodejs/node/pull/3437 Reviewed By: Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Yuval Brik authored
Check for unexpected end-of-file error when decompressing. If the output buffer still has space after decompressing and deflate returned Z_OK or Z_BUF_ERROR - that means unexpected end-of-file. Added test-zlib-truncated.js for the case of truncated input. Fixed the zlib dictionary test to not end the inflate stream on a truncated output (no crc) of deflate Fixes: https://github.com/nodejs/node/issues/2043 PR-URL: https://github.com/nodejs/node/pull/2595 Reviewed-By:
-
Wyatt Preul authored
Update deprecation test to use another method. Ref: https://github.com/nodejs/node/pull/2529 PR-URL: https://github.com/nodejs/node/pull/3432 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Rich Trott authored
Assert is now locked. Userland alternatives should be used. Assert is for testing Node.js itself. Document potentially surprising use of enumerable properties only in deep equality assertions. Ref: https://github.com/nodejs/node/pull/3124 Ref: https://github.com/nodejs/node/issues/3122 PR-URL: https://github.com/nodejs/node/pull/3330 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
calebboyd authored
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits. PR-URL: https://github.com/nodejs/node/pull/3334 Reviewed-By:
-
- Oct 19, 2015
-
-
Jeremiah Senkpiel authored
Previously the wrong end of the history was limited on load. PR-URL: https://github.com/nodejs/node/pull/2356 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed By: Evan Lucas <evanlucas@me.com>
-
Jeremiah Senkpiel authored
- Now cleans up the history file unless told otherwise. - Now also logs which test case failed. - Waits for flush after repl close if necessary. Fixes: https://github.com/nodejs/node/issues/2319 PR-URL: https://github.com/nodejs/node/pull/2356 Reviewed-By:
-
- Oct 17, 2015
-
-
Коренберг Марк authored
Helps in implementation of #6204, where some options passed to `createSecurePair()` are ignored before this patch. These options are very helpful if someone wants to pass `options.servername` or `options.SNICallback` to securepair. PR-URL: https://github.com/nodejs/node/pull/2441 Reviewed-By:
-
Johannes Wüller authored
These changes affect the following functions and their synchronous counterparts: * fs.readFile() * fs.writeFile() * fs.appendFile() If the first parameter is a uint32, it is treated as a file descriptor. In all other cases, the original implementation is used to ensure backwards compatibility. File descriptor ownership is never taken from the user. The documentation was adjusted to reflect these API changes. A note was added to make the user aware of file descriptor ownership and the conditions under which a file descriptor can be used by each of these functions. Tests were extended to test for file descriptor parameters under the conditions noted in the relevant documentation. PR-URL: https://github.com/nodejs/node/pull/3163 Reviewed-By:
-
Rich Trott authored
The existing test never ran because typeof Symbol === 'function' and not 'symbol'. We have Symbols now so remove the check and just run the test. PR-URL: https://github.com/nodejs/node/pull/3327 Reviewed-By:
-
Michaël Zasso authored
Name it timerName instead of label. It is clearer that way and matches the description in the doc. It is also how it's named in MDN. PR-URL: https://github.com/nodejs/node/pull/3166 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/3166 Reviewed-By:
-
Michaël Zasso authored
This makes the output of console.timeEnd in line with major browsers. PR-URL: https://github.com/nodejs/node/pull/3166 Reviewed-By:
-
Jonas Dohse authored
f2a45caf contained a test for a regression that had been introduced by the original change that 77a10ed0 ported. While 77a10ed0 did not contain that regression, the test that f2a45caf contained should still be in the code base to prevent any regression from happening in the future. Original message for the commit that contained the test: domains: fix stack clearing after error handled caeb6773 introduced a regression where the domains stack would not be cleared after an error had been handled by the top-level domain. This change clears the domains stack regardless of the position of the active domain in the stack. PR: #9364 PR-URL: https://github.com/joyent/node/pull/9364 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #3356 PR-URL: https://github.com/nodejs/node/pull/3356 Reviewed-By:
-
- Oct 16, 2015
-
-
Rod Vagg authored
-
Rich Trott authored
The assert.fail function signature has the message as the third argument but, understandably, it is often assumed that it is the first argument (or at least the first argument if no other arguments are passed). This corrects the assert.fail() invocations in the Node.js tests. Before: assert.fail('message'); // result: AssertionError: 'message' undefined undefined After: assert.fail(null, null, 'message'); // result: AssertionError: message PR-URL: https://github.com/nodejs/node/pull/3378 Reviewed-By: -
Shigeki Ohtsu authored
To make it easy to figure out where the warning comes from. Also fix style and variable name that was made in #1739. PR-URL: https://github.com/nodejs/node/pull/1831 Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
Shigeki Ohtsu authored
Add a new option to specifiy a minimum size of an ephemeral DH parameter to accept a tls connection. Default is 1024 bit. PR-URL: https://github.com/nodejs/node/pull/1831 Reviewed-By:
-
Shigeki Ohtsu authored
Returns an object representing a type, name and size of an ephemeral key exchange in a client connection. Currently only DHE and ECHE are supported. This api only works on on a client connection. When it is called on a server connection, null is returned. When its key exchange is not ephemeral, an empty object is returned. PR-URL: https://github.com/nodejs/node/pull/1831 Reviewed-By:
-
- Oct 15, 2015
-
-
Roman Reiss authored
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: https://github.com/nodejs/node/pull/3372 Reviewed-By:
-
Phillip Johnsen authored
PR-URL: https://github.com/nodejs/node/pull/3360 Reviewed-By:
-
Calvin Metcalf authored
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By:
Chris Dickinson <chris@neversaw.us> Reviewed-By:
-
Ali Ijaz Sheikh authored
Move up to the latest patch level from the V8 4.6 branch: https://github.com/v8/v8/compare/4.6.85.23...4.6.85.25 PR-URL: https://github.com/nodejs/node/pull/3351 Reviewed-By:
-
Fedor Indutny authored
Original commit message: [objects] do not visit ArrayBuffer's backing store ArrayBuffer's backing store is a pointer to external heap, and can't be treated as a heap object. Doing so will result in crashes, when the backing store is unaligned. See: https://github.com/nodejs/node/issues/2791 BUG=chromium:530531 R=mlippautz@chromium.org LOG=N Review URL: https://codereview.chromium.org/1327403002 Cr-Commit-Position: refs/heads/master@{#30771} Ref: https://github.com/nodejs/node/issues/2791 Ref: https://github.com/nodejs/node/pull/2912 PR-URL: https://github.com/nodejs/node/pull/3351 Reviewed-By: -
Fedor Indutny authored
This a backport of the following commits from the v8's upstream: * 1a8c38c50513f9af07ada479629a653e1cf36ff3 * 206f12abee3f1e7eda8fc6521d48f3c319460ee1 * 9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 Original commit message: heap: make array buffer maps disjoint Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. The results of benchmarks are: $ ./node-slow bench && ./node-fast bench 4997.4 ns/op 4685.7 ns/op NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. Ref: https://github.com/nodejs/node/pull/2732 PR-URL: https://github.com/nodejs/node/pull/3351 Reviewed-By:
-
