- Aug 18, 2020
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/34725 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
Make the code linter-conformant and remove usage of deprecated APIs. PR-URL: https://github.com/nodejs/node/pull/34725 Reviewed-By:
-
Jim Schlight authored
PR-URL: https://github.com/nodejs/node/pull/34641 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/34432 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/34665 Reviewed-By:
Ricky Zhou <0x19951125@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Antoine du HAMEL authored
The HTML <hr> element represents a thematic break between paragraph-level elements: for example, a change of scene in a story, or a shift of topic within a section. The HTML Content Division element (<div>) is the generic container for flow content and does not inherently represent anything. The <hr> tag semantically fits better the meaning of the line between the lists. Refs: https://html.spec.whatwg.org/multipage/grouping-content.html#the-hr-element PR-URL: https://github.com/nodejs/node/pull/34660 Reviewed-By:
-
Anna Henningsen authored
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in https://github.com/nodejs/node/pull/34625. PR-URL: https://github.com/nodejs/node/pull/34726 Reviewed-By:
-
Nikolay Krashnikov authored
PR-URL: https://github.com/nodejs/node/pull/34596 Reviewed-By:
-
Rich Trott authored
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: https://github.com/nodejs/node/pull/34631 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34630 Reviewed-By:
-
Renato Mariscal authored
Two places emits `close` events: `resOnFinish` calls `emitCloseNT`, which happens when the result is completed: https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L695 It gets attached once the socket is assigned: https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L226 And detached if the response is completed: https://github.com/nodejs/node/blob/master/lib/_http_server.js#L709 https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L232 Which means, it can only be reached in this case, for premature socket termination. PR-URL: https://github.com/nodejs/node/pull/34472 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Rich Trott authored
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: https://github.com/nodejs/node/issues/32863 PR-URL: https://github.com/nodejs/node/pull/34684 Fixes: https://github.com/nodejs/node/issues/32863 Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com>
-
Rich Trott authored
Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: https://github.com/nodejs/node/pull/34686 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/33424 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/issues/34606 PR-URL: https://github.com/nodejs/node/pull/34673 Reviewed-By:
-
Anna Henningsen authored
Original commit message: [api] Fix empty Maybe crash in GetRealNamedPropertyAttributes `Object::GetRealNamedPropertyAttributes()` can crash if an empty `Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because it was not checking for that. Fix that. Refs: https://github.com/nodejs/node/issues/34606 Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69258} Refs: https://github.com/v8/v8/commit/e06ace6b5cdb64b6abfe8e1229f2159b7a38b4e7 PR-URL: https://github.com/nodejs/node/pull/34673 Fixes: https://github.com/nodejs/node/issues/34606 Reviewed-By:
-
Gabriele Greco authored
To debug native modules node should be a debuggable process, that will require the **com.apple.security.get-task-allow** entitlement to be added to the codesign procedure. PR-URL: https://github.com/nodejs/node/pull/34378 Fixes: https://github.com/nodejs/node/issues/34340 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Mary Marchini authored
Add a configure flag to build V8 with `-DOBJECT_PRINT`, which will expose auxiliar functions to inspect heap objects using native debuggers. Fixes: https://github.com/nodejs/node/issues/32402 Signed-off-by:
Mary Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32834 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Priyank Singh authored
Fixes: https://github.com/nodejs/node/issues/34382 PR-URL: https://github.com/nodejs/node/pull/34383 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Mary Marchini authored
Harden policy around objections to avoid misunderstanding and to encourage collaboration between pull request authors and objectors. Fixes: https://github.com/nodejs/node/issues/34564 PR-URL: https://github.com/nodejs/node/pull/34639 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/34605 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34672 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Rich Trott authored
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: https://github.com/nodejs/node/pull/34569 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Bartosz Sosnowski authored
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: https://github.com/nodejs/node/issues/33140 Backport-PR-URL: https://github.com/nodejs/node/pull/34461 PR-URL: https://github.com/nodejs/node/pull/33609 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Denys Otrishko authored
This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by:
Anatoli Papirovski <apapirovski@mac.com> Refs: https://github.com/nodejs/node/pull/21152 Backport-PR-URL: https://github.com/nodejs/node/pull/34482 PR-URL: https://github.com/nodejs/node/pull/34017 Backport-PR-URL: https://github.com/nodejs/node/pull/34482 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by:
-
- Aug 12, 2020
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34704
-
- Aug 11, 2020
-
-
Shelley Vohr authored
Notable changes: async_hooks: * (SEMVER-MINOR) add AsyncResource.bind utility (James M Snell) https://github.com/nodejs/node/pull/34574 doc: * add Ricky Zhou to collaborators (rickyes) https://github.com/nodejs/node/pull/34676 * add release key for Ruy Adorno (Ruy Adorno) https://github.com/nodejs/node/pull/34628 * add DerekNonGeneric to collaborators (Derek Lewis) https://github.com/nodejs/node/pull/34602 module: * (SEMVER-MINOR) unflag Top-Level Await (Myles Borins) https://github.com/nodejs/node/pull/34558 n-api: * (SEMVER-MINOR) support type-tagging objects (Gabriel Schulhof) https://github.com/nodejs/node/pull/28237 n-api,src: * (SEMVER-MINOR) provide asynchronous cleanup hooks (Anna Henningsen) https://github.com/nodejs/node/pull/34572 PR-URL: https://github.com/nodejs/node/pull/34704
-
Mary Marchini authored
A recent feature was added to github-bot to ping codeowners defined on the CODEOWNERS file even if the team doesn't have write permission to the repository. That means we can enable codeowners everywhere in the repository. Ref: https://github.com/nodejs/github-bot/pull/265 Fix: https://github.com/nodejs/node/issues/33984 PR-URL: https://github.com/nodejs/node/pull/34670 Fixes: https://github.com/nodejs/node/issues/33984 Refs: https://github.com/nodejs/github-bot/pull/265 Reviewed-By:
-
Rich Trott authored
Our docs describe static methods as Class Methods which seems idiosyncratic for JavaScript. Align with MDN which calls them static methods. Refs: https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/API_references/What_does_an_API_reference_need JSON format for our docs will still use the key name `classMethods` for this. I would like to change it to `staticMethods` but I don't know if that will break things for consumers. So, leaving it alone. It's a machine-consumable label more than a human-readable so I can live with that. PR-URL: https://github.com/nodejs/node/pull/34659 Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34622 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34654 Reviewed-By:
-
Anna Henningsen authored
Makefile assumes that it can pass a list of files to the import checker, whereas the import checker expects a single argument that is interpreted as a blob. Fix that mismatch by accepting multiple arguments in the import checker. Refs: https://github.com/nodejs/node/pull/34565 PR-URL: https://github.com/nodejs/node/pull/34582 Reviewed-By:
-
Anna Henningsen authored
Fix linter failures when running the linter on all source files. PR-URL: https://github.com/nodejs/node/pull/34582 Refs: https://github.com/nodejs/node/pull/34565 Reviewed-By:
-
Rich Trott authored
We use _Class Method_ rather than _static_ in documentation headers in buffer.md and crypto.md. We use _static_ in one place in async_hooks.md. Change to _Class Method_ for consistency. PR-URL: https://github.com/nodejs/node/pull/34626 Reviewed-By:
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 PR-URL: https://github.com/nodejs/node/pull/34662 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
Gerhard Stoebich authored
Manually destroy the AsyncResource created by AsyncLocalStore.run() to avoid unneeded GC tracking in case a destroy hooks is present. PR-URL: https://github.com/nodejs/node/pull/34653 Reviewed-By:
-
Anna Henningsen authored
Sometimes addons need to perform cleanup actions, for example closing libuv handles or waiting for requests to finish, that cannot be performed synchronously. Add C++ API and N-API functions that allow providing such asynchronous cleanup hooks. Fixes: https://github.com/nodejs/node/issues/34567 PR-URL: https://github.com/nodejs/node/pull/34572 Reviewed-By:
-
Gerhard Stoebich authored
Inspired by the callstack at https://github.com/nodejs/node/issues/34556#issuecomment-666743528 If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: https://github.com/nodejs/node/issues/34556#issuecomment-666743528 PR-URL: https://github.com/nodejs/node/pull/34616 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Gerhard Stoebich authored
The length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: https://github.com/nodejs/node/pull/30932#discussion_r379679982 Both properties should be configurable. Refs: https://github.com/nodejs/node/pull/34574 PR-URL: https://github.com/nodejs/node/pull/34620 Reviewed-By:
-
James M Snell authored
Creates an internal AsyncResource and binds a function to it, ensuring that the function is invoked within execution context in which bind was called. PR-URL: https://github.com/nodejs/node/pull/34574 Reviewed-By:
-
