- Jun 14, 2021
-
-
Ikko Ashimine authored
Psuedo -> Pseudo PR-URL: https://github.com/nodejs/node/pull/39021 Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
- Migrated to ESM because some dependencies now require it. - Did not update `highlight.js` to v11 because it has many breaking changes. - Used non-deprecated `highlight.js` API. Refs: https://github.com/highlightjs/highlight.js/issues/2277 Fixes: https://github.com/nodejs/node/issues/38938 Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38966 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Darshan Sen authored
This makes the code more readable. Signed-off-by:
-
Voltrex authored
Both of the `clearTimeout()` and `clearInterval()` functions in the `timers` lib accepts the ID of the `Timeout` object returned by the functions in a number or string type, e.g. ```js const t = setTimeout(console.log, 5000, 'test'); clearTimeout(t[Symbol.toPrimitive]()); ``` PR-URL: https://github.com/nodejs/node/pull/39013 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/issues/39005 PR-URL: https://github.com/nodejs/node/pull/39006 Reviewed-By:
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/38994 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Voltrex authored
The `net` lib module's `lookupAndConnect()` function is missing a validator. PR-URL: https://github.com/nodejs/node/pull/38984 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Anna Henningsen authored
Singly-linked lists are extended at their tail, not their head. This fixes using more than 2 linked addons at a time. PR-URL: https://github.com/nodejs/node/pull/39012 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Mao Wtm authored
Co-authored-by:
-
- Jun 13, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38979 Fixes: https://github.com/nodejs/node/issues/32103 Fixes: https://github.com/nodejs/node/issues/38739 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Rich Trott authored
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45b so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: https://github.com/nodejs/node/pull/39001 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/node/pull/38507 Refs: https://github.com/nodejs/node/pull/38874 PR-URL: https://github.com/nodejs/node/pull/39016 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38838 Reviewed-By:
-
- Jun 12, 2021
-
-
Richard Lau authored
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and then uses `touch` to update a timestamp file. Unconditionally calling `touch` was losing the exit code from `tools/doc/addon-verify.js` so any errors produced by that script were not failing the build. PR-URL: https://github.com/nodejs/node/pull/38983 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
Gabriel Schulhof authored
When `napi_create_string_*` receives a null pointer as its second argument, it must null-check it before passing it into V8, otherwise a crash will occur. Signed-off-by:
Gabriel Schulhof <gabrielschulhof@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38923 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
- Jun 11, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38870 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36861 Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
bl-ue authored
PR-URL: https://github.com/nodejs/node/pull/38894 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
bl-ue authored
PR-URL: https://github.com/nodejs/node/pull/39000 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/38898 Reviewed-By:
-
Rongjian Zhang authored
PR-URL: https://github.com/nodejs/node/pull/38582 Reviewed-By:
-
RA80533 authored
The example snippet of filehandle.close() uses the `await` keyword based on convention. This change updates the example snippet of filehandle.truncate() to similarly use the keyword for the purposes of consistency. PR-URL: https://github.com/nodejs/node/pull/38939 Reviewed-By:
-
Derevianchenko Maksym authored
Replaced params in writeFileSync function in proper way. PR-URL: https://github.com/nodejs/node/pull/38941 Reviewed-By:
-
ycjcl868 authored
Co-authored-by:
Qingyu Deng <i@ayase-lab.com> PR-URL: https://github.com/nodejs/node/pull/38881 Reviewed-By:
-
Darshan Sen authored
Signed-off-by:
-
Simone Busoli authored
- replace _*may or may not* be called_ with _will be called_ because the callback is always called - remove _To reliably detect write errors, add a listener for the `'error'` event_ because the `error` event will NOT be emitted if a write occurs after the stream has been closed PR-URL: https://github.com/nodejs/node/pull/38959 Fixes: https://github.com/nodejs/node/issues/38704 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Mary Marchini authored
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: https://github.com/nodejs/node/pull/38998 Reviewed-By:
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/38955 Reviewed-By:
-
- Jun 10, 2021
-
-
Michaël Zasso authored
V8 9.1 changed the way it aborts on uncaught exceptions on Windows. It now uses the code 0x80000003 (exception breakpoint) instead of 0xC0000005 (access violation). Refs: https://github.com/v8/v8/commit/26d85acee2c052aa128b77e2e5fde1d4c9306910 PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/commit/9a31804bbe6597bfb54b47958fd3839f2da51875 PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/commit/40e499cd28b2f21652f4b05a35a146c498e86a39 PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [runtime] Fix Promise.all context promise hooks We have to take the slow path in Promise.all if context promise hooks are set. The fast-path doesn't create intermediate promises by default. Bug: chromium:1204132, v8:11025 Change-Id: Ide92de00a4f6df05e0ddbc8814f6673bd667f426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2866771 Reviewed-by:Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74326} Refs: https://github.com/v8/v8/commit/fa4cb172cde256a1e71d675d81fbb4b85d1e5f66 PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [promises] Fix slow path when context promise hooks are present Bug: chromium:1201936 Change-Id: I1ee545e33587ddf4a5c7e1cbd64b53d36c75a146 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850936 Reviewed-by:Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74267} Refs: https://github.com/v8/v8/commit/4c074516397b89c5cfe9de9857018484f73445ef PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [promises] Change context promise hooks to Callable The previously added perf-context Promise-hooks take a v8::Function as arguments. However, the builtin code was only accepting JSFunctions which causes cast errors. Drive-by-fix: Directly pass nativeContext in more places. Bug: chromium:1201465 Change-Id: Ic8bed11253a1f18a84e71eb9ea809b1ec1c3f428 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850162 Reviewed-by: -
Michaël Zasso authored
Original commit message: [runtime] Fix promise hooks promiseCapability can be undefined. Bug: v8:11025 Bug: chromium:1201113 Change-Id: I9da8764820cee0db1f0c38ed2fff0e3afeb9a80e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844649 Reviewed-by: -
Michaël Zasso authored
Original commit message: Reland "[api] JSFunction PromiseHook for v8::Context" This is a reland of d5457f5fb7ea05ca05a697599ffa50d35c1ae3c7 after a speculative revert. Additionally it fixes an issue with throwing promise hooks. Original change's description: > [api] JSFunction PromiseHook for v8::Context > > This will enable Node.js to get much better performance from async_hooks > as currently PromiseHook delegates to C++ for the hook function and then > Node.js delegates it right back to JavaScript, introducing several > unnecessary barrier hops in code that gets called very, very frequently > in modern, promise-heavy applications. > > This API mirrors the form of the original C++ function based PromiseHook > API, however it is intentionally separate to allow it to use JSFunctions > triggered within generated code to, as much as possible, avoid entering > runtime functions entirely. > > Because PromiseHook has internal use also, beyond just the Node.js use, > I have opted to leave the existing API intact and keep this separate to > avoid conflicting with any possible behaviour expectations of other API > users. > > The design ideas for this new API stemmed from discussion with some V8 > team members at a previous Node.js Diagnostics Summit hosted by Google > in Munich, and the relevant documentation of the discussion can be found > here: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/edit#heading=h.w1bavzz80l1e > > A summary of the reasons for why this new design is important can be > found here: https://docs.google.com/document/d/1vtgoT4_kjgOr-Bl605HR2T6_SC-C8uWzYaOPDK5pmRo/edit?usp=sharing > > Bug: v8:11025 > Change-Id: I0b403b00c37d3020b5af07b654b860659d3a7697 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759188 > Reviewed-by:Camillo Bruni <cbruni@chromium.org> > Reviewed-by:
Anton Bikineev <bikineev@chromium.org> > Reviewed-by:
Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73858} Bug: v8:11025 Bug: chromium:1197475 Change-Id: I73a71e97d9c3dff89a2b092c3fe4adff81ede8ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2823917 Reviewed-by:
-
Michaël Zasso authored
Original commit message: [weakrefs] Remove --no-harmony-weak-refs flag Bug: v8:8179 Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73871} Refs: https://github.com/v8/v8/commit/d59db06bf5425ddb388fb5a576f4bf39bdcc0f8f PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Michaël Zasso authored
Original commit message: PPC: skip all Simd tests on PPC As of https://crrev.com/c/2629465, Simd tests cannot pass on architectures without Simd support. Tests will need to be re-enabled once Simd support is fully implemented on PPC. Change-Id: I963639f1afa0c0ca7be3ca4b2fc06e874235b903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693056 Reviewed-by:Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72788} Refs: https://github.com/v8/v8/commit/aaacffa1e0039d23d46194b4f2d0ce553e17a4f5 PR-URL: https://github.com/nodejs/node/pull/38273 Reviewed-By:
-
