- May 09, 2021
-
-
Antoine du Hamel authored
Fixes: https://github.com/nodejs/node/issues/38558 PR-URL: https://github.com/nodejs/node/pull/38564 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rongjian Zhang authored
PR-URL: https://github.com/nodejs/node/pull/38563 Refs: https://coverage.nodejs.org/coverage-26e318a321a872bc/lib/dgram.js.html#L202 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
-
ZiJian Liu authored
Refs: https://coverage.nodejs.org/coverage-7abc7e45b2e17730/lib/internal/repl.js.html#L33 PR-URL: https://github.com/nodejs/node/pull/38559 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
XadillaX authored
Refs: https://github.com/nodejs/node/pull/38433#issuecomment-828426932 PR-URL: https://github.com/nodejs/node/pull/38548 Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
-
- May 08, 2021
-
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/38566 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Voltrex authored
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency. PR-URL: https://github.com/nodejs/node/pull/38560 Reviewed-By:
-
Richard Lau authored
The `torque_generated_definitions` target is missing some torque generated files in its sources list when compared to the equivalent target in V8's BUILD.gn. PR-URL: https://github.com/nodejs/node/pull/38576 Fixes: https://github.com/nodejs/node/issues/38571 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rongjian Zhang authored
PR-URL: https://github.com/nodejs/node/pull/38537 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/9.0.257.24...9.0.257.25 PR-URL: https://github.com/nodejs/node/pull/38556 Reviewed-By:
-
ZiJian Liu authored
1. custom inspect test case Refs: https://coverage.nodejs.org/coverage-18e4f405b14b26f9/lib/internal/histogram.js.html#L56 2. tests that RecordableHistogram is impossible to construct manually Refs: https://coverage.nodejs.org/coverage-18e4f405b14b26f9/lib/internal/histogram.js.html#L132 PR-URL: https://github.com/nodejs/node/pull/38555 Reviewed-By:
-
Bryan Field authored
PR-URL: https://github.com/nodejs/node/pull/38541 Reviewed-By:
-
- May 07, 2021
-
-
Antoine du Hamel authored
This avoids loading the entirety of `node:util` and `node:url` and their dependencies while only a subset is actually used by this module. PR-URL: https://github.com/nodejs/node/pull/38550 Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/36394 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Stephen Belanger authored
Original commit message: [runtime] Fix Promise.all context promise hooks We have to take the slow path in Promise.all if context promise hooks are set. The fast-path doesn't create intermediate promises by default. Bug: chromium:1204132, v8:11025 Change-Id: Ide92de00a4f6df05e0ddbc8814f6673bd667f426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2866771 Reviewed-by:Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74326} Refs: https://github.com/v8/v8/commit/fa4cb172cde256a1e71d675d81fbb4b85d1e5f66 PR-URL: https://github.com/nodejs/node/pull/36394 Reviewed-By:
-
Stephen Belanger authored
Original commit message: [promises] Fix slow path when context promise hooks are present Bug: chromium:1201936 Change-Id: I1ee545e33587ddf4a5c7e1cbd64b53d36c75a146 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850936 Reviewed-by:Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74267} Refs: https://github.com/v8/v8/commit/4c074516397b89c5cfe9de9857018484f73445ef PR-URL: https://github.com/nodejs/node/pull/36394 Reviewed-By:
-
Stephen Belanger authored
Original commit message: [promises] Change context promise hooks to Callable The previously added perf-context Promise-hooks take a v8::Function as arguments. However, the builtin code was only accepting JSFunctions which causes cast errors. Drive-by-fix: Directly pass nativeContext in more places. Bug: chromium:1201465 Change-Id: Ic8bed11253a1f18a84e71eb9ea809b1ec1c3f428 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850162 Reviewed-by: -
Stephen Belanger authored
Original commit message: [runtime] Fix promise hooks promiseCapability can be undefined. Bug: v8:11025 Bug: chromium:1201113 Change-Id: I9da8764820cee0db1f0c38ed2fff0e3afeb9a80e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844649 Reviewed-by: -
Stephen Belanger authored
Original commit message: Reland "[api] JSFunction PromiseHook for v8::Context" This is a reland of d5457f5fb7ea05ca05a697599ffa50d35c1ae3c7 after a speculative revert. Additionally it fixes an issue with throwing promise hooks. Original change's description: > [api] JSFunction PromiseHook for v8::Context > > This will enable Node.js to get much better performance from async_hooks > as currently PromiseHook delegates to C++ for the hook function and then > Node.js delegates it right back to JavaScript, introducing several > unnecessary barrier hops in code that gets called very, very frequently > in modern, promise-heavy applications. > > This API mirrors the form of the original C++ function based PromiseHook > API, however it is intentionally separate to allow it to use JSFunctions > triggered within generated code to, as much as possible, avoid entering > runtime functions entirely. > > Because PromiseHook has internal use also, beyond just the Node.js use, > I have opted to leave the existing API intact and keep this separate to > avoid conflicting with any possible behaviour expectations of other API > users. > > The design ideas for this new API stemmed from discussion with some V8 > team members at a previous Node.js Diagnostics Summit hosted by Google > in Munich, and the relevant documentation of the discussion can be found > here: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/edit#heading=h.w1bavzz80l1e > > A summary of the reasons for why this new design is important can be > found here: https://docs.google.com/document/d/1vtgoT4_kjgOr-Bl605HR2T6_SC-C8uWzYaOPDK5pmRo/edit?usp=sharing > > Bug: v8:11025 > Change-Id: I0b403b00c37d3020b5af07b654b860659d3a7697 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759188 > Reviewed-by:
Camillo Bruni <cbruni@chromium.org> > Reviewed-by:
Anton Bikineev <bikineev@chromium.org> > Reviewed-by:
Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73858} Bug: v8:11025 Bug: chromium:1197475 Change-Id: I73a71e97d9c3dff89a2b092c3fe4adff81ede8ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2823917 Reviewed-by:
-
Rongjian Zhang authored
PR-URL: https://github.com/nodejs/node/pull/38517 Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/fs.js.html#L330 Reviewed-By:
-
Rongjian Zhang authored
In the user perspective, it's not an arguemnt type error. Replace it with an `assert` expression. PR-URL: https://github.com/nodejs/node/pull/38519 Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/fs/promises.js.html#L268 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38529 Reviewed-By:
-
Rich Trott authored
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: https://github.com/nodejs/node/pull/38529 Reviewed-By:
-
Rich Trott authored
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: https://github.com/nodejs/node/pull/38529 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/38510 Fixes: https://github.com/nodejs/node/issues/38499 Reviewed-By:
-
Juan José Arboleda authored
This reverts commit 73370b45. The unit test is preserved to make sure it does not break https://github.com/nodejs/node/issues/26463 again. PR-URL: https://github.com/nodejs/node/pull/38510 Fixes: https://github.com/nodejs/node/issues/38499 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/38530 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38523 Reviewed-By:
-
- May 06, 2021
-
-
Daniel Bevenius authored
This commit skips some test when OpenSSL 3.0.0-alpha15 is used as there is an issue that causes them to fail. This is only a temp solution until there is new OpenSSL release. Fixes: https://github.com/nodejs/node/issues/38373 PR-URL: https://github.com/nodejs/node/pull/38451 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/38451 Fixes: https://github.com/nodejs/node/issues/38373 Reviewed-By:
-
Jordan Baczuk authored
Fixes: https://github.com/nodejs/node/issues/38540 PR-URL: https://github.com/nodejs/node/pull/38542 Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
-
- May 05, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38518 Reviewed-By:
-
Rongjian Zhang authored
PR-URL: https://github.com/nodejs/node/pull/38520 Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/querystring.js.html#L179 Reviewed-By:
-
ZiJian Liu authored
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/abort_controller.js.html#L126 PR-URL: https://github.com/nodejs/node/pull/38514 Reviewed-By:
-
ZiJian Liu authored
Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/blob.js.html#L132 PR-URL: https://github.com/nodejs/node/pull/38515 Reviewed-By:
-
Fedor Indutny authored
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: https://github.com/nodejs/node/pull/38506 Reviewed-By:
-
Nitzan Uziely authored
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: https://github.com/nodejs/node/pull/38363 Reviewed-By:
Adrian Estrada <edsadr@gmail.com>
-
Voltrex authored
Added JSDoc typings for the `readline` lib module. PR-URL: https://github.com/nodejs/node/pull/38253 Reviewed-By:
-
Rich Trott authored
The content we're linking to for AHAFS was published in 2011 but has now been archived. This updates the link to the archived version (as the current version results in a "Yikes!" page with an HTTP 400 response code). Unfortunately, the archived version does say "This content is no longer being updated or maintained. The content is provided “as is.” Given the rapid evolution of technology, some content, steps, or illustrations may have changed." So we'll want to update at some point I imagine. But for the moment, archived content with a notice like that is better than a broken link. PR-URL: https://github.com/nodejs/node/pull/38534 Reviewed-By:
Ash Cripps <acripps@redhat.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
-
Rich Trott authored
Both for consistency within the doc and to conform with IBM's usage regarding their on product, refer to the operating system as AIX rather than Aix. PR-URL: https://github.com/nodejs/node/pull/38535 Reviewed-By:
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/38502 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
