- Apr 10, 2019
-
-
Thomas authored
When console.log is called for the first time it initializes TTYWrap object. However, if there is not enough space on the V8 stack, creating function template fails and triggers empty maybe local exception. PR-URL: https://github.com/nodejs/node/pull/26832 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/26591 Reviewed-By:
-
Jon Kunkee authored
This change adds the generated files required for building OpenSSL for Node.js for ARM64 Windows. I did this on a VM running Ubuntu 18.04. The basic workflow is to cd to deps/openssl/config and run `make`, installing any needed packages until all architectures build correctly. Note that OpenSSL 1.1.1 does not support ASM on ARM64 Windows, so this change also supports only no-asm on ARM64 Windows. PR-URL: https://github.com/nodejs/node/pull/26001 Fixes: https://github.com/nodejs/node/issues/25998 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Signed-off-by:
-
Shigeki Ohtsu authored
This adds ARM64 Windows support in the OpenSSL build system. Since OpenSSL's ARM64 Windows support does not have support for ASM-- that is, VC-WIN64-ARM inherits from VC-noCE-common which has no ASM files--`openssl_no_asm.gypi` is always used for building. This essentially forces the 'no-asm' Configure flag. PR-URL: https://github.com/nodejs/node/pull/26001 Fixes: https://github.com/nodejs/node/issues/25998 Reviewed-By:
-
Ruben Bridgewater authored
The list argument may only be of type array, not of any other type as it actually suggests. PR-URL: https://github.com/nodejs/node/pull/27050 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by:
-
Ruben Bridgewater authored
This adds an extra modules caching layer that operates on the parent's `path` property and the current require argument. That together can be used as unique identifier to speed up loading the same module more than once. It is a cache on top of the current modules cache. It has the nice feature that this cache does not only work in the same file but it works for the whole current directory. So if the same file is loaded in any other file from the same directory, it will also hit this cache instead of having to resolve the file again. To keep it backwards compatible with the old modules cache, it detects invalidation of that cache. PR-URL: https://github.com/nodejs/node/pull/26970 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Signed-off-by:
-
Ruben Bridgewater authored
This adds the `path` property to the module object. It contains the current directory as path. That is necessary to add an extra caching layer. It also makes sure the `id` uses a default in case it's not set. Otherwise the `path.dirname(id)` command could fail. PR-URL: https://github.com/nodejs/node/pull/26970 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
-
Ruben Bridgewater authored
Moving `try / catch` into separate functions is not necessary anymore due to V8 optimizations. PR-URL: https://github.com/nodejs/node/pull/26970 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
-
Ruben Bridgewater authored
Add more benchmark options to properly verify the gains. This makes sure the benchmark also tests requiring the same module again instead of only loading each module only once. PR-URL: https://github.com/nodejs/node/pull/26970 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/26970 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
-
Ben Noordhuis authored
Change `memset(&s, 0, sizeof(type))` to `memset(&s, 0, sizeof(s))`. The former is dangerous when the type of `s` changes. PR-URL: https://github.com/nodejs/node/pull/27038 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Signed-off-by:
-
Ali Ijaz Sheikh authored
PR-URL: https://github.com/nodejs/node/pull/27076 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
kohta ito authored
Correctly document the default maxBuffer size for execSync, execFileSync, and spawnSync. It is 200 * 1024, not Infinity. Add tests to verify behaviour is as documented. PR-URL: https://github.com/nodejs/node/pull/22894 Reviewed-By:
-
Richard Lau authored
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: https://github.com/nodejs/node/issues/26860 PR-URL: https://github.com/nodejs/node/pull/27031 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Joyee Cheung authored
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode. PR-URL: https://github.com/nodejs/node/pull/26945 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26885 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26990 Reviewed-By:
-
Anna Henningsen authored
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5a pass when that is the case. Refs: https://github.com/nodejs/node/pull/26823 PR-URL: https://github.com/nodejs/node/pull/27019 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Ruben Bridgewater authored
This makes sure multiple require calls will not fail in case a file was created after the first attempt. PR-URL: https://github.com/nodejs/node/pull/26928 Fixes: https://github.com/nodejs/node/issues/26926 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
Matteo Collina authored
PR-URL: https://github.com/nodejs/node/pull/26989 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
Matteo Collina authored
PR-URL: https://github.com/nodejs/node/pull/26989 Reviewed-By:
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/26999 Reviewed-By:
-
Rich Trott authored
The introductory paragraph in GOVERNANCE.md does not add anything that isn't obvious from the document itself. Remove it. PR-URL: https://github.com/nodejs/node/pull/27036 Reviewed-By:
-
cjihrig authored
The diagnostic report currently contains command line information, and the environment, which contains the PWD environment variable. This combination covers the majority of cases, but it would be useful to have the result of uv_cwd() as an additional data point. This commit adds that information. PR-URL: https://github.com/nodejs/node/pull/27022 Reviewed-By:
-
Joyee Cheung authored
Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments. PR-URL: https://github.com/nodejs/node/pull/26788 Reviewed-By:
-
Minwoo Jung authored
Remove old errors_system_errors, any useful information in it moved into the SystemError class docs. Fixes: https://github.com/nodejs/node/issues/26861 PR-URL: https://github.com/nodejs/node/pull/27037 Reviewed-By:
-
Ruben Bridgewater authored
This just switches the statements in a way that it reduces the overall indentation. The function has a very deep indentation in general and this should improve the readability. PR-URL: https://github.com/nodejs/node/pull/26917 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/26909 Reviewed-By:
-
Ruben Bridgewater authored
Using `util.inspect()` with the `compact` option set to a number could result in output that exceeded the `breakLength` option. This change makes sure that limit is taken into account. PR-URL: https://github.com/nodejs/node/pull/26914 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
"Prints: ..." comments were excepted to avoid confusion. PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
Make notes about `TypeError` conditions in `Buffer.from()` variants more accurate. PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27030 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26888 Reviewed-By:
-
