- Jan 29, 2019
-
-
Sam Roberts authored
Renamed some internal C++ methods and properties for consistency, and commented SSL I/O. - Rename waiting_new_session_ after is_waiting_new_session(), instead of using reverse naming (new_session_wait_), and change "waiting" to "awaiting". - Make TLSWrap::ClearIn() return void, the value is never used. - Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the arguments, remove them from the js wrapper. - Remove call of setTicketKeys(getTicketKeys()), its a no-op. PR-URL: https://github.com/nodejs/node/pull/25713 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Sam Roberts authored
SSL_set_mode() bit-ORs its argument into the current mode, its not necessary for to do it ourself (though it doesn't cause harm). See: - https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_mode.html - https://github.com/nodejs/node/blob/0ce615c4af/deps/openssl/openssl/ssl/ssl_lib.c#L2176-L2177 PR-URL: https://github.com/nodejs/node/pull/25711 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
gengjiawen authored
Signed-off-by:
gengjiawen <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/25701 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
gengjiawen authored
Signed-off-by:
James M Snell <jasnell@gmail.com>
-
Adam Majer authored
On different architectures, it's possible for the compression algorithm to produce slightly different outputs. So, don't assume we will always get the same compressed output on all architectures. Instead, verify that the decompressing pre-compressed string functions correctly. Fixes: https://github.com/nodejs/node/issues/25568 PR-URL: https://github.com/nodejs/node/pull/25697 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Jeremiah Senkpiel authored
Previously this test silently swallowed some errors. Refactored to use `common.mustCall()` & `assert()`s. Also, this adds a couple of extra error-checking cases. PR-URL: https://github.com/nodejs/node/pull/25656 Reviewed-By:
-
Luigi Pinca authored
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it. PR-URL: https://github.com/nodejs/node/pull/25489 Reviewed-By:
-
Jeremy Apthorp authored
PR-URL: https://github.com/nodejs/node/pull/25380 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
-
Sam Roberts authored
This gets better coverage of the codes, and is more explicit. It also works around ordering differences in the errors produced by openssl. The approach was tested with 1.1.0 and 1.1.1, as well as TLSv1.2 vs TLSv1.3. OpenSSL 1.1.0 is relevant when node is built against a shared openssl. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Backport-PR-URL: https://github.com/nodejs/node/pull/25688
-
Shigeki Ohtsu authored
`SSL_CB_HANDSHAKE_START` and `SSL_CB_HANDSHAKE_DONE` are called sending HelloRequest in OpenSSL-1.1.1. We need to check whether this is in a renegotiation state or not. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Sam Roberts authored
Make OpenSSL 1.1.1 error during cipher list setting if it would have errored with OpenSSL 1.1.0. Can be dropped after our OpenSSL fixes this upstream. See: https://github.com/openssl/openssl/pull/7759 PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Sam Roberts authored
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Shigeki Ohtsu authored
Add new requirements of assembler version for AVX-512 support in OpenSSL-1.1.1. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Shigeki Ohtsu authored
AIX has own assembler not GNU as that does not support --noexecstack. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Shigeki Ohtsu authored
OpenSSL-1.1.1 has new support of AVX-512 but AVX-2 asm files still need to be generated for the older assembler support to keep backward compatibilities. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Shigeki Ohtsu authored
This is a floating patch against OpenSSL-1.1.1 to generate asm files with Makefile rules. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Shigeki Ohtsu authored
Because llvm on MacOS does not support AVX-512, asm files need to be limited to AVX-2 support even when they are generated on Linux. fake_gcc.pl returns the fake llvm banner version for MacOS as if the assembler supports upto AVX-2. For Windows, makefiles for nmake were updated in OpenSSL-1.1.1 and they are rewritten into GNU makefile format by hand. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Shigeki Ohtsu authored
Some of defines and cppflags in the build config of OpenSSL-1.1.1 were moved to new attributes. Gyp and gypi file generations are needed to be fixed to include them. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
Sam Roberts authored
This updates all sources in deps/openssl/openssl with openssl-1.1.1a. PR-URL: https://github.com/nodejs/node/pull/25381 Reviewed-By:
-
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3. PR-URL: https://github.com/nodejs/node/pull/25584 Reviewed-By:
-
Rich Trott authored
Remove redundant test/pummel/test-exec.js. Refs: https://github.com/nodejs/node/pull/25686#pullrequestreview-196243499 PR-URL: https://github.com/nodejs/node/pull/25722 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
Replace `s_client` in test-https-ci-reneg-attack with built-in client calling `tls.renegotiate()`. This also fixes the currently-broken test. (It is broken due to a change in behavior in a recently-updated-in-core version of `s_client`.) PR-URL: https://github.com/nodejs/node/pull/25720 Reviewed-By:
-
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: https://github.com/nodejs/node/pull/25582 Reviewed-By:
-
This patch replaces the following 1. Usage of `filter` with `None` to remove falsy items. 2. Usage of `map` to create lists. (Replaced with List comprehensions). 3. Dictionary's `iteritems` which is removed in Python 3. PR-URL: https://github.com/nodejs/node/pull/25580 Reviewed-By:
-
gengjiawen authored
Signed-off-by:
-
Anna Henningsen authored
Add Environment cleanup hooks to remove GC listeners when the `Environment` is torn down. PR-URL: https://github.com/nodejs/node/pull/25647 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Joyee Cheung authored
Remove the `StartInspector` and `InspectorStarted` abstraction out of `v8_platform`, and error out early and directly in the option parser if Node is configured with NODE_USE_V8_PLATFORM and inspector enabled but the user still tries to use inspector options. PR-URL: https://github.com/nodejs/node/pull/25612 Reviewed-By:
-
Anna Henningsen authored
This has been unused since cbc3ef64. Refs: https://github.com/nodejs/node/pull/23053 PR-URL: https://github.com/nodejs/node/pull/25641 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Anna Henningsen authored
`json_trace_writer_` is protected by `stream_mutex_`, but one access to it was not guarded by a lock on said mutex. Refs: https://github.com/nodejs/node/issues/25512 PR-URL: https://github.com/nodejs/node/pull/25624 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Do not stringify numbers and boolean values when writing JSON. PR-URL: https://github.com/nodejs/node/pull/25651 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
- Support non-string entry types - Prefer single-character writes over string writes - Rename the state constants and adjust style to match more common Node.js style PR-URL: https://github.com/nodejs/node/pull/25651 Reviewed-By:
-
Rich Trott authored
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: https://github.com/nodejs/node/pull/25676#issuecomment-457307881 PR-URL: https://github.com/nodejs/node/pull/25700 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Rich Trott authored
Replace Google DNS servers with 127.0.0.1 in test-dns-setserver-when-querying. Refs: https://github.com/nodejs/node/issues/25664 PR-URL: https://github.com/nodejs/node/pull/25694 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Anna Henningsen authored
Not seeing an associated `Environment` is a rare condition anyway, but using `uv_default_loop()` as a fallback is not thread-safe. PR-URL: https://github.com/nodejs/node/pull/25652 Reviewed-By:
-
Clemens Hammacher authored
Node first calls `Isolate::Dispose`, then `NodePlatform::UnregisterIsolate`. This again calls `PerIsolatePlatformData::Shutdown`, which (before this patch) called `FlushForegroundTasksInternal`, which might call `RunForegroundTask` if it finds foreground tasks to be executed. This will fail however, since `Isolate::GetCurrent` was already reset during `Isolate::Dispose`. Hence remove the check to `FlushForegroundTasksInternal` and add checks instead that no more foreground tasks are scheduled. Refs: https://github.com/v8/node/pull/86 PR-URL: https://github.com/nodejs/node/pull/25653 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Eric Whitebloom authored
PR-URL: https://github.com/nodejs/node/pull/25692 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Rich Trott authored
There is a description of how to use s_client for testing of renegotiation limits in the `tls` module documentation. The information is somewhat out of scope, but it also may be somewhat problematic due to changes/peculiarities (bugs?) in recent s_client. Remove the text. Refs: https://github.com/nodejs/node/pull/25381#issuecomment-457067137 PR-URL: https://github.com/nodejs/node/pull/25678 Reviewed-By:
-
Richard Lau authored
Refs: https://github.com/nodejs/node/commit/641de82404d5fa381053e0f5abd522c7f5881e5a PR-URL: https://github.com/nodejs/node/pull/25709 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Denys Otrishko authored
Previously only simple escape sequences were handled (i.e. \n, \t, r etc.). This commit adds escaping of other control symbols in the range of 0x00 to 0x20. Also, this replaces multiple find+replace calls with a single pass replacer. PR-URL: https://github.com/nodejs/node/pull/25626 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/25695 Fixes: https://github.com/nodejs/node/issues/23291 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
