- Sep 10, 2018
-
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/22776 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
- Sep 09, 2018
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/22638 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Avoids having a separate, second source of truth on this matter. PR-URL: https://github.com/nodejs/node/pull/22638 Reviewed-By:
-
William Skellenger authored
PR-URL: https://github.com/nodejs/node/pull/22661 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Daniel Bevenius authored
This commit removes trace_sync_io_ and instead uses the options value directly. PR-URL: https://github.com/nodejs/node/pull/22726 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Hariss096 authored
Removing string literal passed as argument to assert.strictEqual() in order to print the expected value instead of the string. (First issue assigned through Email by Rich Trott) PR-URL: https://github.com/nodejs/node/pull/22718 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit removes the static variable abort_on_uncaught_exception and adds it to the environment options. PR-URL: https://github.com/nodejs/node/pull/22724 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22765 Refs: https://github.com/nodejs/node/pull/22715 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Saud Khanzada authored
replaces assert.throws() with common.expectsError() to check error code and error type in parallel/test-buffer-alloc.js PR-URL: https://github.com/nodejs/node/pull/22689 Reviewed-By:
-
Sam Ruby authored
handle exports. as an alternative to module.exports PR-URL: https://github.com/nodejs/node/pull/22706 Reviewed-By:
-
- Sep 08, 2018
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22755 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22749 Refs: https://github.com/nodejs/node/pull/21697 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/22715 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This fixes the officially accepted message types for `assert.throws()`, `assert.rejects()`, `assert.doesNotThrow()` and `assert.doesNotReject()`. It also renames the `block` argument in those functions to `fn` and `promiseFn` for further clarity. PR-URL: https://github.com/nodejs/node/pull/22692 Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
cjihrig authored
This commit renames V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT to V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER_OR_DEBUG_INFO__OBJECT following an upstream V8 change. PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
cjihrig authored
The V8 6.9 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_class_SharedFunctionInfo__function_identifier__Object Use: v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object - v8dbg_class_SharedFunctionInfo__end_position__int Use: v8dbg_class_UncompiledData__end_position__int32_t - v8dbg_class_SharedFunctionInfo__start_position_and_type__int Use: v8dbg_class_UncompiledData__start_position__int32_t - v8dbg_sharedfunctioninfo_start_position_mask and - v8dbg_sharedfunctioninfo_start_position_shift Removed. Use: v8dbg_class_UncompiledData__start_position__int32_t - v8dbg_scopeinfo_idx_nstacklocals has been removed Refs: https://github.com/v8/v8/commit/39e2d97bc4d6b35be40294f06873f03b0368ce5c Refs: https://github.com/v8/v8/commit/467eb1497e998dd73a4006cf0655fd0ca289b6f4 Refs: https://github.com/v8/v8/commit/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Michaël Zasso authored
v8.getHeapSpaceStatistics() now includes new_large_object_space in its results. Update test-v8-stats.js to account for this. Refs: https://github.com/v8/v8/commit/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Matheus Marchini authored
This commit updates the following postmortem metadata constant: - v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t - V8 commit: https://github.com/v8/v8/commit/53d4dfc3771dda011ba95d0f825fabb83219ff51 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Alexey Kozyatinskiy authored
V8 improved break locations for the node --inspect-brk -e case. PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Clemens Hammacher authored
V8 removed the lldbinit file. Refs: https://crrev.com/c/1127892 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Michaël Zasso authored
V8 now requires ICU's regular expressions. PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Daniel Bevenius authored
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: https://github.com/nodejs/node-v8/issues/69 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Andreas Haas authored
PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Peter Marshall authored
[cpu-profiler] Add flag to always generate accurate line info. https://chromium.googlesource.com/v8/v8/+/ 56baf56790de439b3f69e887e94beb3b301ed77c [cpu-profiler] Turn on detailed line info for optimized code https://chromium.googlesource.com/v8/v8/+/ 84894ce6d2af7feb9e1f5574409355120887326c [cpu-profiler] Separate the flags for generating extra line information https://chromium.googlesource.com/v8/v8/+/ 30ff6719db441cc7ef220d449970cc169067e256 PR-URL: https://github.com/nodejs/node/pull/22688 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [debug] Fully implement Debug::ArchiveDebug and Debug::RestoreDebug. I have a project that embeds V8 and uses a single `Isolate` from multiple threads. The program runs just fine, but sometimes the inspector doesn't stop on the correct line after stepping over a statement that switches threads behind the scenes, even though the original thread is restored by the time the next statement is executed. After some digging, I discovered that the `Debug::ArchiveDebug` and `Debug::RestoreDebug` methods, which should be responsible for saving/restoring this `ThreadLocal` information when switching threads, currently don't do anything. This commit implements those methods using MemCopy, in the style of other Archive/Restore methods in the V8 codebase. Related: https://groups.google.com/forum/#!topic/v8-users/_Qf2rwljRk8 Note: I believe my employer, Meteor Development Group, has previously signed the CLA using the group email address google-contrib@meteor.com. R=yangguo@chromium.org,jgruber@chromium.org CC=info@bnoordhuis.nl Bug: v8:7230 Change-Id: Id517c873eb81cd53f7216c7efd441b956cf7f943 Reviewed-on: https://chromium-review.googlesource.com/833260 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54902} Refs: https://github.com/v8/v8/commit/a8f6869177685cfb9c199c454a86f4698c260515 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [tracing] allow dynamic control of tracing If the trace_buffer_ was null, we were returning a pointer to a static flag back that permanently disabled that particular trace point. This implied an assumption that tracing will be statically enabled at process startup, and once it is disabled, it will never be enabled again. On Node.js side we want to dynamically enable/disable tracing as per programmer intent. Change-Id: Ic7a7839b8450ab5c356d85e8e0826f42824907f4 Reviewed-on: https://chromium-review.googlesource.com/1161518 Reviewed-by: -
Michaël Zasso authored
Original commit message: [cpu-profiler] Use instruction start as the key for the CodeMap Previously we used the start address of the AbstractCode object. This doesn't make sense for off-heap builtins, where the code isn't contained in the object itself. It also hides other potential problems - sometimes the sample.pc is inside the AbstractCode object header - this is never valid. There were a few changes necessary to make this happen: - Change the interface of CodeMoveEvent. Now 'to' and 'from' are both AbstractCode objects, which is nice because many users were taking 'to' and adding the header offset to it to try and find the instruction start address. This isn't valid for off-heap builtins. - Fix a bug in CodeMap::MoveCode where we didn't update the CodeEntry object to reflect the new instruction_start. - Rename the 'start' field in all of the CodeEventRecord sub-classes to make it clear that this is the address of the first instruction. - Fix the confusion in RecordTickSample between 'tos' and 'pc' which caused pc_offset to be calculated incorrectly. Bug: v8:7983 Change-Id: I3e9dddf74e4b2e96a5f031d216ef7008d6f184d1 Reviewed-on: https://chromium-review.googlesource.com/1148457 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54749} Refs: https://github.com/v8/v8/commit/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Camillo Bruni authored
Original commit message: [api][runtime] Support all-in ctors of {Named,Indexed}PropertyHandlerConfiguration - Explicitly allows construction of {Named,Indexed}PropertyHandlerConfiguration with all the members filled. Bug: v8:7612 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I426ea33846b5dbf2b3482c722c963a6e4b0abded Reviewed-on: https://chromium-review.googlesource.com/1163882 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55142} PR-URL: https://github.com/nodejs/node/pull/22390 Fixes: https://github.com/nodejs/node/issues/17480 Fixes: https://github.com/nodejs/node/issues/17481 Refs: https://github.com/v8/v8/commit/e1a76995ef311eb3ca66e12ef1941ed596034d59 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: -
Matheus Marchini authored
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see https://github.com/nodejs/llnode/issues/211). R=bmeurer@google.com, yangguo@google.com Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: -
Michaël Zasso authored
Original commit message: Reland "[builtins] Add %IsTraceCategoryEnabled and %Trace builtins" This is a reland of 8d4572a22b5d2fa0547195bcc40baa18b7565386 Original change's description: > [builtins] Add %IsTraceCategoryEnabled and %Trace builtins > > Adds the builtin Trace and IsTraceCategoryEnabled functions > exposed via extra bindings. These are intended to use by > embedders to allow basic trace event support from JavaScript. > > ```js > isTraceCategoryEnabled('v8.some-category') > > trace('e'.charCodeAt(0), 'v8.some-category', > 'Foo', 0, { abc: 'xyz'}) > ``` > > Bug: v8:7851 > Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250 > Reviewed-on: https://chromium-review.googlesource.com/1103294 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by:Fadi Meawad <fmeawad@chromium.org> > Reviewed-by:
Camillo Bruni <cbruni@chromium.org> > Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54121} TBR=cbruni@chromium.org Bug: v8:7851 Change-Id: Id063754b2834b3b6a2b2654e76e8637bcd6aa5f8 Reviewed-on: https://chromium-review.googlesource.com/1137071 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Michaël Zasso authored
Synchronize source files list with upstream's BUILD.gn. PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.9. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By:
-
Ruben Bridgewater authored
This significantly improves the inspection performance for all array types. From now on only the visible elements cause work instead of having to process all array keys no matter how many entries are visible. This also moves some code out of the main function to reduce the overall function complexity. PR-URL: https://github.com/nodejs/node/pull/22503 Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This significantly reduces the benchmark runtime. It removes to many variations that do not provide any benefit and reduces the iterations. PR-URL: https://github.com/nodejs/node/pull/22503 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/22503 Reviewed-By:
-
- Sep 07, 2018
-
-
Chakravarthy S M authored
Fix typo PR-URL: https://github.com/nodejs/node/pull/22744 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/22450 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
