- Jun 19, 2020
-
-
Stephen Belanger authored
With the async_hooks callback trampoline, domains no longer need any native code. With this, domains can exist in pure JavaScript. PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure colors that are unknown won't cause an error. This is especially important in case a library wants to use colors defined by Node.js core, if available and fall back to the default otherwise. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33797 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Anna Henningsen authored
- Don’t use 12 as a magic number for the buffer size - Mark the object as weak (which is conceptually the right thing to do, even if there is little practical impact) - Keep a reference to the `ArrayBuffer` in question for memory tracking PR-URL: https://github.com/nodejs/node/pull/33851 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Use a common function to handle alignment computations in multiple places. PR-URL: https://github.com/nodejs/node/pull/33884 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Previously, our documentation headers were a mixture of title case, sentence case, and things that were neither. For technical documentation, the _de facto_ standard seems to be sentence case. (See refs below.) So let's standardize on that. This commit follows a commit implementing this standard. This commit adds it to the style guide. Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/33889 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33889 Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings Refs: https://docs.microsoft.com/en-us/style-guide/capitalization Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32758 Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/22413 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/33926 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
This commit removes the unused <array> and <limits> includes, and adds <memory> (for std::unique_ptr), and <utility> (for std::move). PR-URL: https://github.com/nodejs/node/pull/33921 Reviewed-By:
-
Stephen Belanger authored
Original commit message: [promisehook] Add before/after hooks to thenable tasks This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624 Reviewed-by:Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Gus Caplan <me@gus.host> Cr-Commit-Position: refs/heads/master@{#68207} Refs: https://github.com/v8/v8/commit/eec10a2fd8fa4d0e7f5e32dedbd239d938a5dd87 PR-URL: https://github.com/nodejs/node/pull/33778 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Pranshu Srivastava authored
Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/33767 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/33765 Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/33775 Fixes: https://github.com/nodejs/node/issues/33773 Reviewed-By:
-
James M Snell authored
Original PR: https://github.com/nodejs/quic/pull/388 Previously, QuicPacket was allocating an std::vector<uint8_t> of NGTCP2_MAX_PKT_SIZE bytes, then the packet would be serialized into the buffer, and the std::vector would be resized based on the number of bytes serialized. I suspect the memory fragmentation that you're seeing is because of those resize operations not freeing memory in chunks that are aligned with the allocation. This changes QuicPacket to use a stack allocation that is always NGTCP2_MAX_PKT_SIZE bytes and the size of the serialized packet is just recorded without any resizing. When the memory is freed now, it should be freed in large enough chunks to cover subsequent allocations. Signed-off-by:
-
Robert Nagy authored
this.unidirectional depends on #id which is never set in the constructor, hence this condition will never run and can be removed. PR-URL: https://github.com/nodejs/node/pull/33914 Reviewed-By:
-
James M Snell authored
Using the new experimental AbortController... Signed-off-by:
-
- Jun 18, 2020
-
-
Rich Trott authored
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: https://github.com/nodejs/node/pull/33852 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
Use `bash` instead of `shell` for code language flag in doc/guides/maintaining-ngtcp2-nghttp3.md to conform with our other docs and upcoming lint requirements. PR-URL: https://github.com/nodejs/node/pull/33852 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/33863 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/33919 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Daniel Bevenius authored
This commit uses Maybe::Check() instead of Maybe::FromJust() as the return value is not used. PR-URL: https://github.com/nodejs/node/pull/33909 Reviewed-By:
-
Anna Henningsen authored
Take ownership of the token value, since the memory for it is allocated anyway and the buffer size is just 16, i.e. copyable very cheaply. This makes valgrind stop complaining about a use-after-free error when running `sequential/test-quic-preferred-address-ipv6`. PR-URL: https://github.com/nodejs/node/pull/33917 Reviewed-By:
-
Shelley Vohr authored
Notable changes: deps: * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](https://github.com/nodejs/node/pull/33484) * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](https://github.com/nodejs/node/pull/33445) * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](https://github.com/nodejs/node/pull/33446) * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](https://github.com/nodejs/node/pull/33239) PR-URL: https://github.com/nodejs/node/pull/33811
-
Mathias Buus authored
PR-URL: https://github.com/nodejs/node/pull/33804 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
- Jun 17, 2020
-
-
Pranshu Srivastava authored
Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33161 Reviewed-By:
-
Rich Trott authored
The stream doc has the only instance in our docs where two events are combined into a single entry. Split them into separate adjacent entries. PR-URL: https://github.com/nodejs/node/pull/33881 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/33913 Reviewed-By:
-
Dan Fabulich authored
This PR defines two new modes for the --unhandled-rejections flag. The first mode is called "throw". The "throw" mode first emits unhandledRejection. If this hook is not set, the "throw" mode will raise the unhandled rejection as an uncaught exception. The second mode is called "warn-with-error-code". The "warn-with-error-code" mode first emits unhandledRejection. If this hook is not set, the "warn-with-error-code" mode will trigger a warning and set the process's exit code to 1. The PR doesn't change the default behavior for unhandled rejections. That will come in a separate PR. Refs: https://github.com/nodejs/node/pull/33021 PR-URL: https://github.com/nodejs/node/pull/33475 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/33717 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
James M Snell authored
Co-authored-by:
Lucas Pardue <lucaspardue.24.7@gmail.com> Co-authored-by:
Ouyang Yadong <oyydoibh@gmail.com> Co-authored-by:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By:
-
Todd Short authored
Acquired from: https://github.com/akamai/openssl/tree/OpenSSL_1_1_1f-quic Squashed: * https://github.com/akamai/openssl/commit/2ef7c58b2cb432abd4e371322667228d7ce2637b * https://github.com/akamai/openssl/commit/3f8eda3128f52f4d14399a1a912d1fdfacd86a86 * https://github.com/akamai/openssl/commit/b37f665884be2e17e8ff4ad919138626fb13f6c9 * https://github.com/akamai/openssl/commit/6b235895a16da3c0dd36a24cf8dfbe249c6cda3c * https://github.com/akamai/openssl/commit/3a793e06a5031311ce7ce094455be87fa92b8240 PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By:
-
- Jun 16, 2020
-
-
James M Snell authored
Extracted from the QUIC PR. This adds a utility used to deterministically test UDP traffic. It is currently only used by the experimental QUIC implementation. Separated out on request to make review easier. PR-URL: https://github.com/nodejs/node/pull/33380 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Anna Henningsen authored
We added a hack for this a while ago for Electron, so let’s remove that hack and make this an official API. Refs: https://github.com/nodejs/node/pull/28724 Refs: https://github.com/nodejs/node/issues/33800 PR-URL: https://github.com/nodejs/node/pull/33850 Reviewed-By:
-
- Jun 15, 2020
-
-
Daniel Bevenius authored
This commit updates tools/js2c.py to touch the target output file , <(SHARED_INTERMEDIATE_DIR)/node_javascript.cc, even if the content has not changed. This is to "help" the build system so that it can compare the inputs against the output to determine if the gyp action should be run. I believe the issue here is that if js2c.py is updated this can cause the action to be run as the node_javascript.cc target would be older than js2c.py. But when the target is run the timestamp for node_javascript.cc will not be updated (because we have not changed anything that would change the contents of the file) so the js2c.py prerequisite will always be passed and the target always run. Using the update in this commit one would have to touch/modify one of the js files specified in the library_files list, config.gypi, or tools/js2c.py for this action to be run again. PR-URL: https://github.com/nodejs/node/pull/33844 Reviewed-By:
-
