- Oct 01, 2018
-
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/23115 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/23117 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/23101 Fixes: https://github.com/nodejs/node/issues/21501 Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com>
-
Rich Trott authored
Remove unnecessary @echo commands from Makefile. These were originally comments but were changed to @echo in 6bc43aee. They aren't terribly useful so let's remove them. PR-URL: https://github.com/nodejs/node/pull/23129 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Gireesh Punathil authored
Few lambdas in src/node_file.cc uses conventional pointers, turn those into unique_ptr semantics PR-URL: https://github.com/nodejs/node/pull/23124 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
- Sep 30, 2018
-
-
Anna Henningsen authored
We generally avoid using `auto` if not necessary. This formalizes this rules by writing them down in the C++ style guide. PR-URL: https://github.com/nodejs/node/pull/23028 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23125 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23125 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23125 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23125 Reviewed-By:
-
cjihrig authored
Use a Map to avoid delete operations in callback tracking. PR-URL: https://github.com/nodejs/node/pull/23125 Reviewed-By:
-
Sintendo authored
PR-URL: https://github.com/nodejs/node/pull/23166 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
- Sep 29, 2018
-
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23147 Reviewed-By:
-
Rich Trott authored
There's a global.gc() invoked in an interval, and a second one in a req.setTimeout() callback. Remove the one in the callback. I'm not sure how competing global.gc() calls might result in a deadlock, but it seems plausible and empirical testing confirms that it makes the test reliable. Fixes: https://github.com/nodejs/node/issues/23067 PR-URL: https://github.com/nodejs/node/pull/23139 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Jennifer Bland authored
PR-URL: https://github.com/nodejs/node/pull/22800 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
- Sep 28, 2018
-
-
Gireesh Punathil authored
modified the `-` CLI option help text for improved readability. PR-URL: https://github.com/nodejs/node/pull/23016 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/23077 Reviewed-By:
-
Gireesh Punathil authored
use more idiomatic expressions with RAII primitives, instead of old style goto PR-URL: https://github.com/nodejs/node/pull/23014 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/23084 Reviewed-By:
George Adams <george.adams@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
test-gc-http-client-connaborted is resource-intensive. It times out a lot on CI. Move to sequential. PR-URL: https://github.com/nodejs/node/pull/23091 Fixes: https://github.com/metadata Reviewed-By:
-
Klaus Meinhardt authored
Use 'lstat' to determine type of directory entry. This is more consistent with the type returned from the readdir binding. Also use 'path.join' over 'path.resolve' because 'name' is not absolute. PR-URL: https://github.com/nodejs/node/pull/22808 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Jeremy Apthorp authored
OpenSSL enables this feature by default, but BoringSSL doesn't. This change makes it so that when building node with BoringSSL, the behaviour matches OpenSSL's. PR-URL: https://github.com/nodejs/node/pull/22110 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons. PR-URL: https://github.com/nodejs/node/pull/23114 Reviewed-By:
-
Rich Trott authored
In test-http2-session-timeout, provide the number of requests that occurred when the test fails. PR-URL: https://github.com/nodejs/node/pull/23058 Reviewed-By:
-
Rich Trott authored
In test-http2-session-timeout, setImmediate() is used to wrap makeReq(). makeReq() is asynchronous and setImmediate() is not necessary. PR-URL: https://github.com/nodejs/node/pull/23058 Reviewed-By:
-
- Sep 27, 2018
-
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/22741 Reviewed-By:
-
Anna Henningsen authored
Aliases are very cheap to maintain, so an unconditional runtime deprecation that affects existing ecosystem code is not a good idea. This commit turns the runtime deprecation into a `--pending-deprecation` one. Fixes: https://github.com/nodejs/node/issues/23013 PR-URL: https://github.com/nodejs/node/pull/23017 Reviewed-By:
-
Ruben Bridgewater authored
It became hard to follow what was actually happening in the algorithm. This adds comments to improve the situation. PR-URL: https://github.com/nodejs/node/pull/23048 Refs: https://github.com/nodejs/node/issues/22763 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Assertion errors that produce a diff show a diff for identical entries in case one side of the comparison has more object properties than the other one. Those lines are now taken into account and will not show up as diverging lines anymore. Refs: https://github.com/nodejs/node/issues/22763 PR-URL: https://github.com/nodejs/node/pull/23048 Refs: https://github.com/nodejs/node/issues/22763 Reviewed-By:
-
Ruben Bridgewater authored
The wording seems clearer when using `values` instead of `inputs`. PR-URL: https://github.com/nodejs/node/pull/23056 Refs: https://github.com/nodejs/node/issues/22763 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
In case reference (un)equal objects fail in assertion, it should be clear that it is about the reference equality and not about the object properties. This is fixed by improving the message in such cases. Refs: https://github.com/nodejs/node/issues/22763 PR-URL: https://github.com/nodejs/node/pull/23056 Refs: https://github.com/nodejs/node/issues/22763 Reviewed-By:
-
Masashi Hirano authored
Added test that callback should be called when error occurs in dns.lookupall(). PR-URL: https://github.com/nodejs/node/pull/22985 Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/22974 Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/22974 Reviewed-By:
-
Rich Trott authored
Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is capable of providing more detail. (In one instance, use ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.) PR-URL: https://github.com/nodejs/node/pull/22969 Reviewed-By:
Weijia Wang <starkwang@126.com>
-
Rich Trott authored
Update the Collaborator Guide to use the assert team for notifications on assert module issues and pull requests. PR-URL: https://github.com/nodejs/node/pull/23085 Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/23044 Reviewed-By:
-
João Reis authored
Boxstarter asks for elevation to install packages, but not to install Boxstarter itself. Thus, run all the commands from an elevated PowerShell. Refs: https://github.com/nodejs/node/pull/22645 PR-URL: https://github.com/nodejs/node/pull/22988 Reviewed-By:
-
Rich Trott authored
Supply links for fs.createWriteStream() in fs.md. PR-URL: https://github.com/nodejs/node/pull/23104 Reviewed-By:
-
- Sep 26, 2018
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23059 Reviewed-By:
-
