- Jan 19, 2021
-
-
ZiJian Liu authored
Fixes: https://github.com/nodejs/node/issues/36936 PR-URL: https://github.com/nodejs/node/pull/36937 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36663 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Issue https://github.com/nodejs/node/issues/25741 discusses a number of performance considerations for fs.readFile, which was changed in Node.js 10.x to split discreet chunk reads over multiple event loop turns. While the fs.readFile() operation is certainly slower than it was pre 10.x, it's unlikely to be faster. Document the performance consideration and link back to the issue for more in depth analysis. Signed-off-by:
James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/25741 PR-URL: https://github.com/nodejs/node/pull/36880 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36971 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Pooja D P authored
PR-URL: https://github.com/nodejs/node/pull/36941 Fixes: https://github.com/nodejs/node/issues/36463 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rich Trott authored
Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560 PR-URL: https://github.com/nodejs/node/pull/36960 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
ZiJian Liu authored
Fixes: https://github.com/nodejs/node/issues/36949 PR-URL: https://github.com/nodejs/node/pull/36969 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Antoine du Hamel authored
Fixes: https://github.com/nodejs/node/issues/36775 PR-URL: https://github.com/nodejs/node/pull/36944 Refs: https://github.com/nodejs/node/pull/36263 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Benjamin Coe authored
Original commit message: [coverage] optional chaining coverage Implement coverage tracking for optional chains. Bug: v8:10060 Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013 Reviewed-by:Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Gus Caplan <snek@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benjamin Coe <bencoe@google.com> Cr-Commit-Position: refs/heads/master@{#72075} Refs: https://github.com/v8/v8/commit/fe191e8d05ccfa740432f56d34b1ff2d32265a8d PR-URL: https://github.com/nodejs/node/pull/36956 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
James M Snell authored
Implements initial experimental support for Curve25519 and Curve448 support for both ECDH and sign/verify in Web Crypto. Introduced as a Node.js-specific extension to Web Crypto. Signed-off-by:
James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/36076 PR-URL: https://github.com/nodejs/node/pull/36879 Reviewed-By:
Filip Skokan <panva.ip@gmail.com>
-
- Jan 18, 2021
-
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/36928 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Dan Dascalescu authored
PR-URL: https://github.com/nodejs/node/pull/36959 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com>
-
cjihrig authored
Update ESLint to 7.18.0 PR-URL: https://github.com/nodejs/node/pull/36955 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/36953 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/36952 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/36950 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
raisinten authored
The value accepted by histogram.percentile may be below 1 too. PR-URL: https://github.com/nodejs/node/pull/36938 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Ruy Adorno authored
Disabling any internet-required features (namely audit and update-notifer) in order for the test to work without an internet connection. - Fixes: https://github.com/nodejs/node/issues/36895 PR-URL: https://github.com/nodejs/node/pull/36933 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/36917 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/36910 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/36909 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
ZiJian Liu authored
Fixes: https://github.com/nodejs/node/issues/36887 PR-URL: https://github.com/nodejs/node/pull/36903 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/36898 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Rod Vagg authored
This reverts commit a45a4041. Solved by marking ports <1024 as privileged on Docker containers. Ref: https://github.com/nodejs/node/pull/36850 Ref: https://github.com/nodejs/node/issues/36847 Ref: https://github.com/nodejs/build/pull/2521 PR-URL: https://github.com/nodejs/node/pull/36884 Refs: https://github.com/nodejs/node/pull/36850 Refs: https://github.com/nodejs/node/issues/36847 Refs: https://github.com/nodejs/build/pull/2521 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Ash Cripps <acripps@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Antoine du Hamel authored
Expose the internal `primordials` object to help with Node.js core development. ```console $ node --expose-internals -r internal/test/binding lib/fs.js (node:5299) internal/test/binding: These APIs are for internal testing only. Do not use them. (Use `node --trace-warnings ...` to show where the warning was created) ``` PR-URL: https://github.com/nodejs/node/pull/36872 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
ExE Boss authored
PR-URL: https://github.com/nodejs/node/pull/36865 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
- Jan 17, 2021
-
-
zhangyongsheng authored
PR-URL: https://github.com/nodejs/node/pull/35960 Fixes: https://github.com/nodejs/node/issues/34349 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Move the script tag for dark mode support inside the body tag. PR-URL: https://github.com/nodejs/node/pull/36930 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/36966 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/36863 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
- Jan 16, 2021
-
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/36862 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Daniele Belardi <dwon.dnl@gmail.com>
-
Rich Trott authored
The replicated issue template is out of date. There isn't much reason to replicate it here anyway, so let's remove it and describe what the user should do briefly. PR-URL: https://github.com/nodejs/node/pull/36908 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rich Trott authored
This section isn't particularly useful in this context and contributes to making the document longer and less effective. This is part of a larger effort to make the contributing docs brief, informative, and friendly. Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560 PR-URL: https://github.com/nodejs/node/pull/36905 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36848 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36911 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ian Sutherland authored
PR-URL: https://github.com/nodejs/node/pull/36951 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/36947 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36700 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/36914 Refs: https://github.com/nodejs/node/pull/36190 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/36912 Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-