- Sep 21, 2015
-
-
Julien Gilli authored
Original commit message: Update BitField3 type in gen-postmortem-metadata.py Since https://codereview.chromium.org/272163002, BitField3 is a raw uint32 field, and not a SMI anymore. Update tools/gen-postmortem-metadata.py so that post-mortem tools can work with versions of V8 that shipped after that change. This change was merged in github.com/joyent/node right before node v0.12.0 was released. R=danno@chromium.org TEST=mdb_v8, a post-mortem debugging tool running on SmartOS, has been using this change since Node.js v0.12.0 was released BUG= Review URL: https://codereview.chromium.org/1296743003 Cr-Commit-Position: refs/heads/master@{#30839} PR: #2959 PR-URL: https://github.com/nodejs/node/pull/2959 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Rod Vagg <r@va.gg>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2958 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2958 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Sep 20, 2015
-
-
Sakthipriyan Vairamani authored
This patch - makes the test use tmp directory instead of the fixtures directory, - simplifies the code - moves the test to `parallel`. PR-URL: https://github.com/nodejs/node/pull/2587 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Sep 19, 2015
-
-
Fedor Indutny authored
`freeParser` deallocates `Parser` instances early if they do not fit into the free list. This does not play well with recent socket consumption change, because it will try to deallocate the parser while executing on its stack. Regression was introduced in: 1bc44686 Fix: https://github.com/nodejs/node/issues/2928 PR-URL: https://github.com/nodejs/node/pull/2956 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Rich Trott authored
This fixes a few typographical errors (comma splices and the like) and clarifies the description of assert.ifError(). It also standardizes the document on "inequality" rather than having both "inequality" and "non- equality". PR-URL: https://github.com/nodejs/node/pull/2941 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
Commit 3c293ba2 ("http: protect against response splitting attacks") filters out newline characters from HTTP headers but forgot to apply the same logic to trailing HTTP headers, i.e., headers that come after the response body. This commit rectifies that. The expected security impact is low because approximately no one uses trailing headers. Some HTTP clients can't even parse them. PR-URL: https://github.com/nodejs/node/pull/2945 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg>
-
Ben Noordhuis authored
The test verified the output of http.OutgoingMessage#writeHead() but not http.OutgoingMessage#setHeader(). Also check the response body. PR-URL: https://github.com/nodejs/node/pull/2945 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg>
-
- Sep 18, 2015
-
-
Alexis Campailla authored
Adding a Windows test to verify that a node process spawned via cmd with named pipes can access its stdio streams. Ref: https://github.com/nodejs/node-v0.x-archive/issues/7345 PR-URL: https://github.com/nodejs/node/pull/2770 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
evanlucas - Evan Lucas <evanlucas@me.com>
-
Matt Harrison authored
This fixes a problem where tab completion is empty when the input stream column size is undefined. As a solution we can force maxColumns to 1 in this scenario. PR-URL: https://github.com/nodejs/node/pull/2816 Fixes: https://github.com/nodejs/node/issues/2396 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Trevor Norris authored
Instantiating a Buffer of length zero would set the kNoZeroFill flag to true but never actually call ArrayBuffer::Allocator(). Which means the flag was never set back to false. The result was that the next allocation would unconditionally not be zero filled. Add test to ensure Uint8Array's are zero-filled after creating a Buffer of length zero. This test may falsely succeed, but will not falsely fail. Fix: https://github.com/nodejs/node/issues/2930 PR-URL: https://github.com/nodejs/node/pull/2931 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Matt Loring authored
Currently there are three separate tick processor scripts for mac, windows, and linux. These have been replaced with a single node.js script to improve maintainability and remove the need to preserve parallel logic in these separate places. PR-URL: https://github.com/nodejs/node/pull/2868 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
Add corrections about when exit event fires and how .kill() works on Windows. PR-URL: https://github.com/nodejs/node/pull/2918 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Evan Lucas authored
Fix regression introduced in 0af4c9ea that ignores the --abort-on-uncaught-exception flag. Prior to that commit, the flag was passed through to v8. After that commit, the process just calls exit(1). PR-URL: https://github.com/nodejs/node/pull/2776 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Evan Lucas authored
Windows 8+ compiled in Release mode exits with code 0xC0000409 when abort() is called. This prevents us from being able to reliably verify an abort exit code (3) on windows. PR-URL: https://github.com/nodejs/node/pull/2776 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Sep 17, 2015
-
-
Stewart Addison authored
Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. Fixes: https://github.com/nodejs/node/issues/2601 PR-URL: https://github.com/nodejs/node/pull/2602 Reviewed-By:
Steven Loomis <srloomis@us.ibm.com>
-
Michael Dawson authored
Port https://github.com/nodejs/node-v0.x-archive/commit/f3f4e282168d243610f8e0241d633ff941c9c260 to master, updating to guard changes for AIX as requested PR-URL: https://github.com/nodejs/node/pull/2891 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Imran Iqbal authored
On AIX you can not remove a directory that you are currently inside of as it results in an EBUSY error. "EBUSY: resource busy or locked". Updated the tests accordingly so that they are skipped on AIX. PR-URL: https://github.com/nodejs/node/pull/2909 Reviewed-By:
Ben Noordhuis <ben@strongloop.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Jeremiah Senkpiel authored
Notable changes: * buffer: - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) https://github.com/nodejs/node/pull/2866. - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) https://github.com/nodejs/node/pull/2777. * fs: - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) https://github.com/nodejs/node/pull/2387. - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) https://github.com/nodejs/node/pull/2167. * http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) https://github.com/nodejs/node/pull/2824. * npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) https://github.com/nodejs/node/pull/2822. * src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) https://github.com/nodejs/node/pull/2324. * v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/2870. - This fixes a previously known bug where some computed object shorthand properties did not work correctly (https://github.com/nodejs/node/issues/2507). Refs: https://github.com/nodejs/node/issues/2844 PR-URL: https://github.com/nodejs/node/pull/2889
-
Michaël Zasso authored
Original commit message: [es6] Bound function name Instead of updating the SharedFuntionInfo set the name property on the function directly. BUG=v8:4278 LOG=N R=verwaest@chromium.org, littledan@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1227523003 Cr-Commit-Position: refs/heads/master@{#29558} Fixes: https://github.com/nodejs/node/issues/2754 PR-URL: https://github.com/nodejs/node/pull/2916 Reviewed-By:Fedor Indutny <fedor@indutny.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Fedor Indutny authored
Original commit message: [objects] do not visit ArrayBuffer's backing store ArrayBuffer's backing store is a pointer to external heap, and can't be treated as a heap object. Doing so will result in crashes, when the backing store is unaligned. See: https://github.com/nodejs/node/issues/2791 BUG=chromium:530531 R=mlippautz@chromium.org LOG=N Review URL: https://codereview.chromium.org/1327403002 Cr-Commit-Position: refs/heads/master@{#30771} Fix: https://github.com/nodejs/node/issues/2791 PR-URL: https://github.com/nodejs/node/pull/2912 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Sakthipriyan Vairamani authored
As `raw` and `raws` encodings are deprecated for such a long time, and they both are undocumented, this patch removes the support for those encodings completely. Previous discussion: https://github.com/nodejs/node/pull/2829 PR-URL: https://github.com/nodejs/node/pull/2859 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Sakthipriyan Vairamani authored
This patch - makes chdir test to use the tmp directory - moves the test to parallel - renames the file to test-process-chdir as chdir is in process module PR-URL: https://github.com/nodejs/node/pull/2589 Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
This change: * notes that the exit event is not guaranteed to fire * provides an example situation where the exit event may not fire * makes a minor copyediting change * enforces 80 character wrap in one place where it was not honored Fixes: https://github.com/nodejs/node/issues/2853 PR-URL: https://github.com/nodejs/node/pull/2861 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Trevor Norris authored
Now that Buffers instantiate the Uint8Array in JS the error message has changed in case the allocation fails due to OOM. Tests have been updated to match. PR-URL: https://github.com/nodejs/node/pull/2915 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Trevor Norris authored
The env_ field in ArrayBufferAllocator needs to be null'd out since it is used during initialization and checked prior to properly being set by set_env(). Fixes: 74178a56 "buffer: construct Uint8Array in JS" PR-URL: https://github.com/nodejs/node/pull/2913 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Sam Roberts authored
createServer() can create socket of types other than TCP. PR-URL: https://github.com/nodejs/node/pull/2903 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/2903 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/2903 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Sam Roberts authored
Most calls to ref() and unref() are chainable, timers should be chainable, too. Typical use: var to = setTimeout(ontimeout, 123).unref(); PR-URL: https://github.com/nodejs/node/pull/2905 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trevor Norris <trevnorris@nodejs.org>
-
- Sep 16, 2015
-
-
Trevor Norris authored
By default v8 allocates typed arrays <= 64 bytes inside the v8 heap. In these cases the memory pointer returned by Buffer::Data() can change while the memory is being operated on. Resolve by passing a flag that forces all typed arrays outside the v8 heap. Fixes: 74178a56 "buffer: construct Uint8Array in JS" PR-URL: https://github.com/nodejs/node/pull/2893 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
Overall construction time of Typed Arrays is faster in JS, but the problem with using it normally is zero-fill of memory. Get around this by using a flag in the ArrayBuffer::Allocator to trigger when memory should or shouldn't be zero-filled. Remove Buffer::Create() as it is no longer called. The creation of the Uint8Array() was done at each callsite because at the time of this patch there was a performance penalty for centralizing the call in a single function. PR-URL: https://github.com/nodejs/node/pull/2866 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Malcolm Ahoy authored
Refactor out the if/else statement checking for option.host. Add whitespace to make concatenation chunks more readable and consistent with the https version of Agent.getName(). PR-URL: https://github.com/nodejs/node/pull/2825 Reviewed-By:
Julian Duque <julianduquej@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Karl Skomski authored
Use the built-in Typed Array method subarray() to improve performance of Buffer#slice(). Benchmark improvements: benchmark/buffer-slice: 40% benchmark/buffer-creation (pool): 25% Additional tests also added. PR-URL: https://github.com/nodejs/node/pull/2777 Reviewed-By:Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
James M Snell authored
Following the IBM+StrongLoop announcement last week, we (@piscisaureus, @bnoordhuis, @srl295, @mhdawson, and myself) want to take a moment to reiterate our personal commitment to Node.js and the Foundation. Per the TSC rules, any one company is limited to no more than 1/4 of the voting seats on the TSC and after talking it over amongst ourselves, @srl295 and @mhdawson have elected to step back from the TSC for now. What I would propose is that they continue to participate in the weekly TSC meetings as observers; and that once the membership expands, they be considered once again for full TSC status. Both Steven and Michael will continue to be actively involved with Node.js. Both are active members of various Working Groups. (Michael chairs the Benchmarking workgroup and Steven chairs the Intl workgroup.) /cc @nodejs/tsc Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Rod Vagg <r@va.gg> Reviewed-By:
Trevor Norris <trevnorris@nodejs.org> PR-URL: https://github.com/nodejs/node/pull/2858
-
Dmitry Vasilyev authored
Examples in the benchmark readme previously sill referenced iojs(1). PR-URL: https://github.com/nodejs/node/pull/2884 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Sven Slootweg authored
Fixes: https://github.com/nodejs/node/issues/2880 PR-URL: https://github.com/nodejs/node/pull/2881 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Michael Dawson authored
These are the core changes that allow AIX to compile. There are still some test failures as there are some patches needed for libuv and npm that we'll need to contribute through those communities but this set allows node to be built on AIX and pass most of the core tests The change in js2c is because AIX does not support $ in identifier names. See the discussion/agreement in https://github.com/nodejs/node/issues/2272 PR-URL: https://github.com/nodejs/node/pull/2364 Reviewed-By:
Ben Noordhuis <ben@strongloop.com> Reviewed-By:
Rod Vagg <r@va.gg>
-
Ali Ijaz Sheikh authored
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: https://github.com/nodejs/node/issues/2507 PR-URL: https://github.com/nodejs/node/pull/2870 Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Sep 15, 2015
-
-
Sakthipriyan Vairamani authored
In Python, the default values of parameters are evaluated only once during their declaration. So, whenever the default parameter is used the same object will be used. Since we use a list, which is a mutable object, this could lead to unexpected results. PR-URL: https://github.com/nodejs/node/pull/2553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-