- Sep 27, 2021
-
-
dr-js authored
Refs: https://github.com/nodejs/node/pull/36641 Refs: https://github.com/nodejs/node/issues/36617#issuecomment-751443964 Documentation-only deprecate `.aborted` property and `'abort'`, `'aborted'` event in `http`, and suggest using the corresponding Stream API instead. Co-authored-by:
Michaël Zasso <targos@protonmail.com> Co-authored-by:
Rich Trott <rtrott@gmail.com> Co-authored-by:
Robert Nagy <ronagy@icloud.com> Co-authored-by:
Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36670 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Artur K authored
PR-URL: https://github.com/nodejs/node/pull/40192 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
XadillaX authored
PR-URL: https://github.com/nodejs/node/pull/40203 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
thunder-coding authored
PR-URL: https://github.com/nodejs/node/pull/40206 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/40219 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Qingyu Deng <i@ayase-lab.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
MrBBot authored
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. PR-URL: https://github.com/nodejs/node/pull/39772 Refs: https://github.com/nodejs/node/pull/39395 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
- Sep 26, 2021
-
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40151 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Voltrex authored
The `validateArray()` validator could be used to cleanup validation and keep consistency. PR-URL: https://github.com/nodejs/node/pull/39774 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Qingyu Deng <i@ayase-lab.com>
-
Christian Clauss authored
https://docs.python.org/3/library/stdtypes.html#str.endswith One function call should be faster than three function calls per file. PR-URL: https://github.com/nodejs/node/pull/40017 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
XadillaX authored
Since `toUSVString()` was exposed in `util` as a public API, not only for internal `url` any more. PR-URL: https://github.com/nodejs/node/pull/40204 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40143 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/40143 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Clément Nardi authored
The current wording suggests to compare Date objects, which won't work. PR-URL: https://github.com/nodejs/node/pull/40134 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Use mailmap entry to consolidate duplicate entries in AUTHORS. PR-URL: https://github.com/nodejs/node/pull/40202 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Update a transitive dependency in lint-md to fix an autolink bug in the formatter that causes a lot of our files (particularly changelogs) to be misformatted when run through the automatic formatter. Refs: https://github.com/syntax-tree/mdast-util-gfm-autolink-literal/commit/7555d45f9ad4ecdd578ffedf3cbc4b01d3ae0135 PR-URL: https://github.com/nodejs/node/pull/40181 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
Markdown formatter is now available via `mark format-md` (or `vcbuild format-md` on Windows). PR-URL: https://github.com/nodejs/node/pull/40181 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Gerhard Stöbich authored
Add a yaml section to document when diagnostics_channel APIs were introduced. PR-URL: https://github.com/nodejs/node/pull/40208 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Sep 25, 2021
-
-
Michaël Zasso authored
FreeBSD 11 goes out of support on 2021-09-30. FreeBSD 12.1 is not supported since 2021-01-31. PR-URL: https://github.com/nodejs/node/pull/40179 Refs: https://en.wikipedia.org/wiki/FreeBSD_version_history#Version_history Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/40009 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/40188 Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40084 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com>
-
Rebhi Alfa authored
PR-URL: https://github.com/nodejs/node/pull/40164 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Voltrex authored
The usage of more validators could clean up validation and keep consistency. PR-URL: https://github.com/nodejs/node/pull/39812 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
m3m0ry authored
Buffer's Blob api example code has some token error PR-URL: https://github.com/nodejs/node/pull/40125 Reviewed-By:
Qingyu Deng <i@ayase-lab.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`. PR-URL: https://github.com/nodejs/node/pull/40180 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Sep 24, 2021
-
-
Pancake authored
By using destruction re-naming useless variables were eliminated. PR-URL: https://github.com/nodejs/node/pull/40183 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
xuchaobei authored
PR-URL: https://github.com/nodejs/node/pull/40187 Reviewed-By:
Qingyu Deng <i@ayase-lab.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Daniel Bevenius authored
This commit updates SafeGetenv to check if the current process has the effective capability cap_net_bind_service set, and if so allows environment variables to be read. The motivation for this change is a use-case where Node is run in a container, and the is a requirement to be able to listen to ports below 1024. This is done by setting the capability of cap_net_bind_service. In addition there is a need to set the environment variable `NODE_EXTRA_CA_CERTS`. But currently this environment variable will not be read when the capability has been set on the executable. PR-URL: https://github.com/nodejs/node/pull/37727 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/40153 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
- Sep 23, 2021
-
-
Rich Trott authored
LakshmiSwethaG's name appears twice in AUTHORS. Use .mailmap to map the various email addresses to a single one. PR-URL: https://github.com/nodejs/node/pull/40172 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
I ran into "Cannot combine --user and --target" in an environment and adding --no-user seemed to fix it. Refs: https://stackoverflow.com/a/67259534/436641 PR-URL: https://github.com/nodejs/node/pull/40169 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Christian Clauss <cclauss@me.com>
-
SURYAPRATAP SINGH SURYAVANSHI authored
PR-URL: https://github.com/nodejs/node/pull/40177 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary step before we can use the lint preset to format markdown files. PR-URL: https://github.com/nodejs/node/pull/40166 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Evan Lucas authored
This makes the version picker usable on mobile devices. Previously, the version picker was difficult to select from. This change makes the #gtoc > ul > li elements have a display of `block` instead of `inline`. PR-URL: https://github.com/nodejs/node/pull/39958 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Rich Trott authored
I missed this change in 420cdc7c. PR-URL: https://github.com/nodejs/node/pull/40163 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Beth Griggs authored
Notable changes: crypto: * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) https://github.com/nodejs/node/pull/39927 doc: * add Ayase-252 to collaborators (Qingyu Deng) https://github.com/nodejs/node/pull/40078 fs: * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) https://github.com/nodejs/node/pull/40013 http: * (SEMVER-MINOR) limit requests per connection (Artur K) https://github.com/nodejs/node/pull/40082 src: * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) https://github.com/nodejs/node/pull/39754 * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) https://github.com/nodejs/node/pull/39754 * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) https://github.com/nodejs/node/pull/39926 stream: * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) https://github.com/nodejs/node/pull/39067 PR-URL: https://github.com/nodejs/node/pull/40175
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/40161 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
- Sep 22, 2021
-
-
Guilherme Bernal authored
PR-URL: https://github.com/nodejs/node/pull/40157 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/40121 Reviewed-By:
Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
Upcoming remark-based formatting/linting will add a blank line between comments in markdown. This is in preparation for that change. PR-URL: https://github.com/nodejs/node/pull/40160 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-