- Oct 11, 2019
-
-
Richard Lau authored
Release builds specifically set the `--with-intl=` configure option instead of relying on the default. Explicitly set to `full-icu`. Refs: https://github.com/nodejs/node/pull/29522 PR-URL: https://github.com/nodejs/node/pull/29887 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Sergei Osipov authored
PR-URL: https://github.com/nodejs/node/pull/29880 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
- Oct 10, 2019
-
-
Gerhard Stoebich authored
Clearly state the modules version 72 is official node 12, similar as it is done for other major node versions. PR-URL: https://github.com/nodejs/node/pull/29877 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/29839 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Matteo Collina authored
This reverts commit b03845b9. PR-URL: https://github.com/nodejs/node/pull/29717 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Matteo Collina authored
This reverts commit ce62e963. PR-URL: https://github.com/nodejs/node/pull/29717 Reviewed-By:
-
cjihrig authored
process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this commit removes it. PR-URL: https://github.com/nodejs/node/pull/29873 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Nick Schonning authored
Applies MarkdownLint MD038 rule PR-URL: https://github.com/nodejs/node/pull/29329 Reviewed-By:
-
Nick Schonning authored
Applies MarkdownLint MD038 rule PR-URL: https://github.com/nodejs/node/pull/29329 Reviewed-By:
-
Jeremiah Senkpiel authored
Some doc bits / fixes which were missing from cbd8d715 PR-URL: https://github.com/nodejs/node/pull/29890 Reviewed-By:
-
Jeremiah Senkpiel authored
This is unlikely to be necessary in any case, and causes much unwarrented complexity when implementing further optimizations. Refs: https://github.com/nodejs/node/pull/29893#discussion_r333179482 PR-URL: https://github.com/nodejs/node/pull/29908 Reviewed-By:
-
Anna Henningsen authored
This seems to make sense if we want to promote the use of `fs.promises`, although it’s not strictly necessary. PR-URL: https://github.com/nodejs/node/pull/29876 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Beth Griggs authored
Node.js 8 is due to go End-of-Life on 31st December 2019. Notable changes: - **deps**: upgrade openssl sources to 1.0.2s (Sam Roberts) [#28230](https://github.com/nodejs/node/pull/28230) PR-URL: https://github.com/nodejs/node/pull/29617
-
Sam Roberts authored
Make test failures easier to diagnose through progress logging, and reporting of dlerror(). PR-URL: https://github.com/nodejs/node/pull/29818 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Oct 09, 2019
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/29850 Reviewed-By:
-
Guy Bedford authored
This reverts commit ec8776da6fa77628e12718bb38cee687303d4137. PR-URL: https://github.com/nodejs/node/pull/29754 Reviewed-By:
-
Jeremiah Senkpiel authored
This adds long-requested methods for asynchronously interacting and iterating through directory entries by using `uv_fs_opendir`, `uv_fs_readdir`, and `uv_fs_closedir`. `fs.opendir()` and friends return an `fs.Dir`, which contains methods for doing reads and cleanup. `fs.Dir` also has the async iterator symbol exposed. The `read()` method and friends only return `fs.Dirent`s for this API. Having a entry type or doing a `stat` call is deemed to be necessary in the majority of cases, so just returning dirents seems like the logical choice for a new api. Reading when there are no more entries returns `null` instead of a dirent. However the async iterator hides that (and does automatic cleanup). The code lives in separate files from the rest of fs, this is done partially to prevent over-pollution of those (already very large) files, but also in the case of js allows loading into `fsPromises`. Due to async_hooks, this introduces a new handle type of `DIRHANDLE`. This PR does not attempt to make complete optimization of this feature. Notable future improvements include: - Moving promise work into C++ land like FileHandle. - Possibly adding `readv()` to do multi-entry directory reads. - Aliasing `fs.readdir` to `fs.scandir` and doing a deprecation. Refs: https://github.com/nodejs/node-v0.x-archive/issues/388 Refs: https://github.com/nodejs/node/issues/583 Refs: https://github.com/libuv/libuv/pull/2057 PR-URL: https://github.com/nodejs/node/pull/29349 Reviewed-By:
-
- Oct 08, 2019
-
-
Jakob Krigovsky authored
The Legacy URL API is deprecated, see: - https://nodejs.org/api/url.html#url_legacy_url_api - https://nodejs.org/api/deprecations.html# deprecations_dep0116_legacy_url_api PR-URL: https://github.com/nodejs/node/pull/29844 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
- Oct 07, 2019
-
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/29816 Fixes: https://github.com/nodejs/node/issues/29811 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Myles Borins authored
Refs: https://github.com/v8/v8/compare/7.8.279.12...7.8.279.14 PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Myles Borins authored
Refs: https://github.com/v8/v8/compare/7.8.279.10...7.8.279.12 PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
Myles Borins authored
Refs: https://github.com/v8/v8/compare/7.8.279.9...7.8.279.10 PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
cjihrig authored
This commit updates V8's postmortem metadata generation script to support V8 7.8. The following metadata has changed: - v8dbg_class_JSDate__value__Object - The postmortem metadata generation script needed to be updated. No action should be required by postmortem tools. - v8dbg_class_JSRegExp__source__Object - The postmortem metadata generation script needed to be updated. No action should be required by postmortem tools. PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By: -
Myles Borins authored
Original commit message: [build] Add message-template.h to build file This was missed during a file move and can cause build bugs. Bug: chromium:991547 Change-Id: I157e7bb656956c08293c205c0d00884aecc7adee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798430 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63711} Refs: https://github.com/v8/v8/commit/716875d74cba4e3550c839e78df0c0c4df0f7758 PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
Sam Roberts authored
Original commit message: Make code generator python3.7 compatible (async keyword). Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109 Fixes: https://github.com/nodejs/node/issues/29548 Refs: - https://github.com/nodejs/node/issues/29548#issuecomment-531717985 - https://github.com/nodejs/node/pull/29520 - https://github.com/nodejs/node/pull/29340 - https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351 - https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a PR-URL: https://github.com/nodejs/node/pull/29585 Refs: https://github.com/nodejs/node/pull/29520 Reviewed-By: -
Benjamin Coe authored
Original commit message: [debugger] Fix code coverage for break/return inside switch-case Case statements have a list of statements associated with them, but are not blocks, and were hence not fixed-up correctly for code coverage. This CL also applies the fix-up to the "body" of case statements, in this way removing ranges reported as uncovered between the final break/return in a case and the next case (or end of function). Drive-by: Add optional pretty printing to code coverage test results. Change-Id: I5f4002d4e17b7253ed516d99f7c389ab2264be10 Bug: v8:9705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798426 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63719} Refs: https://github.com/v8/v8/commit/deac757bc76d207845375340bcea090c774ad9d0 PR-URL: https://github.com/nodejs/node/pull/29626 Reviewed-By:
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
Michaël Zasso authored
until c6196ad7a2d601a4e1fdb313bfe2ec727fd67f7a Co-authored-by:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
-
Refael Ackermann authored
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By:
-
Refael Ackermann authored
`std::atomic_init<size_t>` is not implemented on all platforms. PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By:
-
Myles Borins authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/29694 Reviewed-By:
-
