- Oct 23, 2019
-
-
legendecas authored
Make ListNode<T> postmortem easier to find last items in the queue. PR-URL: https://github.com/nodejs/node/pull/30027 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Richard Lau authored
`configure` will log a warning if the detected compiler is not new enough. Take some of the guesswork out of it by also logging the version of the compiler that was detected. PR-URL: https://github.com/nodejs/node/pull/30028 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
Also eliminate some redundancy. PR-URL: https://github.com/nodejs/node/pull/30038 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Luigi Pinca authored
The fallback code is no longer used when exporting to readable-stream. Refs: https://github.com/nodejs/node/pull/29514 PR-URL: https://github.com/nodejs/node/pull/30041 Fixes: https://github.com/nodejs/node/issues/30040 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Luigi Pinca authored
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: https://github.com/nodejs/node/issues/30040 PR-URL: https://github.com/nodejs/node/pull/30041 Reviewed-By:
-
Anna Henningsen authored
This test would be broken by V8 7.9 due to the changed `ArrayBuffer` backing store management (the same way that V8 7.8 broke this for `SharedArrayBuffer`s). While working on a solution, it would be good to already have this test in Node.js to avoid unnecessary accidental breakage. Refs: https://github.com/nodejs/node-v8/issues/115 PR-URL: https://github.com/nodejs/node/pull/30044 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Beth Griggs authored
Notable changes: * assert: * If the validation function passed to `assert.throws()` or `assert.rejects()` returns a value other than `true`, an assertion error will be thrown instead of the original error to highlight the programming mistake (Ruben Bridgewater). https://github.com/nodejs/node/pull/28263 * If a constructor function is passed to validate the instance of errors thrown in `assert.throws()` or `assert.reject()`, an assertion error will be thrown instead of the original error (Ruben Bridgewater). https://github.com/nodejs/node/pull/28263 * build: * Node.js releases are now built with default full-icu support. This means that all locales supported by ICU are now included and Intl-related APIs may return different values than before (Richard Lau). https://github.com/nodejs/node/pull/29887 * The minimum Xcode version supported for macOS was increased to 10. It is still possible to build Node.js with Xcode 8 but this may no longer be the case in a future v13.x release (Michael Dawson). https://github.com/nodejs/node/pull/29622 * child_process: * `ChildProcess._channel` (DEP0129) is now a Runtime deprecation (cjihrig). https://github.com/nodejs/node/pull/27949 * console: * The output `console.timeEnd()` and `console.timeLog()` will now automatically select a suitable time unit instead of always using milliseconds (Xavier Stouder). https://github.com/nodejs/node/pull/29251 * deps: * The V8 engine was updated to version 7.8. This includes performance improvements to object destructuring, memory usage and WebAssembly startup time (Myles Borins). https://github.com/nodejs/node/pull/29694) * domain: * The domain's error handler is now executed with the active domain set to the domain's parent to prevent inner recursion (Julien Gilli). https://github.com/nodejs/node/pull/26211 * fs: * The undocumented method `FSWatcher.prototype.start()` was removed (Lucas Holmquist). https://github.com/nodejs/node/pull/29905 * Calling the `open()` method on a `ReadStream` or `WriteStream` now emits a runtime deprecation warning. The methods are supposed to be internal and should not be called by user code (Robert Nagy). https://github.com/nodejs/node/pull/29061 * `fs.read/write`, `fs.readSync/writeSync` and `fd.read/write` now accept any safe integer as their `offset` parameter. The value of `offset` is also no longer coerced, so a valid type must be passed to the functions (Zach Bjornson). https://github.com/nodejs/node/pull/26572 * http: * Aborted requests no longer emit the `end` or `error` events after `aborted` (Robert Nagy). https://github.com/nodejs/node/pull/27984 https://github.com/nodejs/node/pull/20077 * Data will no longer be emitted after a socket error (Robert Nagy). https://github.com/nodejs/node/pull/28711 * The legacy HTTP parser (previously available under the `--http-parser=legacy` flag) was removed (Anna Henningsen). https://github.com/nodejs/node/pull/29589 * The `host` option for HTTP requests is now validated to be a string value (Giorgos Ntemiris). https://github.com/nodejs/node/pull/29568 * The `request.connection` and `response.connection` properties are now runtime deprecated. The equivalent `request.socket` and `response.socket` should be used instead (Robert Nagy). https://github.com/nodejs/node/pull/29015 * http, http2: * The default server timeout was removed (Ali Ijaz Sheikh). https://github.com/nodejs/node/pull/27558 * Brought 425 status code name into accordance with RFC 8470. The name changed from "Unordered Collection" to "Too Early" (Sergei Osipov). https://github.com/nodejs/node/pull/29880 * lib: * The `error.errno` property will now always be a number. To get the string value, use `error.code` instead (Joyee Cheung). https://github.com/nodejs/node/pull/28140 * module: * `module.createRequireFromPath()` is deprecated. Use `module.createRequire()` instead (cjihrig). https://github.com/nodejs/node/pull/27951 * src: * Changing the value of `process.env.TZ` will now clear the tz cache. This affects the default time zone used by methods such as `Date.prototype.toString` (Ben Noordhuis). https://github.com/nodejs/node/pull/20026 * stream: * The timing and behavior of streams was consolidated for a number of edge cases. Please look at the individual commits below for more information. PR-URL: https://github.com/nodejs/node/pull/29504
-
- Oct 22, 2019
-
-
Anna Henningsen authored
Add a flag that makes Node.js print the stack trace at the time of *throwing* uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This is disabled by default because it affects GC behavior. PR-URL: https://github.com/nodejs/node/pull/30025 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
- Oct 21, 2019
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/30029 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Michaël Zasso authored
This release marks the transition of Node.js 12.x into Long Term Support (LTS) with the codename 'Erbium'. The 12.x release line now moves into "Active LTS" and will remain so until October 2020. After that time, it will move into "Maintenance" until end of life in April 2022. Notable changes: npm was updated to 6.12.0. It now includes a version of `node-gyp` that supports Python 3 for building native modules. PR-URL: https://github.com/nodejs/node/pull/29981
-
Daniel Bevenius authored
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: https://github.com/nodejs/node/pull/30004 Reviewed-By:
-
- Oct 20, 2019
-
-
cjihrig authored
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: https://github.com/nodejs/node/pull/29996 Reviewed-By:
-
Michaël Zasso authored
From V8 7.9, the option will no longer exist upstream. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1796325 PR-URL: https://github.com/nodejs/node/pull/30021 Reviewed-By:
-
Michaël Zasso authored
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: https://github.com/nodejs/node/issues/27214 PR-URL: https://github.com/nodejs/node/pull/30022 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Michaël Zasso authored
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: https://github.com/nodejs/node/pull/30023 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
-
- Oct 19, 2019
-
-
Minwoo Jung authored
update collaborator email address PR-URL: https://github.com/nodejs/node/pull/30007 Reviewed-By:
-
Sam Roberts authored
For compatibility with OpenSSL 1.1.0 and 1.0.1 a series of initialization wrappers were being called, many deprecated, and many calling each other internally already. Compatibility is unnecessary in 12.x and later, which support only OpenSSL 1.1.1, and the multiple calls cause the configuration file to be loaded multiple times. Fixes: https://github.com/nodejs/node/issues/29702 See: - https://mta.openssl.org/pipermail/openssl-users/2019-October/011303.html - https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_ssl.html - https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_crypto.html PR-URL: https://github.com/nodejs/node/pull/29999 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Christian Clauss authored
Request Python 3 with pyenv and ensure that python3 is used by Makefile to run Python scripts. PR-URL: https://github.com/nodejs/node/pull/29451 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
common.skipIfInspectorEnabled() is only used once in all of the tests. The test is more clear (in my opinion, at least) without the abstraction so put the check directly in the test. Additionally, it honestly looks like an error (which is how I noticed it in the first place) and that someone mistyped the far more common skipIfInspectorDisabled(). PR-URL: https://github.com/nodejs/node/pull/29993 Reviewed-By:
-
Rich Trott authored
This fixes YAML that gets incorrectly processed by our tooling. Refs: https://github.com/nodejs/node/pull/29910#issuecomment-543237767 PR-URL: https://github.com/nodejs/node/pull/30016 Reviewed-By:
-
- Oct 18, 2019
-
-
akitsu-sanae authored
PR-URL: https://github.com/nodejs/node/pull/29984 Reviewed-By:
-
Michaël Zasso authored
Fixes: https://github.com/nodejs/node/issues/29927 Refs: https://github.com/nodejs/node/pull/29931 PR-URL: https://github.com/nodejs/node/pull/29965 Reviewed-By:
-
- Oct 17, 2019
-
-
Richard Lau authored
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: https://github.com/nodejs/node/pull/29995 Fixes: https://github.com/nodejs/build/issues/1961 Refs: https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896 Reviewed-By:
-
Myles Borins authored
Currently `--es-module-specifier-resolution=node` has an alternative resolution order than the default in common.js, this causes inconsistencies. As discussed in @nodejs/modules we want to preserve resolution order between implementations. PR-URL: https://github.com/nodejs/node/pull/29974 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/29937 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Lucas Pardue authored
This adds RFC 4607 support for IPv4 and IPv6. Co-Authored-By:
Nicolas Thumann <46975855+n-thumann@users.noreply.github.com> Co-Authored-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/29950 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Gabriel Schulhof authored
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <suresh.srinivas@intel.com>! PR-URL: https://github.com/nodejs/node/pull/29973 Reviewed-By:
-
Ben Noordhuis authored
Make it possible to clone the internal state of a Hash object into a new Hash object, i.e., to fork the state of the object. Fixes: https://github.com/nodejs/node/issues/29903 PR-URL: https://github.com/nodejs/node/pull/29910 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Matteo Rossi authored
Provides some missing test coverage. PR-URL: https://github.com/nodejs/node/pull/29970 Reviewed-By:
-
- Oct 16, 2019
-
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/29961 Reviewed-By:
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/29961 Reviewed-By:
-
Huachao Mao authored
PR-URL: https://github.com/nodejs/node/pull/29962 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/29061 PR-URL: https://github.com/nodejs/node/pull/29969 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/28685 Refs: https://github.com/nodejs/node/issues/28684 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: https://github.com/nodejs/node/pull/29982 Reviewed-By:
-
Rich Trott authored
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: https://github.com/nodejs/node/pull/29982 Reviewed-By:
-
Rich Trott authored
Doctool tests have been failing a lot in CI on Win2008 R2. It appears async functions and callback-based functions are being used in combination such that the callback-based function cannot guarantee that it will invoke its callback. Convert the callback-based functions to async functions so we have one paradigm and reliable results. PR-URL: https://github.com/nodejs/node/pull/29979 Reviewed-By:
-
isaacs authored
Update npm to 6.12.0 Now `npm ci` runs prepare scripts for git dependencies, and respects the `--no-optional` argument. Warnings for `engine` mismatches are printed again. Various other fixes and cleanups. PR-URL: https://github.com/nodejs/node/pull/29885 Reviewed-By:
-
- Oct 15, 2019
-
-
Rich Trott authored
Prepare the final few documents that haven't been updated to always use `[]` with reference links and to escape `[` and `]` for things that aren't links in markdown files. PR-URL: https://github.com/nodejs/node/pull/29963 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
