- Sep 01, 2018
-
-
Gabriel Schulhof authored
* Move class `TsFn` to name space `v8impl` and rename it to `ThreadSafeFunction` * Remove `NAPI_EXTERN` from API declarations, because it's only needed in the header file. PR-URL: https://github.com/nodejs/node/pull/22259 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Troels Liebe Bentsen authored
PR-URL: https://github.com/nodejs/node/pull/22510 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Rich Trott authored
Instead of disabling all ESLint rules on two lines in test-assert.js, specify the rule that needs to be disabled. PR-URL: https://github.com/nodejs/node/pull/22563 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rich Trott authored
Instead of disabling all ESLint rules for a line, specify the two rules that should be disabled. PR-URL: https://github.com/nodejs/node/pull/22563 Reviewed-By:
-
Anna Henningsen authored
The text contained a number of inaccuracies: - The main thread is never blocked by a stream close. - There is no such thing as an EOF character on the OS level, the libuv level, or the Node.js stream level. - These streams *do* respond to `.close()`, but pending reads can delay this indefinitely. - Pushing a random character into the stream works only when the source data can be controlled; Using the JS `.push()` method is something different, and does not “unblock” any threads. Refs: https://github.com/nodejs/node/pull/21212 PR-URL: https://github.com/nodejs/node/pull/22569 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Joyee Cheung authored
These test cases in `test/parallel/test-dns-lookup.js` send dns requests and depend on the results, which could fail if the DNS service for invalid hosts is hijacked by the ISP. PR-URL: https://github.com/nodejs/node/pull/22516 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This un-‘breaks’ the error message we print when using Python 3 to run `configure`. Refs: https://github.com/nodejs/help/issues/1457 PR-URL: https://github.com/nodejs/node/pull/22536 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22553 Reviewed-By:
-
Denys Otrishko authored
uid/gid must be uint32, which is asserted on a c++ side but wasn't checked on a JS side and therefore resulted in a process crash. Refs: https://github.com/nodejs/node/issues/22570 PR-URL: https://github.com/nodejs/node/pull/22574 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Bartosz Sosnowski authored
Ref: https://github.com/nodejs/node/pull/21403 PR-URL: https://github.com/nodejs/node/pull/22582 Reviewed-By:
-
Alexey Kozyatinskiy authored
These headers are exposed from V8 for embedder and should not be used by native addons. Fixes https://github.com/nodejs/node/issues/22415 PR-URL: https://github.com/nodejs/node/pull/22586 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Matheus Marchini authored
Add V8 CodeEventHandler and --interpreted-frames-native-stack to our diagnostics tiers of support document as Unclassified APIs. PR-URL: https://github.com/nodejs/node/pull/22588 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Matheus Marchini authored
We have tests for Linux perf under `test/v8-updates/test-linux-perf.js`, and those tests are run as part of the `node-test-commit-v8-linux` job. PR-URL: https://github.com/nodejs/node/pull/22588 Reviewed-By:
-
- Aug 31, 2018
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22475 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Michaël Zasso authored
This is unnecessary, deprecated, and removed in V8 7.0. PR-URL: https://github.com/nodejs/node/pull/22596 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Rich Trott authored
Three tests are skipped because of Applie bug 17894467. That bug exists in OS X 10.10, but we no longer support 10.10 (and neither does Apple). Remove the test-skipping. PR-URL: https://github.com/nodejs/node/pull/22546 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Rich Trott authored
Correct test name to reflect the module it tests (`trace_events`). PR-URL: https://github.com/nodejs/node/pull/22605 Reviewed-By:
-
Rich Trott authored
Shorten the Stability Index text. PR-URL: https://github.com/nodejs/node/pull/22544 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
- Aug 30, 2018
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22551 Refs: https://github.com/nodejs/node/pull/22501 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22519 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22555 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22474 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Sam Ruby authored
Parse source code using acorn; extracting exports. When producing documentation, match exports to headers. When a match is found, add a [src] link. This first commit handles simple exported classes and functions, and does so without requiring any changes to the source code or markdown. Subsequent commits will attempt to match more headers, and some of these changes are likely to require changes to the source code and/or markdown. PR-URL: https://github.com/nodejs/node/pull/22405 Reviewed-By:
-
Refael Ackermann authored
* extract the gist into common.pwdCommand * Merge test-child-process-buffering.js into test-child-process-stdio.js PR-URL: https://github.com/nodejs/node/pull/22522 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22482 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22477 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
- Aug 29, 2018
-
-
Ujjwal Sharma authored
Adds a method compileFunction to the vm module, which serves as a binding for v8::CompileFunctionInContext with appropriate args for specifying the details, and provide params for the wrapper. Eventually, we would be changing Module._compile to use this internally over the standard Module.wrap PR-URL: https://github.com/nodejs/node/pull/21571 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
Some nits were also fixed in passing. PR-URL: https://github.com/nodejs/node/pull/22537 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
This overload was added in V8 6.9 and the one without the isolate parameter was removed in V8 7.0. Refs: https://github.com/v8/v8/commit/3dd5c6fe38355b8323597341409b37f931de5a85 PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
These overloads were added in V8 6.9 and the ones without the isolate parameter were removed in V8 7.0. Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2 PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Michaël Zasso authored
This overload was added in V8 6.9 and the one without isolate was removed in V8 7.0. Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2 PR-URL: https://github.com/nodejs/node/pull/22531 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/22564 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/22480 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Lucas Woo authored
PR-URL: https://github.com/nodejs/node/pull/22430 Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
- Aug 28, 2018
-
-
Anna Henningsen authored
We generally add these to all headers that are considered internal to Node. These aren’t distributed as part of the headers tarball, so I think this does not have to be semver-major (and we have been changing the APIs in these headers freely anyway). PR-URL: https://github.com/nodejs/node/pull/22514 Reviewed-By:
-
Gireesh Punathil authored
charcter device streaming works just like any other streams, but hangs on the close callsite due to the worker thread being blocked on the read and main thread waiting for any async event that may not occur. Document this behavior and suggest a potential workaround. Fixes: https://github.com/nodejs/node/issues/15439 PR-URL: https://github.com/nodejs/node/pull/21212 Reviewed-By:
-
Michaël Zasso authored
Partially backport an upstream commit that deprecates String::Concat without the isolate parameter. This overload has already been removed in V8 7.0. PR-URL: https://github.com/nodejs/node/pull/22521 Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2 Reviewed-By:
-
