Commits · 3d3b45ae958f5bfc8cfdbdb30bcfd512a18740af · github.com / v8-riscv / node

Mar 08, 2016

path: fix normalize for absolutes · 3d3b45ae

Evan Lucas authored Mar 07, 2016

Fixes a regression introduced by
b212be08.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: https://github.com/nodejs/node/issues/5585
PR-URL: https://github.com/nodejs/node/pull/5589


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

3d3b45ae

doc: add info to docs on how to submit docs patch · 1d9a2b28

Sequoia McDowell authored Jan 08, 2016

The docs mentioned that the docs source live in
the node source, but did not link to same.

PR-URL: https://github.com/nodejs/node/pull/4591


Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

1d9a2b28

test: remove broken debugger scenarios · eb3f04d8

Rich Trott authored Mar 02, 2016

`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: https://github.com/nodejs/node/issues/3156
Refs: https://github.com/nodejs/node/commit/c16963b9
PR-URL: https://github.com/nodejs/node/pull/5532


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>

eb3f04d8

tools: reduce verbosity of cpplint · 3eff42bb

Sakthipriyan Vairamani authored Mar 06, 2016

Every time `make test` is run, the cpplint prints the file it
successfully linted. None of the other linters in the project does
that. This patch simply removes the "Done processing" message from the
cpplint.

PR-URL: https://github.com/nodejs/node/pull/5578


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3eff42bb

tools: enable no-self-assign ESLint rule · 810aa9f6

Rich Trott authored Mar 03, 2016

Enabled no-self-assign rule in ESLint.

This required one change in a benchmark file. Changed a loop (that is
outside of the benchmark itself, so performance is not critical) from a
for loop that repeats a string to use String.prototype.repeat() instead.

While at it, took the opportunity to const-ify the benchmark file.

Also moved the "Strict" section in the .eslintrc to match where it is in
the ESLint documentation. Updated the link for Strict rules to point to
the ESLint website rather than the GitHub-hosted code.

PR-URL: https://github.com/nodejs/node/pull/5552


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

810aa9f6

Mar 07, 2016

doc: fix typo in fs.symlink · 44968475

Michaël Zasso authored Mar 04, 2016

PR-URL: https://github.com/nodejs/node/pull/5560


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

44968475

build: update Node.js logo on Win installer · 44c9751f

Robert Jefe Lindstaedt authored Mar 02, 2016

also change stripe color to RGB 68 136 62

PR-URL: https://github.com/nodejs/node/pull/5531


Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

44c9751f

Mar 06, 2016

dgram: default send address to 127.0.0.1 or ::1 · 8af4bb86

Matteo Collina authored Feb 29, 2016

In net we default to 'localhost' as the default address for connect.
Not doing the same on dgram is confusing, because sending to 0.0.0.0
works on Linux/OS X but not on Windows. Defaulting that to 127.0.0.1 /
::1 addresses that.

Related: https://github.com/nodejs/node/pull/5407
Related: https://github.com/nodejs/node/issues/5398
Fixes: https://github.com/nodejs/node/issues/5487
PR-URL: https://github.com/nodejs/node/pull/5493


Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

8af4bb86

Mar 05, 2016

crypto: simplify Certificate class bindings · a37401e0

Alexander Makarenko authored Feb 23, 2016

Replace Certificate C++ class with simple functions. Update
crypto.Certificate methods accordingly.

PR-URL: https://github.com/nodejs/node/pull/5382


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

a37401e0

util: improve format() performance further · c490b8ba

Brian White authored Feb 22, 2016

Replacing the regexp and replace function with a loop improves
performance by ~60-200%.

PR-URL: https://github.com/nodejs/node/pull/5360


Reviewed-By: James M Snell <jasnell@gmail.com>

c490b8ba

util: improve util.format performance · 8d72b0d2

Evan Lucas authored Feb 22, 2016

By manually copying arguments and breaking the try/catch out, we are
able to improve the performance of util.format by 20-100% (depending on
the types).

PR-URL: https://github.com/nodejs/node/pull/5360


Reviewed-By: James M Snell <jasnell@gmail.com>

8d72b0d2

benchmark: add util.format benchmark · 735e0df8

Evan Lucas authored Feb 22, 2016

PR-URL: https://github.com/nodejs/node/pull/5360


Reviewed-By: James M Snell <jasnell@gmail.com>

735e0df8

build: correctly detect clang version · 17924703

Stefan Budeanu authored Mar 03, 2016

Use the "Apple LLVM" version number since the banner has changed in
newer versions of Mac OS X, resulting in the obsolete assembler path
being used to compile OpenSSL.

PR-URL: https://github.com/nodejs/node/pull/5553


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

17924703

Mar 04, 2016

test: bug repro for vm function redefinition · e38e2a60

cjihrig authored Mar 02, 2016

This commit adds a failing test case for the vm module.
Currently, if runInContext() defines a function, and a later call
to runInContext() redefines the same function, the original
function is not overwritten.

Refs: https://github.com/nodejs/node/issues/548
PR-URL: https://github.com/nodejs/node/pull/5528


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

e38e2a60

tools: support testing known issues · 32e1f9d0

cjihrig authored Mar 02, 2016

This commit adds a known_issues directory to the test directory
for scripts that reproduce known bugs. Since these scripts are
expected to fail, it also adds a --expect-fail flag to test.py
which reports tests as successful when they fail.

Refs: https://github.com/nodejs/testing/issues/18
PR-URL: https://github.com/nodejs/node/pull/5528


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

32e1f9d0

src: fix NewInstance deprecation warnings · ad0ce574

Michaël Zasso authored Jan 26, 2016

PR-URL: https://github.com/nodejs/node/pull/4722


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ad0ce574

src: replace usage of deprecated ForceSet · 67b5a8a9

Michaël Zasso authored Feb 08, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

67b5a8a9

deps: upgrade to V8 4.9.385.27 · f8e8075a

Ali Ijaz Sheikh authored Feb 29, 2016

Pick up the latest known good release from the V8 4.9 branch: 4.9.385.27.
V8 Commits: https://github.com/v8/v8/compare/4.9.385.18...4.9.385.27

PR-URL: https://github.com/nodejs/node/pull/5494

Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

f8e8075a

buffer: avoid undefined behaviour · 206a81fb

Ali Ijaz Sheikh authored Feb 29, 2016

Avoid 'delete this' as it can be hazardous and/or dependent on
implementations.

PR-URL: https://github.com/nodejs/node/pull/5494


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

206a81fb

build: do not ignore errors during build-addons · 8cf94006

Ali Ijaz Sheikh authored Feb 29, 2016

Errors during build-addons were being silently ignored.

PR-URL: https://github.com/nodejs/node/pull/5494


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

8cf94006

src: replace deprecated SetWeak in object_wrap · 536cfecd

Ali Ijaz Sheikh authored Feb 29, 2016

Migrate node_object_wrap.h to the new SetWeak API.

PR-URL: https://github.com/nodejs/node/pull/5494


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

536cfecd

src: update uses of deprecated NewExternal · 492fbfbf

Ali Ijaz Sheikh authored Feb 23, 2016

V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to
the alternatives.

PR-URL: https://github.com/nodejs/node/pull/5462


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

492fbfbf

contextify: cache sandbox and context in locals · 66566df5

Ali Ijaz Sheikh authored Feb 24, 2016

PR-URL: https://github.com/nodejs/node/pull/5392


Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

66566df5

contextify: replace deprecated SetWeak usage · 95ebc74a

Ali Ijaz Sheikh authored Feb 22, 2016

PR-URL: https://github.com/nodejs/node/pull/5392


Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

95ebc74a

contextify: cleanup weak ref for sandbox · f7224cac

Ali Ijaz Sheikh authored Feb 22, 2016

Simplify how node_contextify was keeping a weak reference to the
sandbox object in order to prepare for new style phantom weakness V8
API. It is simpler (and more robust) for the context to hold a
reference to the sandbox in an embedder data field. Doing otherwise
meant that the sandbox could become weak while the context was still
alive. This wasn't a problem because we would make the reference
strong at that point.

Since the sandbox must live at least as long as the context, it
would be better for the context to hold onto the sandbox.

PR-URL: https://github.com/nodejs/node/pull/5392


Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

f7224cac

contextify: cleanup weak ref for global proxy · 5737c215

Ali Ijaz Sheikh authored Feb 22, 2016

Cleanup how node_contextify keeps weak references in order to prepare
for new style phantom weakness API. We didn't need to keep a weak
reference to the context's global proxy, as the context holds it.

PR-URL: https://github.com/nodejs/node/pull/5392

Reviewed-By: Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

5737c215

buffer: replace deprecated SetWeak usage · ebbbc5a7

Ali Ijaz Sheikh authored Feb 14, 2016

Old style SetWeak is now deprecated, and weakness now works like
phantom references. This means we no longer have a reference to the
object in the weak callback. We use a kInternalFields style weak
callback which provides us with the contents of 2 internal fields
where we can squirrel away the native buffer pointer.

We can no longer neuter the buffer in the weak callback, but that
should be unnecessary as the object is going to be GC'd during the
current gc cycle.

PR-URL: https://github.com/nodejs/node/pull/5204


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

ebbbc5a7

buffer: cleanup CallbackInfo · 34aac23d

Ali Ijaz Sheikh authored Feb 14, 2016

Dynamic checks that CallbackInfo holds an ArrayBuffer handle can be
converted into compiler enforced checks. Removed unused code, and
other minor cleanup.

PR-URL: https://github.com/nodejs/node/pull/5204


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

34aac23d

src: fix deprecated SetWeak usage in base-object · a45e1f9f

Ali Ijaz Sheikh authored Feb 13, 2016

PR-URL: https://github.com/nodejs/node/pull/5204


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

a45e1f9f

src: replace usage of deprecated SetAccessor · c1649a7e

Ali Ijaz Sheikh authored Feb 12, 2016

PR-URL: https://github.com/nodejs/node/pull/5204


Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

c1649a7e

src: replace deprecated ProcessDebugMessages · cddd5347

Michaël Zasso authored Feb 09, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

cddd5347

src: replace usage of deprecated GetDebugContext · d515a3f4

Michaël Zasso authored Feb 09, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

d515a3f4

src: replace usage of deprecated SetMessageHandler · 4417f994

Michaël Zasso authored Feb 09, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

4417f994

src: replace deprecated CancelTerminateExecution · 8894f274

Michaël Zasso authored Feb 09, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

8894f274

src: replace deprecated TerminateExecution · f50ef1a4

Michaël Zasso authored Feb 09, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

f50ef1a4

src: replace usage of deprecated HasOwnProperty · ac323409

Michaël Zasso authored Feb 08, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

ac323409

src: replace usage of deprecated Has · a7292088

Michaël Zasso authored Feb 08, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

a7292088

src: replace usage of deprecated GetEndColumn · 3d7fd9aa

Michaël Zasso authored Feb 08, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

3d7fd9aa

src: replace usage of deprecated Delete · d45045f3

Michaël Zasso authored Feb 08, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

d45045f3

src: replace usage of deprecated CompileUnbound · 16b0a8c1

Michaël Zasso authored Feb 08, 2016

PR-URL: https://github.com/nodejs/node/pull/5159


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

16b0a8c1