- Apr 10, 2019
-
-
Ruben Bridgewater authored
This verifies that the test actually rejects at this point by using `assert.rejects` instead of `try / catch`. PR-URL: https://github.com/nodejs/node/pull/27123 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruben Bridgewater authored
Use `assert.rejects` to test error cases. This simplifies the test. PR-URL: https://github.com/nodejs/node/pull/27123 Reviewed-By:
-
kohta ito authored
Set the default maxBuffer size to 204,800 bytes for execSync, execFileSync, and spawnSync. APIs that return the child output as a string should have non-infinite defaults for maxBuffer sizes to avoid out-of-memory error conditions. A non-infinite default used to be the documented behaviour for all relevant APIs, but the implemented behaviour for execSync, execFileSync and spawnSync was to have no maxBuffer limits. PR-URL: https://github.com/nodejs/node/pull/23027 Refs: https://github.com/nodejs/node/pull/22894 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
cjihrig authored
The community maintained material hasn't been updated for almost five years, corresponds to Node 0.11, and is no longer accurate. This commit removes the references. PR-URL: https://github.com/nodejs/node/pull/27126 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Mykola Bilochub authored
PR-URL: https://github.com/nodejs/node/pull/27154 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Anna Henningsen authored
This helps with debugging test failures. PR-URL: https://github.com/nodejs/node/pull/27117 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
- Apr 09, 2019
-
-
Sam Roberts authored
Node doesn't use it, and its not documented. Remove it. PR-URL: https://github.com/nodejs/node/pull/27078 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Michael Dawson authored
https://github.com/nodejs/node/pull/24494 fixed a crash but resulted in increased stress on gc finalization. A leak was reported in https://github.com/nodejs/node/issues/26667 which we are still investigating. As part of this investigation I realized we can optimize to reduce amount of deferred finalization. Regardless of the root cause of the leak this should be a good optimization. It also resolves the leak for the case being reported in #26667. The OP in 26667 has confirmed that he can still recreate the original problem that 24494 fixed and that the fix still works with this optimization PR-URL: https://github.com/nodejs/node/pull/27085 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/issues/26435 PR-URL: https://github.com/nodejs/node/pull/26980 Reviewed-By:
-
Ruben Bridgewater authored
This removes a lot of code that has no functionality anymore. All Node.js internal code calls `_resolveLookupPaths` with two arguments. The code that validates `index.js` is not required at all as we check for these files anyway, so it's just redundant code that should be removed. PR-URL: https://github.com/nodejs/node/pull/26983 Refs: https://github.com/nodejs/node/pull/25362 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Sam Roberts authored
DefineCryptoConstants() sets constants from OpenSSL into `crypto.constants`, for crypto and tls. DefineOpenSSLConstants() did exactly the same. Unify them. PR-URL: https://github.com/nodejs/node/pull/27077 Reviewed-By:
-
Sam Roberts authored
EVP_PKEY_CTX_set_rsa_keygen_pubexp() accepts ownership of the exponent on success, so do not free it. Fixes: https://github.com/nodejs/node/issues/27087 PR-URL: https://github.com/nodejs/node/pull/27092 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Michael Dawson authored
This test consistently failed on a system with a large number of cores (~120). Cap the number of concurrent workers so we'll stay consistently within the "slack" allowed with respect to rss. PR-URL: https://github.com/nodejs/node/pull/27090 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
- Apr 08, 2019
-
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/27111 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/27098 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Refael Ackermann authored
* Add 3 Node.js checks * Adjest cpplint.py header rules to Node.js convention Cherry-pick 12c8b4d1 Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Refael Ackermann authored
Refs: https://github.com/cpplint/cpplint/releases/tag/1.4.4 PR-URL: https://github.com/nodejs/node/pull/27098 Reviewed-By:
-
Michaël Zasso authored
This changes the primordials to expose built-in prototypes with their methods already uncurried. The uncurryThis function is therefore moved to the primordials. All uses of uncurryThis on built-ins are changed to import the relevant prototypes from primordials. All uses of Function.call.bind are also changed to use primordials. PR-URL: https://github.com/nodejs/node/pull/27096 Reviewed-By:
-
Tobias Nießen authored
This commit adds support for RSA-PSS keys, including - KeyObjects of type rsa-pss, - key pair generation for RSA-PSS, and - signing and verification using RSA-PSS keys. PR-URL: https://github.com/nodejs/node/pull/26960 Reviewed-By:
-
Ruben Bridgewater authored
This broke due to a recent change that prevents exposing inspect internals. It now relies on the public API instead and should be a bit more robust due to that. PR-URL: https://github.com/nodejs/node/pull/27074 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/27089 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27122 Refs: https://github.com/nodejs/node/commit/7e2088f773d97e00e29cacdc20e1a36b80528be0 Reviewed-By:
-
Rich Trott authored
* Reduce passive voice * Shorter and simpler sentences PR-URL: https://github.com/nodejs/node/pull/27103 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/27101 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the stack trace is not removed due to a wrong stack start function being used. It also fixes the wrong operator caused by the same reason. This only applies in case an validation object was used to validate the rejection passed to `assert.reject()` as first argument. PR-URL: https://github.com/nodejs/node/pull/27047 Reviewed-By:
-
- Apr 07, 2019
-
-
Ruben Bridgewater authored
This increases the maximum buffer size per read to 512kb when using `fs.readFile`. This is important to improve the read performance for bigger files. PR-URL: https://github.com/nodejs/node/pull/27063 Refs: https://github.com/nodejs/node/issues/25741 Reviewed-By:
Jamie Davis <davisjam@vt.edu>
-
cjihrig authored
Coverity reported this. The addr pointer is passed to req_wrap->Dispatch(). By the time this happens, the value that addr points to, addr_storage, is out of scope. This commit remedies that. PR-URL: https://github.com/nodejs/node/pull/27070 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
Rich Trott authored
The benchmarks for dns.lookup() include calling it with an empty hostname which results in a deprecation warning. This benchmark seems to be subject to some odd side effects (see Ref below) and we probably generally don't want to benchmark deprecated things by default anyway. Remove the deprecated value from the default list. Bonus is that this will speed up the benchmark. Refs: https://github.com/nodejs/node/pull/27081#issuecomment-479981874 PR-URL: https://github.com/nodejs/node/pull/27091 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/27105 Reviewed-By:
-
Kat Marchán authored
Co-authored-by:
Myles Borins <mylesborins@google.com> PR-URL: https://github.com/nodejs/node/pull/26244 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Currently, the test creates a file in the cwd and doesn't clean it up. Use a temporary directory instead. PR-URL: https://github.com/nodejs/node/pull/27088 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/19691 Reviewed-By:
-
- Apr 06, 2019
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/27083 Reviewed-By:
-
Joyee Cheung authored
This patch removes the redundant `require-globals` custom eslint rule by removing `env: node` in the eslint config and whitelist the globals that can be accessed in native modules instead of black listing them. This makes sense for our `lib/` files because here we are creating the Node.js environment instead of running in a normal user land Node.js environment. PR-URL: https://github.com/nodejs/node/pull/27082 Reviewed-By:
-
Joyee Cheung authored
This patch moves the serialization of coverage profiles into C++. With this we no longer need to patch `process.reallyExit` and hook into the exit events, but instead hook into relevant places in C++ which are safe from user manipulation. This also makes the code easier to reuse for other types of profiles. PR-URL: https://github.com/nodejs/node/pull/26874 Reviewed-By:
Ben Coe <bencoe@gmail.com>
-
Gabriel Schulhof authored
Add test coverage for these N-APIs. PR-URL: https://github.com/nodejs/node/pull/26947 Reviewed-By:
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/27072 Reviewed-By:
-
Rich Trott authored
* Active voice * Remove Node.js Foundation mention. It may be appropriate to add something back in when the new foundation is bootstrapped. We don't control membership criteria, so best to link to something else when it becomes available rather than make guarantees in this doc. PR-URL: https://github.com/nodejs/node/pull/27071 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
- Apr 05, 2019
-
-
gengjiawen authored
* add filter to not lint NOLINT rules PR-URL: https://github.com/nodejs/node/pull/26884 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/7.4.288.17...7.4.288.18 PR-URL: https://github.com/nodejs/node/pull/27066 Refs: https://github.com/v8/v8/compare/7.4.288.13...7.4.288.17 Reviewed-By:
-
