Commits · 38aa7cc7c7ea644c8d60859880f69a98f7159ffa · github.com / v8-riscv / node

Oct 16, 2021

src: get embedder options on-demand · 38aa7cc7

Joyee Cheung authored Oct 07, 2021

Only query embedder options when they are needed so that the bootstrap
remains as stateless as possible so that the bootstrap snapshot is
controlled solely by configure options, and subsequent runtime changes
should be done in pre-execution.

PR-URL: https://github.com/nodejs/node/pull/40357


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>

38aa7cc7

build: avoid run find inactive authors on forked repo · 6baea145

Jiawen Geng authored Oct 15, 2021

PR-URL: https://github.com/nodejs/node/pull/40465


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

6baea145

Oct 15, 2021

src: ensure V8 initialized before marking milestone · ad4e70c8

Shelley Vohr authored Oct 11, 2021

PR-URL: https://github.com/nodejs/node/pull/40405
Refs: https://github.com/electron/electron/pull/31349


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

ad4e70c8

meta: consolidate AUTHORS entries for ebickle · 881174e0

Rich Trott authored Oct 13, 2021

PR-URL: https://github.com/nodejs/node/pull/40447


Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

881174e0

doc: update Collaborator guide to reflect GitHub web UI update · a278117f

Antoine du Hamel authored Oct 14, 2021

PR-URL: https://github.com/nodejs/node/pull/40456


Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

a278117f

Oct 14, 2021

deps: patch V8 to 9.5.172.21 · bf82dcd5

Michaël Zasso authored Oct 12, 2021

Refs: https://github.com/v8/v8/compare/9.5.172.19...9.5.172.21

PR-URL: https://github.com/nodejs/node/pull/40432


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

bf82dcd5

meta: add `typings` to label-pr-config · b80b85e1

Mestery authored Oct 10, 2021

PR-URL: https://github.com/nodejs/node/pull/40401


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

b80b85e1

deps: V8: make V8 9.5 ABI-compatible with 9.6 · 795108a6

Michaël Zasso authored Oct 12, 2021

Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: https://github.com/v8/v8/commit/ab836859d964d03ec43de9e7d0096c4ebf6ab64c

[zone] Provide a way to configure allocator for zone backings
Refs: https://github.com/v8/v8/commit/e262e1cb4a0f9ab0051eb981a01dc1e66c0b4125

[isolate-data] Consistent field names
Needed for the next commit.
Refs: https://github.com/v8/v8/commit/d09fc5403aaa7ce18d01d79da067ebc2408d18ed

[isolate-data] Split builtin tables into tiers
Refs: https://github.com/v8/v8/commit/06af754cea8006e0a802655250c129dc8e9cdce0

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: https://github.com/v8/v8/commit/1fd55617e15b07b0b939d795db16dd07a7656e85

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: https://github.com/v8/v8/commit/b66d5f023315160623b17d8ee686f26a82ae374b

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: https://github.com/v8/v8/commit/dc88bdf35ea708bf6ff7ab7816d2fc554ae902a1

PR-URL: https://github.com/nodejs/node/pull/40422


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

795108a6

build: include new public V8 headers in distribution · f9996d5b

Michaël Zasso authored Oct 12, 2021

v8.h was split into a multitude of smaller headers.

Refs: https://github.com/nodejs/node/issues/39876

PR-URL: https://github.com/nodejs/node/pull/40423


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

f9996d5b

src: add flags for controlling process behavior · 3b72788a

Cheng Zhao authored Oct 06, 2021

PR-URL: https://github.com/nodejs/node/pull/40339


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

3b72788a

doc: indicate n-api out params that may be NULL · 4cf55631

Isaac Brodsky authored Oct 07, 2021

This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879

PR-URL: https://github.com/nodejs/node/pull/40371

Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

4cf55631

meta: consolidate AUTHORS entries for evantorrie · 95cf9447

Rich Trott authored Oct 12, 2021

Add a .mailmap entry for evantorrie to consolidate their two AUTHORS
entries into one.

PR-URL: https://github.com/nodejs/node/pull/40430


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

95cf9447

build: compile with C++17 (MSVC) · 9dfa30bd

Richard Lau authored Sep 03, 2021

PR-URL: https://github.com/nodejs/node/pull/38807
Refs: https://github.com/nodejs/node/pull/38788


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>

9dfa30bd

deps: workaround debug link error on Windows · 228e703d

Richard Lau authored Sep 30, 2021

PR-URL: https://github.com/nodejs/node/pull/38807
Refs: https://github.com/nodejs/node/pull/38788


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>

228e703d

build: compile with --gnu++17 · 9f0bc602

Richard Lau authored May 25, 2021

Enables C++17 features.

PR-URL: https://github.com/nodejs/node/pull/38807
Refs: https://github.com/nodejs/node/pull/38788


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>

9f0bc602

Oct 13, 2021

tools: update lint-md dependencies · 350a95b8

Rich Trott authored Oct 10, 2021

Update lint-md dependencies and re-create lint-md.mjs.

PR-URL: https://github.com/nodejs/node/pull/40404


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

350a95b8

build: update codeowners-validator to 0.6 · 983b757f

FrankQiu authored Oct 04, 2021

PR-URL: https://github.com/nodejs/node/pull/40307


Reviewed-By: Mary Marchini <oss@mmarchini.me>

983b757f

net: check if option is undefined · f5701090

Daijiro Wachi authored Oct 08, 2021

PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

f5701090

test: replace common port with specific number · e0faf8c3

Daijiro Wachi authored Oct 07, 2021

PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

e0faf8c3

net: remove unused ObjectKeys · 119558b6

Daijiro Wachi authored Oct 07, 2021



Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

119558b6

net: check objectMode first and then readble || writable · c7cd8ef6

Daijiro Wachi authored Oct 07, 2021



Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/40344
Fixes: https://github.com/nodejs/node/issues/40336


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

c7cd8ef6

net: throw error to object mode in Socket · 46446623

Daijiro Wachi authored Oct 07, 2021

Fixes: https://github.com/nodejs/node/issues/40336

PR-URL: https://github.com/nodejs/node/pull/40344


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

46446623

meta: consolidate AUTHORS entries for gabrielschulhof · c350c217

Rich Trott authored Oct 11, 2021

PR-URL: https://github.com/nodejs/node/pull/40420


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

c350c217

Oct 12, 2021

2021-10-12, Version 16.11.1 (Current) · 9fcc84d0

Danielle Adams authored Oct 11, 2021

This is a security release.

Notable Changes:

* CVE-2021-22959: HTTP Request Smuggling due to spaced in headers (Medium)
  * The http parser accepts requests with a space (SP) right after the
  header name before the colon. This can lead to HTTP Request Smuggling
  (HRS). More details are available at:
  https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22959
* CVE-2021-22960: HTTP Request Smuggling when parsing the body (Medium)
  * The parse ignores chunk extensions when parsing the body of chunked
  requests. This leads to HTTP Request Smuggling (HRS) under certain
  conditions. More details are available at:
  https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22960

PR-URL: https://github.com/nodejs-private/node-private/pull/293

9fcc84d0

2021-10-12, Version 14.18.1 'Fermium' (LTS) · df3b4cc9

Danielle Adams authored Oct 11, 2021

This is a security release.

Notable Changes:

* CVE-2021-22959: HTTP Request Smuggling due to spaced in headers (Medium)
  * The http parser accepts requests with a space (SP) right after the
  header name before the colon. This can lead to HTTP Request Smuggling
  (HRS). More details are available at:
  https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22959
* CVE-2021-22960: HTTP Request Smuggling when parsing the body (Medium)
  * The parse ignores chunk extensions when parsing the body of chunked requests.
  requests. This leads to HTTP Request Smuggling (HRS) under certain conditions.
  More details are available at:
  https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22960

PR-URL: https://github.com/nodejs-private/node-private/pull/294

df3b4cc9

2021-10-12, Version 12.22.7 'Erbium' (LTS) · 52b613ab

Danielle Adams authored Oct 11, 2021

This is a security release.

Notable changes:

* CVE-2021-22959: HTTP Request Smuggling due to spaced in headers (Medium)
  * The http parser accepts requests with a space (SP) right after the
  header name before the colon. This can lead to HTTP Request Smuggling
  (HRS). More details are available at:
  https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22959
* CVE-2021-22960: HTTP Request Smuggling when parsing the body (Medium)
  * The parse ignores chunk extensions when parsing the body of chunked
  requests. This leads to HTTP Request Smuggling (HRS) under certain
  conditions. More details are available at:
  https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22960

PR-URL: https://github.com/nodejs-private/node-private/pull/295

52b613ab

http: add regression test for smuggling content length · 7beff4de

Matteo Collina authored Aug 25, 2021

PR-URL: https://github.com/nodejs-private/node-private/pull/284


Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

7beff4de

http: add regression test for chunked smuggling · 2978b5a4

Matteo Collina authored Aug 25, 2021

PR-URL: https://github.com/nodejs-private/node-private/pull/284


Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

2978b5a4

deps: update llhttp to 6.0.4 · c2e3f85d

Matteo Collina authored Aug 25, 2021

Refs: https://hackerone.com/reports/1238099
Refs: https://hackerone.com/reports/1238709
Refs: https://github.com/nodejs-private/llhttp-private/pull/6
Refs: https://github.com/nodejs-private/llhttp-private/pull/5
CVE-ID: CVE-2021-22959
CVE-ID: CVE-2021-22960

PR-URL: https://github.com/nodejs-private/node-private/pull/284


Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

c2e3f85d

test: adapt test-repl to V8 9.5 · 842fd234

Michaël Zasso authored Aug 29, 2021

Syntax errors for RegExp literals now show hint to error location.

PR-URL: https://github.com/nodejs/node/pull/40178


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

842fd234

test: remove test-v8-untrusted-code-mitigations · d7b9b9f8

Ross McIlroy authored Jul 22, 2021

Untrusted code mitigations have now been removed from V8.

PR-URL: https://github.com/nodejs/node/pull/40178


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

d7b9b9f8

tools: update V8 gypfiles for 9.5 · 1fd98458

Michaël Zasso authored Aug 21, 2021

PR-URL: https://github.com/nodejs/node/pull/40178


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1fd98458

deps: V8: cherry-pick 2a0bc36dec12 · c9296b19

Michaël Zasso authored Oct 11, 2021

Original commit message:

    [parser] Fix the MSVC build

    MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString
    method despite it being unused. This CL adds an (unreachable)
    definition for it.

    Bug: v8:12266
    Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856


Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77313}

Refs: https://github.com/v8/v8/commit/2a0bc36dec121c9f30e3c18e8ed1f0d0b4f2ed7c

PR-URL: https://github.com/nodejs/node/pull/40178


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

c9296b19

deps: V8: cherry-pick cf21eb36b975 · 5b358370

Michaël Zasso authored Oct 02, 2021

Original commit message:

    [baseline] Skip deoptimization data size

    Sparkplug code does not contain deoptimization data.

    Bug: v8:12258
    Change-Id: Ieb9f7f1469e00677d9533c6f05b17c80ef06b9d6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3175820


    Commit-Queue: Victor Gomes <victorgomes@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76997}

Refs: https://github.com/v8/v8/commit/cf21eb36b975d0c4a1d739aa9675a14beca2d392

PR-URL: https://github.com/nodejs/node/pull/40178


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

5b358370

deps: V8: patch jinja2 for Python 3.10 compat · 6b403834

Michaël Zasso authored Oct 05, 2021

PR-URL: https://github.com/nodejs/node/pull/40296
Fixes: https://github.com/nodejs/node/issues/40294


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

6b403834

deps: silence irrelevant V8 warning · 0d02e89e

Michaël Zasso authored May 01, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

0d02e89e

deps: silence irrelevant V8 warnings · 678d671f

Michaël Zasso authored Jan 30, 2021

PR-URL: https://github.com/nodejs/node/pull/37587


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

678d671f

deps: fix V8 build issue with inline methods · 1b686678

Jiawen Geng authored Oct 14, 2020

PR-URL: https://github.com/nodejs/node/pull/35415


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

deps: patch for v8 on windows

PR-URL: https://github.com/nodejs/node/pull/40010


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

deps: patch v8 for vs2019 in std17

PR-URL: https://github.com/nodejs/node/pull/40060


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

1b686678

deps: make v8.h compatible with VS2015 · ef93689b

Joao Reis authored Sep 22, 2021

There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693

PR-URL: https://github.com/nodejs/node/pull/32116


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ef93689b

deps: V8: forward declaration of `Rtl*FunctionTable` · b2c52469

Refael Ackermann authored May 22, 2019

This should be semver-patch since actual invocation is version
conditional.

PR-URL: https://github.com/nodejs/node/pull/32116


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

b2c52469