- Feb 13, 2013
-
-
Dan Kohn authored
Running repl.start without the prompt set produces this error: repl.js:95 throw new Error('An options Object, or a prompt String are required'); ^ Error: An options Object, or a prompt String are required at new REPLServer (repl.js:95:11) at Object.exports.start (repl.js:321:14) at Object.<anonymous> (/Users/dan/Dropbox/Documents/dev/nextgen/repl_test.js:5:6) at Module._compile (module.js:449:26) at Object.Module._extensions..js (module.js:467:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.runMain (module.js:492:10) at process.startup.processNextTick.process._tickCallback (node.js:244:9) -
isaacs authored
-
isaacs authored
Thanks, @domenic
-
- Feb 08, 2013
-
-
Ben Noordhuis authored
It's not a good citizen, it spams random IP addresses with UDP packets. Fixes #4730.
-
isaacs authored
-
isaacs authored
-
- Feb 07, 2013
-
-
Bert Belder authored
This patch is a back-port of 3c293ba2. Closes #4696
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
* npm: Upgrade to v1.2.10 * zlib: pass object size hint to V8 (Ben Noordhuis) * zlib: reduce memory consumption, release early (Ben Noordhuis) * buffer: slow buffer copy compatibility fix (Trevor Norris) * zlib: don't assert on malformed dictionary (Ben Noordhuis) * zlib: don't assert on missing dictionary (Ben Noordhuis) * windows: better ipv6 support (Bert Belder) * windows: add error mappings related to unsupported protocols (Bert Belder) * windows: map ERROR_DIRECTORY to UV_ENOENT (Bert Belder)
-
isaacs authored
-
- Feb 06, 2013
-
-
Ben Noordhuis authored
Fixes #4716.
-
Ben Noordhuis authored
Inform V8 that the zlib context object is tied to a large off-heap buffer. This makes the GC run more often (in theory) and improves the accuracy of --trace_external_memory.
-
Ben Noordhuis authored
In zlibBuffer(), don't wait for the garbage collector to reclaim the zlib memory but release it manually. Reduces memory consumption by a factor of 10 or more with some workloads. Test case: function f() { require('zlib').deflate('xxx', g); } function g() { setTimeout(f, 5); } f(); Observe RSS memory usage with and without this commit. After 10,000 iterations, RSS stabilizes at ~35 MB with this commit. Without, RSS is over 300 MB and keeps growing. Cause: whenever the JS object heap hits the high-water mark, the V8 GC sweeps it clean, then tries to grow it in order to avoid more sweeps in the near future. Rule of thumb: the bigger the JS heap, the lazier the GC can be. A side effect of a bigger heap is that objects now live longer. This is harmless in general but it affects zlib context objects because those are tied to large buffers that live outside the JS heap, on the order of 16K per context object. Ergo, don't wait for the GC to reclaim the memory - it may take a long time. Fixes #4172.
-
- Feb 05, 2013
-
-
Ben Noordhuis authored
Using Socket.prototype.connect() to reconnect an existing Socket object is not reliable. Users should just create a new Socket object. See #4698.
-
- Feb 03, 2013
-
-
isaacs authored
-
- Jan 31, 2013
-
-
Bert Belder authored
-
- Jan 27, 2013
-
-
Rick Yakubowski authored
Fix a small typo in the cluster.settings documentation.
-
- Jan 26, 2013
-
-
Trevor Norris authored
Fix issue where SlowBuffers couldn't be passed as target to Buffer copy(). Also included checks to see if Argument parameters are defined before assigning their values. This offered ~3x's performance gain. Backport of 16bbeccd from master branch. Closes #4633.
-
- Jan 25, 2013
-
-
isaacs authored
-
Jacob Gable authored
Added the word 'has' to the sentence. Closes #4652.
-
isaacs authored
-
- Jan 22, 2013
-
-
Ben Noordhuis authored
-
Ben Noordhuis authored
Handle Z_DATA_ERROR errors from inflateSetDictionary() gracefully. Fixes the following assertion: node: ../src/node_zlib.cc:167: static void node::ZCtx::Process (uv_work_t*): Assertion `ctx->err_ == 0 && "Failed to set dictionary"' failed. Aborted (core dumped) Fixes #4632.
-
Ben Noordhuis authored
Handle Z_NEED_DICT errors graciously. Fixes the following assertion: node: ../src/node_zlib.cc:161: static void node::ZCtx::Process (uv_work_t*): Assertion`ctx->dictionary_ != __null && "Stream has no dictionary"' failed. Aborted (core dumped) Fixes #4632.
-
- Jan 19, 2013
-
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
* npm: Upgrade to v1.2.2 * dns: make error message match errno (Dan Milon) * tls: follow RFC6125 more stricly (Fedor Indutny) * buffer: reject negative SlowBuffer offsets (Ben Noordhuis) * install: add simplejson fallback (Chris Dent) * http: fix "Cannot call method 'emit' of null" (Ben Noordhuis)
-
isaacs authored
-
isaacs authored
-
- Jan 18, 2013
-
-
Dan Milon authored
-
Fedor Indutny authored
* Allow wildcards only in left-most part of hostname identifier. * Do not match CN if altnames are present
-
Fedor Indutny authored
This reverts commit 30e23704. Works properly with b4b750b6
-
- Jan 17, 2013
-
-
Ben Noordhuis authored
This reverts commit 45024e7b. It's making test/simple/test-tls-check-server-identity.js fail: AssertionError: Test#4 failed: { host: 'b.a.com', cert: { subject: { CN: '*.a.com' } }, result: false } at <omitted>/test/simple/test-tls-check-server-identity.js:201:10
-
Ben Noordhuis authored
This test starts two clustered HTTP servers on the same port. It expects the first cluster to succeed and the second cluster to fail with EADDRINUSE. Reapplies commit cacd3ae0, accidentally reverted in a2851b62.
-
Ben Noordhuis authored
Reject negative offsets in SlowBuffer::MakeFastBuffer(), it allows the creation of buffers that point to arbitrary addresses. Reported by Trevor Norris.
-
- Jan 15, 2013
-
-
Chris Dent authored
Make tools/install.py work with python 2.5 2.5 is still fairly widespread and does not include a json lib as standard. Most python folk will have simplejson if they are in that boat. In general it seems a bit tricky to solve this perfectly...
-
Bert Belder authored
-