1. Feb 13, 2013
    • Dan Kohn's avatar
      doc: add prompt to fix repl_test.js example · 2e1ebbf2
      Dan Kohn authored
      Running repl.start without the prompt set produces this error:
      
      repl.js:95
          throw new Error('An options Object, or a prompt String are required');
                ^
      Error: An options Object, or a prompt String are required
          at new REPLServer (repl.js:95:11)
          at Object.exports.start (repl.js:321:14)
          at Object.<anonymous> (/Users/dan/Dropbox/Documents/dev/nextgen/repl_test.js:5:6)
          at Module._compile (module.js:449:26)
          at Object.Module._extensions..js (module.js:467:10)
          at Module.load (module.js:356:32)
          at Function.Module._load (module.js:312:12)
          at Module.runMain (module.js:492:10)
          at process.startup.processNextTick.process._tickCallback (node.js:244:9)
      2e1ebbf2
    • isaacs's avatar
      blog: Forgot slug on peer-dependencies article · 82ad5fbe
      isaacs authored
      82ad5fbe
    • isaacs's avatar
      blog: Peer Dependencies article · 6dcadb9f
      isaacs authored
      Thanks, @domenic
      6dcadb9f
  2. Feb 08, 2013
  3. Feb 07, 2013
  4. Feb 06, 2013
    • Ben Noordhuis's avatar
      blog: remove dangling symlink · a86ebbe2
      Ben Noordhuis authored
      Fixes #4716.
      a86ebbe2
    • Ben Noordhuis's avatar
      zlib: pass object size hint to V8 · 6b99fd23
      Ben Noordhuis authored
      Inform V8 that the zlib context object is tied to a large off-heap buffer.
      
      This makes the GC run more often (in theory) and improves the accuracy of
      --trace_external_memory.
      6b99fd23
    • Ben Noordhuis's avatar
      zlib: reduce memory consumption, release early · 8d146689
      Ben Noordhuis authored
      In zlibBuffer(), don't wait for the garbage collector to reclaim the zlib memory
      but release it manually. Reduces memory consumption by a factor of 10 or more
      with some workloads.
      
      Test case:
      
        function f() {
          require('zlib').deflate('xxx', g);
        }
        function g() {
          setTimeout(f, 5);
        }
        f();
      
      Observe RSS memory usage with and without this commit. After 10,000 iterations,
      RSS stabilizes at ~35 MB with this commit. Without, RSS is over 300 MB and keeps
      growing.
      
      Cause: whenever the JS object heap hits the high-water mark, the V8 GC sweeps
      it clean, then tries to grow it in order to avoid more sweeps in the near
      future. Rule of thumb: the bigger the JS heap, the lazier the GC can be.
      
      A side effect of a bigger heap is that objects now live longer. This is harmless
      in general but it affects zlib context objects because those are tied to large
      buffers that live outside the JS heap, on the order of 16K per context object.
      
      Ergo, don't wait for the GC to reclaim the memory - it may take a long time.
      
      Fixes #4172.
      8d146689
  5. Feb 05, 2013
  6. Feb 03, 2013
  7. Jan 31, 2013
  8. Jan 27, 2013
  9. Jan 26, 2013
    • Trevor Norris's avatar
      buffer: slow buffer copy compatibility fix · 65249ccd
      Trevor Norris authored
      Fix issue where SlowBuffers couldn't be passed as target to Buffer
      copy().
      
      Also included checks to see if Argument parameters are defined before
      assigning their values. This offered ~3x's performance gain.
      
      Backport of 16bbeccd from master branch. Closes #4633.
      65249ccd
  10. Jan 25, 2013
  11. Jan 22, 2013
    • Ben Noordhuis's avatar
      doc: document PYTHON env var in README · 13d86a86
      Ben Noordhuis authored
      13d86a86
    • Ben Noordhuis's avatar
      zlib: don't assert on malformed dictionary · d7bf7ed9
      Ben Noordhuis authored
      Handle Z_DATA_ERROR errors from inflateSetDictionary() gracefully.
      Fixes the following assertion:
      
        node: ../src/node_zlib.cc:167: static void node::ZCtx::Process
        (uv_work_t*): Assertion `ctx->err_ == 0 && "Failed to set
        dictionary"' failed.
        Aborted (core dumped)
      
      Fixes #4632.
      d7bf7ed9
    • Ben Noordhuis's avatar
      zlib: don't assert on missing dictionary · 1c32eb4a
      Ben Noordhuis authored
      Handle Z_NEED_DICT errors graciously. Fixes the following assertion:
      
        node: ../src/node_zlib.cc:161: static void node::ZCtx::Process
        (uv_work_t*): Assertion`ctx->dictionary_ != __null && "Stream
        has no dictionary"' failed.
        Aborted (core dumped)
      
      Fixes #4632.
      1c32eb4a
  12. Jan 19, 2013
  13. Jan 18, 2013
  14. Jan 17, 2013
    • Ben Noordhuis's avatar
      Revert "tls: allow wildcards in common name" · 30e23704
      Ben Noordhuis authored
      This reverts commit 45024e7b.
      
      It's making test/simple/test-tls-check-server-identity.js fail:
      
        AssertionError: Test#4 failed: { host: 'b.a.com',
          cert: { subject: { CN: '*.a.com' } },
          result: false }
            at <omitted>/test/simple/test-tls-check-server-identity.js:201:10
      30e23704
    • Ben Noordhuis's avatar
      test: add cluster 'bind twice' test · 08ac9fe0
      Ben Noordhuis authored
      This test starts two clustered HTTP servers on the same port.
      It expects the first cluster to succeed and the second cluster
      to fail with EADDRINUSE.
      
      Reapplies commit cacd3ae0, accidentally reverted in a2851b62.
      08ac9fe0
    • Ben Noordhuis's avatar
      buffer: reject negative SlowBuffer offsets · 498200b8
      Ben Noordhuis authored
      Reject negative offsets in SlowBuffer::MakeFastBuffer(), it allows
      the creation of buffers that point to arbitrary addresses.
      
      Reported by Trevor Norris.
      498200b8
  15. Jan 15, 2013