- Jun 25, 2020
-
-
Robert Nagy authored
Adds a test to ensure that 'finish' is emitted before the socket is destroyed by allow half-open enforcer. Refs: https://github.com/nodejs/node/commit/3c07b1793cfe12a7cebc3a0e3e3c3fd2b60a3560#commitcomment-38810268 PR-URL: https://github.com/nodejs/node/pull/33137 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/pull/33949#discussion_r442473532 Signed-off-by:
Denys Otrishko <shishugi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33951 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Yash Ladha authored
We already importing the validator for integer check. So leveraging the boolean check validator to remove already defined logic in the code and thus making it DRY. PR-URL: https://github.com/nodejs/node/pull/33731 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
PR-URL: https://github.com/nodejs/node/pull/34007 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
Since 7dead844, there is a more official alternative that is tested and comes with a proper API, and since a6c57cc6, the `LoadEnvironment(env)` overload is deprecated, which is the closest thing we can achieve to deprecating `_third_party_main` support. Thus, we can now consider us able to remove `_third_party_main` support. Fixes: https://github.com/nodejs/node/issues/24017 Refs: https://github.com/nodejs/node/pull/30467 Refs: https://github.com/nodejs/node/pull/32858 PR-URL: https://github.com/nodejs/node/pull/33971 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Denys Otrishko authored
Previously Node.js would handle empty `net.connect()` and `socket.connect()` call as if the user passed empty options object which doesn't really make sense. This was due to the fact that it uses the same `normalizeArgs` function as `.listen()` call where such call is perfectly fine. This will make it clear what is the problem with such call and how it can be resolved. It now throws `ERR_MISSING_ARGS` if no arguments were passed or neither `path` nor `port` is specified. Fixes: https://github.com/nodejs/node/issues/33930 PR-URL: https://github.com/nodejs/node/pull/34022 Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Denys Otrishko authored
This makes ERR_MISSING_ARGS handle nested arrays in argument names as one-of case and will print them as '"arg1" or "arg2" or "arg3"'. Example: ```js throw new ERR_MISSING_ARGS(['a', 'b', 'c']); // will result in message: // The "a" or "b" or "c" argument must be specified ``` PR-URL: https://github.com/nodejs/node/pull/34022 Fixes: https://github.com/nodejs/node/issues/33930 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
James M Snell authored
The dual stack support is currently broken as the QuicSocket endpoints are not properly accounting for all cases. Needs to be investigated further. PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
The ngtcp2 update uses a gcc builtin that is not available under _MSC_VER. This floats a patch to fix it. Upstream PR: https://github.com/ngtcp2/ngtcp2/pull/247 PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
Tatsuhiro Tsujikawa authored
Original Commit Message: Fix out-of-bounds read when TLS msg is split up into multiple chunks Previously, SSL_provide_quic_data tried to handle this kind of situation, but it failed when the length of input data is less than SSL3_HM_HEADER_LENGTH. If that happens, the code might get wrong message length by reading value from out-of-bounds region. PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
Benjamin Kaduk authored
Original Commit Message: Test KeyUpdate rejection For now, just test that we don't generate any, since we don't really expose the mechanics for encrypting one and the QUIC API is not integrated into the TLSProxy setup. PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
Benjamin Kaduk authored
Original Commit Message: Prevent KeyUpdate for QUIC QUIC does not use the TLS KeyUpdate message/mechanism, and indeed it is an error to generate or receive such a message. Add the necessary checks (noting that the check for receipt should be redundant since SSL_provide_quic_data() is the only way to provide input to the TLS layer for a QUIC connection). PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
Benjamin Kaduk authored
Original Commit Message: Some cleanup for the main QUIC changes Try to reduce unneeded whitespace changes and wrap new code to 80 columns. Reword documentation to attempt to improve clarity. Add some more sanity checks and clarifying comments to the code. Update referenced I-D versions. PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34033 Reviewed-By:
-
- Jun 24, 2020
-
-
Gerhard Stoebich authored
This adds a test to verify that AsyncLocalStorage works with thenables. PR-URL: https://github.com/nodejs/node/pull/34008 Refs: https://github.com/nodejs/node/pull/33778 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
-
Anna Henningsen authored
As indicated in the added comment, this can lead to a deadlock otherwise. In the concrete instance in which I encountered this, the relevant nested call is the one to `require('internal/tty')` inside of the `afterInspector()` function for uncaught exception handling. PR-URL: https://github.com/nodejs/node/pull/33980 Reviewed-By:David Carlier <devnexen@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/34030 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/33782 PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
James M Snell authored
Co-authored-by:
-
James M Snell authored
Co-authored-by:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Benjamin Gruenbaum authored
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: https://github.com/nodejs/node/pull/33613 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Zirak authored
On the web, dispatchEvent is finicky about its `this` value. An exception is thrown for `this` values which are not an EventTarget. PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Benjamin Gruenbaum authored
Remove support for multiple arguments (which don't actually work for EventTarget). Use our EventTarget implementation rather than a mock. Refactor `once` code in preparation of `on` using shared code for supporting `on` with `EventTarget`s. Support EventTarget in the `events.on` static method PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34015 Reviewed-By:
-
Mateusz Krawczuk authored
PR-URL: https://github.com/nodejs/node/pull/33983 Reviewed-By:
-
Gabriel Schulhof authored
Document that it is not necessary to open handle and/or callback scopes inside finalizer, async work, thread-safe function etc. callbacks unless for reasons documented in the section about object lifetime management. Link usage of callback signatures to their definition. Fixes: https://github.com/nodejs/node/issues/33893 PR-URL: https://github.com/nodejs/node/pull/33915 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Rich Trott authored
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: https://github.com/nodejs/node/pull/33998 Reviewed-By:
Jamie Davis <davisjam@vt.edu>
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/33871 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Evan Lucas authored
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: https://github.com/nodejs/node/pull/33793 Reviewed-By:
-
- Jun 23, 2020
-
-
Rich Trott authored
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: https://github.com/nodejs/node/pull/33999 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
