- Apr 02, 2020
-
-
Anna Henningsen authored
… and move them to `IsolateData`, because they should exist once per Isolate. PR-URL: https://github.com/nodejs/node/pull/32572 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Anna Henningsen authored
I’ve seen this fail a few times in CI, presumably because the inspector commmand did not reach the child thread in time. Explicitly waiting seems to solve that. Refs: https://github.com/nodejs/node/pull/30467 PR-URL: https://github.com/nodejs/node/pull/32563 Reviewed-By:
-
Anna Henningsen authored
The JSONWriter feature is not inherently related to the report feature in any way. As a drive-by fix, remove a number of unused header includes. PR-URL: https://github.com/nodejs/node/pull/32552 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Anna Henningsen authored
Class names are written in UpperCamelCase. Otherwise, this looks like it’s a variable, not a class name. PR-URL: https://github.com/nodejs/node/pull/32539 Reviewed-By:
-
Anna Henningsen authored
This makes sense given that terminating execution of the parent thread this way likely also is supposed to stop all running Worker threads spawned by it. PR-URL: https://github.com/nodejs/node/pull/32531 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
Embedders may not want to terminate the process when `process.exit()` is called. This provides a hook for more flexible handling of that situation. Refs: https://github.com/nodejs/node/pull/30467#issuecomment-603689644 PR-URL: https://github.com/nodejs/node/pull/32531 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32503 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Alex R authored
For keep-alive connections, the headersTimeout may fire during subsequent request because the measurement was reset after a request and not before a request. PR-URL: https://github.com/nodejs/node/pull/32329 Fixes: https://github.com/nodejs/node/issues/27363 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Anna Henningsen authored
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: https://github.com/nodejs/node/pull/32546 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32548 Reviewed-By:
-
Myles Borins authored
Moved emeritus members keys and fixed alphabetization issues PR-URL: https://github.com/nodejs/node/pull/32577 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz $ mv openssl-1.1.0h openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By: -
Myles Borins authored
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: https://github.com/nodejs/node/issues/29802 PR-URL: https://github.com/nodejs/node/pull/32595 Reviewed-By:
-
Matheus Marchini authored
While landing the upgrade to V8 8.1, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. Revert those changes to fix our tests. PR-URL: https://github.com/nodejs/node/pull/32587 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
- Apr 01, 2020
-
-
Myles Borins authored
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: https://github.com/nodejs/node/issues/26401 PR-URL: https://github.com/nodejs/node/pull/32589 Reviewed-By:
-
Robert Nagy authored
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: https://github.com/nodejs/node/issues/32486#issuecomment-604072559 PR-URL: https://github.com/nodejs/node/pull/32491 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32436 Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/32351 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
cjihrig authored
This commit runtime deprecates calling process.umask() with no arguments. PR-URL: https://github.com/nodejs/node/pull/32499 Fixes: https://github.com/nodejs/node/issues/32321 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
cjihrig authored
This commit introduces a documentation deprecation for calling process.umask() with no arguments. PR-URL: https://github.com/nodejs/node/pull/32499 Fixes: https://github.com/nodejs/node/issues/32321 Reviewed-By:
-
Richard Lau authored
Refactor the logic for working out the previous versions of Node.js for the API documentation so that the parsing (including the potential https get) happens at most once per build (as opposed to the current once per generated API doc). Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
Replace magic numbers with constant. Use for loop for repeated code. Reduce console logging. Remove unneeded countdown module use. PR-URL: https://github.com/nodejs/node/pull/32547 Reviewed-By:
-
Sam Roberts authored
Follow on to https://github.com/nodejs/node/pull/32207, 3 other options are also not respected under situations that the isolate is not available. PR-URL: https://github.com/nodejs/node/pull/32497 Reviewed-By:
-
Gabriel Schulhof authored
Replace the portion of the context-aware addon example that advocates for managing the life cycle of the per-addon-instance data using a weak reference with code that illustrates how to manage its life cycle using an environment cleanup hook. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/28659 Reviewed-By:
-
- Mar 31, 2020
-
-
James M Snell authored
Signed-off-by:
-
- Mar 30, 2020
-
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31797 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
murgatroid99 authored
PR-URL: https://github.com/nodejs/node/pull/32183 Reviewed-By:
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/32222 Reviewed-By:
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/32232 Reviewed-By:
-
Pranshu Srivastava authored
Update docs that the optional callback passed to `writable.end` can be invoked in case of an error as well. PR-URL: https://github.com/nodejs/node/pull/32238 Fixes: https://github.com/nodejs/node/issues/31220 Reviewed-By:
-
Ben Noordhuis authored
The publicEncrypt/privateDecrypt/etc. family of functions didn't clear OpenSSL's error stack on early return. Notably, trying to use an encrypted key with the wrong passphrase left an error on the stack that made subsequent encrypt or decrypt operations fail, even with an unencrypted key. Fixes: https://github.com/nodejs/node/issues/32240 PR-URL: https://github.com/nodejs/node/pull/32248 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32286 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32479 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32461 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Xu Meng authored
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE. PR-URL: https://github.com/nodejs/node/pull/32459 Reviewed-By:
-
Harshitha KP authored
With large number of worker threads pthread fails with hard assertion. Instead of hard assertion throw a runtime error. PR-URL: https://github.com/nodejs/node/pull/32344 Fixes: https://github.com/nodejs/node/issues/32319 Reviewed-By:
-
Yash Ladha authored
PR-URL: https://github.com/nodejs/node/pull/32481 Reviewed-By:
-
Saajan authored
PR-URL: https://github.com/nodejs/node/pull/32214 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Robert Nagy authored
The http client should not know anything about free sockets. Let the agent handle its pool of sockets. PR-URL: https://github.com/nodejs/node/pull/32003 Reviewed-By:
-
