- Aug 16, 2018
-
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/18257 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/18822 Reviewed-By:
-
Bamieh authored
This adds a implicit common.mustCall to the callback provided to the countdown. PR-URL: https://github.com/nodejs/node/pull/18506 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Yihong Wang authored
When building the node with `--shared` option, the major output is the shared library. However, we still build a node executable which links to the shared lib. It's for testing purpose. When testing with the executable, some test cases move/copy the executable, change the relative path to the shared library and fail. Using lib path env would solve the issue. However, in macOS, need to change the install name for the shared library and use rpath in the executable. In AIX, `-brtl` linker option rebinds the symbols in the executable and addon modules could use them. Signed-off-by:
Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/18626 Refs: https://github.com/nodejs/node/issues/18535 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Antoine AMARA authored
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: https://github.com/nodejs/node/pull/18721 Fixes: https://github.com/nodejs/node/issues/18662 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
cjihrig authored
This commit adds a regression test for de848ac1, which broke multiline input in the REPL. PR-URL: https://github.com/nodejs/node/pull/18718 Refs: https://github.com/nodejs/node/pull/17828 Refs: https://github.com/nodejs/node/pull/18715 Reviewed-By:
-
Daniel Bevenius authored
Currently when building --without-ssl a 'ERR_NO_CRYPTO' error is reported. This is not currently being picked up by the crypto-check lint rule as it does not actually require any crypto modules directly, but instead this is done by common/benchmark. PR-URL: https://github.com/nodejs/node/pull/18724 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Chin Huang authored
Add useful info about process.domain to error meesages in the uncaughtException event listener and the beforeExit event listener. Refactor code such as using template literals, and also make sure uncaughtException listner is detached after firing once to avoid endless loop in case of exception throw in the beforeExit event listner. PR-URL: https://github.com/nodejs/node/pull/18541 Reviewed-By:
-
Evan Lucas authored
Previously, the err passed to the callback of fs.open() was not checked. PR-URL: https://github.com/nodejs/node/pull/18681 Reviewed-By:
-
Jan Krems authored
Removes the prompt to report a bug when trying to launch the debugger using a port that is already in use. Changeset generated via: ``` rm -rf deps/node-inspect node-inspect-* && \ curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.11.5.tar.gz" | \ tar -xzvf - && mv node-inspect-* deps/node-inspect ``` PR-URL: https://github.com/nodejs/node/pull/21055 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
Original commit message: [intl] unbreak build with ICU 57 Remove a call to `icu::toUCharPtr()` that wasn't present in other similar looking call sites either, just reinterpret_cast directly. Fixes https://github.com/nodejs/node/issues/19656. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3 Reviewed-on: https://chromium-review.googlesource.com/987953 Reviewed-by:Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Cr-Commit-Position: refs/heads/master@{#52311} PR-URL: https://github.com/nodejs/node/pull/19710 Fixes: https://github.com/nodejs/node/issues/19656 Refs: https://github.com/v8/v8/commit/b767cde1e7bb94b3fea13f2d7e10cd90e6813d6c Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19789 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/18952 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/18918 Reviewed-By:
-
Shobhit Chittora authored
1. Adds fixer method 2. Extends test PR-URL: https://github.com/nodejs/node/pull/16646 Refs: https://github.com/nodejs/node/issues/16636 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Shobhit Chittora authored
1. Fixer for crypto-check.js 2. Extends tests PR-URL: https://github.com/nodejs/node/pull/16647 Refs: https://github.com/nodejs/node/issues/16636 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
killagu authored
`node --prof foo.js` may not print the full profile log file, leaving the last line broken (for example `tick,`. When that happens, `readline` will be stuck in an infinite loop. This patch fixes it. Also introduced `common.isCPPSymbolsNotMapped` to avoid duplicated code on tick-processor tests. Backport-PR-URL: https://github.com/nodejs/node/pull/18901 PR-URL: https://github.com/nodejs/node/pull/18641 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Santiago Gimeno authored
`readable` and `writable` properties can be passed directly to the `net.Socket` constructor. This change also avoids an unnecessary call to `read(0)` on the `stdin` socket. This behavior was disclosed when trying to merge `libuv@1.19.0` and specifically this commit: https://github.com/libuv/libuv/commit/fd049399aa4ed8495928e375466970d98cb42e17. PR-URL: https://github.com/nodejs/node/pull/18701 Refs: https://github.com/libuv/libuv/pull/1655 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/18734 Fixes: https://github.com/nodejs/node/issues/18730 Reviewed-By:
-
Kevin Caulfield authored
Add unexpected value to dgram socket type assertion and fix the size entry. PR-URL: https://github.com/nodejs/node/pull/18449 Reviewed-By:
-
Ruben Bridgewater authored
Currently the call can lead to a TypeError with the message: `Cannot read property 'value' of undefined`. This fixes it by first checking that the first argument is truthy. PR-URL: https://github.com/nodejs/node/pull/18729 Reviewed-By:
-
Santiago Gimeno authored
Don't disconnect the child until all exceptions are thrown. Fixes: https://github.com/nodejs/node/issues/18659 PR-URL: https://github.com/nodejs/node/pull/18692 Fixes: https://github.com/nodejs/node/issues/18659 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/18558 Reviewed-By:
-
Daniel Bevenius authored
This commit add SetUpTestCase and TearDownTestCase functions that will be called once per test case. Currently we only have SetUp/TearDown which are called for each test. This commit moves the initialization and configuration of Node and V8 to be done on a per test case basis, but gives each test a new Isolate. PR-URL: https://github.com/nodejs/node/pull/18558 Reviewed-By:
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18119 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Gus Caplan authored
Original commit message: [api,modules] Allow GetModuleNamespace on unevaluated modules. Bug: v8:7217 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I97b067254355eb91e12b92eba92631cbc3ce8000 Reviewed-on: https://chromium-review.googlesource.com/839280 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50395} PR-URL: https://github.com/nodejs/node/pull/18038 Refs: https://github.com/v8/v8/commit/0c35b7252aaeedf4871a78935075808439726853 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/21592 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/18087 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19578 Refs: https://github.com/nodejs/node/pull/17412 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19569 Refs: https://github.com/nodejs/node/pull/18399 Reviewed-By:
-
cjihrig authored
This commit allows cluster workers to be created with configurable working directories. Fixes: https://github.com/nodejs/node/issues/16388 PR-URL: https://github.com/nodejs/node/pull/18399 Reviewed-By:
-
Todd Wong authored
Fixes: https://github.com/nodejs/node/issues/17370 PR-URL: https://github.com/nodejs/node/pull/17412 Fixes: https://github.com/nodejs/node/issues/17370 Reviewed-By:
-
Yosuke Furukawa authored
PR-URL: https://github.com/nodejs/node/pull/16644 Reviewed-By:
-
Refael Ackermann authored
Backport-PR-URL: https://github.com/nodejs/node/pull/21736 PR-URL: https://github.com/nodejs/node/pull/16976 Refs: https://github.com/nodejs/node/pull/16248 Reviewed-By:
-
Gabriel Schulhof authored
Backport-PR-URL: https://github.com/nodejs/node/pull/21732 PR-URL: https://github.com/nodejs/node/pull/20779 Reviewed-By:
-
Mark S. Everitt authored
Brings the ALPNProtocols & NPNProtocols options of TLSSocket in line with the documentation. i.e. an array of strings for protocols may be used, not only a buffer. Backport-PR-URL: https://github.com/nodejs/node/pull/21721 PR-URL: https://github.com/nodejs/node/pull/16655 Fixes: https://github.com/node/issues/16643 Reviewed-By:
-
Santiago Gimeno authored
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: https://github.com/nodejs/node/pull/19856 Fixes: https://github.com/nodejs/node/issues/19804 Reviewed-By:
-
Rich Trott authored
Move resource-sensitive test from parallel to sequential. Fixes: https://github.com/nodejs/node/issues/19804 PR-URL: https://github.com/nodejs/node/pull/19809 Reviewed-By:
-
James M Snell authored
Continue moving bits of code out of node.cc ... add node_encoding.cc as a home for `ParseEncoding` and related functions. Backport-PR-URL: https://github.com/nodejs/node/pull/21798 PR-URL: https://github.com/nodejs/node/pull/21112 Reviewed-By:
-
James M Snell authored
Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
