- Jun 06, 2017
-
-
Rich Trott authored
On macOS, a watcher created with fs.watch() does not necessarily start receiving events immediately. So it can miss a change by fs.writefile() if it comes very soon after the watcher is created. Fix test flakiness caused by this by using `setInterval()` to repeat the write action. PR-URL: https://github.com/nodejs/node/pull/13252 Fixes: https://github.com/nodejs/node/issues/13248 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Use `common.mustNotCall()` in test-stream2-objects.js to confirm that noop function is never invoked. PR-URL: https://github.com/nodejs/node/pull/13249 Reviewed-By:
-
Jason Ginchereau authored
One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version: https://github.com/nodejs/node/pull/12864 When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment: https://github.com/nodejs/node-chakracore/issues/246 So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a `setImmedate()` callback before every call to `gc()` and assertions about the effects of the GC. PR-URL: https://github.com/nodejs/node/pull/13121 Reviewed-By:
-
Michael Dawson authored
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer. PR-URL: https://github.com/nodejs/node/pull/13244 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com> Reviewed-By:
Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com>
-
Daijiro Wachi authored
BUILDING.md + L122: Missing code-language flag + L170: Strong should use `*` as a marker doc/changelogs/CHANGELOG_V6.md + L1494: Don't pad `emphasis` with inner spaces doc/guides/maintaining-V8.md + L3: Don't use multiple top level headings + L16: Don't use multiple top level headings + L40: Don't use multiple top level headings + L124: Don't use multiple top level headings + L182: Missing code-language flag + L223: Don't use multiple top level headings + L288: Don't use multiple top level headings + L307: Don't use multiple top level headings doc/guides/writing-tests.md + L322: Missing code-language flag + L329: Missing code-language flag doc/releases.md + L299: Missing code-language flag PR-URL: https://github.com/nodejs/node/pull/13270 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Allow binding to a randomly assigned port number with `--inspect=0` or `--inspect-brk=0`. PR-URL: https://github.com/nodejs/node/pull/5025 Refs: https://github.com/nodejs/node/issues/4419 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Michaël Zasso authored
When V8 is built from its master branch, it adds a " (candidate)" suffix to the version string. Add support for that in the tests so it does not fail with Node canary. PR-URL: https://github.com/nodejs/node/pull/13282 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Daniel Bevenius authored
Currently this test will fail with the following error message when configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit checks for crypto and skips this tests if such support is not available. PR-URL: https://github.com/nodejs/node/pull/13253 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
- May 31, 2017
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12220
-
James M Snell authored
* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c1`](https://github.com/nodejs/node/commit/4a7233c178)] [#12892](https://github.com/nodejs/node/pull/12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5`](https://github.com/nodejs/node/commit/d2d32ea5a2)] [#11968](https://github.com/nodejs/node/pull/11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b465`](https://github.com/nodejs/node/commit/7eb1b4658e)] [#12141](https://github.com/nodejs/node/pull/12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244`](https://github.com/nodejs/node/commit/beca3244e2)] [#10236](https://github.com/nodejs/node/pull/10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288`](https://github.com/nodejs/node/commit/97a77288ce)] [#12348](https://github.com/nodejs/node/pull/12348), [[`d75fdd96`](https://github.com/nodejs/node/commit/d75fdd96aa)] [#10423](https://github.com/nodejs/node/pull/10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9`](https://github.com/nodejs/node/commit/627ecee9ed)] [#10653](https://github.com/nodejs/node/pull/10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d8`](https://github.com/nodejs/node/commit/f18e08d820)] [#9744](https://github.com/nodejs/node/pull/9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af`](https://github.com/nodejs/node/commit/3c3b36af0f)] [#12936](https://github.com/nodejs/node/pull/12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8`](https://github.com/nodejs/node/commit/60d1aac8d2)] [#12784](https://github.com/nodejs/node/pull/12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe83`](https://github.com/nodejs/node/commit/84dabe8373)] [#12489](https://github.com/nodejs/node/pull/12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34e`](https://github.com/nodejs/node/commit/7a55e34ef4)] [#10467](https://github.com/nodejs/node/pull/10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361`](https://github.com/nodejs/node/commit/3c2a9361ff)] [#9683](https://github.com/nodejs/node/pull/9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1`](https://github.com/nodejs/node/commit/90403dd1d0)] [#11567](https://github.com/nodejs/node/pull/11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776`](https://github.com/nodejs/node/commit/d3480776c7)] [#11259](https://github.com/nodejs/node/pull/11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba49`](https://github.com/nodejs/node/commit/fb71ba4921)] [#11355](https://github.com/nodejs/node/pull/11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032`](https://github.com/nodejs/node/commit/3e6f1032a4)] [#10805](https://github.com/nodejs/node/pull/10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf09`](https://github.com/nodejs/node/commit/5de3cf099c)] [#10116](https://github.com/nodejs/node/pull/10116). * The legacy `linkedlist` module has been removed [[`84a23391`](https://github.com/nodejs/node/commit/84a23391f6)] [#12113](https://github.com/nodejs/node/pull/12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0`](https://github.com/nodejs/node/commit/56e881d0b0)] [#11975](https://github.com/nodejs/node/pull/11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3f`](https://github.com/nodejs/node/commit/03e89b3ff2)] [#10116](https://github.com/nodejs/node/pull/10116). * Process warnings may now include additional detail [[`dd20e68b`](https://github.com/nodejs/node/commit/dd20e68b0f)] [#12725](https://github.com/nodejs/node/pull/12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02d`](https://github.com/nodejs/node/commit/3f27f02da0)] [#11599](https://github.com/nodejs/node/pull/11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (https://github.com/nodejs/node/commit/ec7cbaf266)] [#12995](https://github.com/nodejs/node/pull/12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f`](https://github.com/nodejs/node/commit/a16b570f8c)] [#11968](https://github.com/nodejs/node/pull/11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f8644`](https://github.com/nodejs/node/commit/010f864426)] [#12949](https://github.com/nodejs/node/pull/12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab2`](https://github.com/nodejs/node/commit/a5f91ab230)] [#11689](https://github.com/nodejs/node/pull/11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4`](https://github.com/nodejs/node/commit/8a7db9d4b5)] [#12087](https://github.com/nodejs/node/pull/12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22f`](https://github.com/nodejs/node/commit/b6e1d22fa6)] [#12925](https://github.com/nodejs/node/pull/12925). * `Stream` now supports the `_final()` API [[`07c7f198`](https://github.com/nodejs/node/commit/07c7f198db)] [#12828](https://github.com/nodejs/node/pull/12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a`](https://github.com/nodejs/node/commit/348cc80a3c)] [#5923](https://github.com/nodejs/node/pull/5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae0899`](https://github.com/nodejs/node/commit/a2ae08999b)] [#11349](https://github.com/nodejs/node/pull/11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c`](https://github.com/nodejs/node/commit/d523eb9c40)] [#11447](https://github.com/nodejs/node/pull/11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0`](https://github.com/nodejs/node/commit/d080ead0f9)] [#12710](https://github.com/nodejs/node/pull/12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b8`](https://github.com/nodejs/node/commit/5bfd13b81e)] [#9726](https://github.com/nodejs/node/pull/9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1d`](https://github.com/nodejs/node/commit/455e6f1dd8)] [#11708](https://github.com/nodejs/node/pull/11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202`](https://github.com/nodejs/node/commit/aab0d202f8)] [#11624](https://github.com/nodejs/node/pull/11624). * The new `util.promisify()` API has been added [[`99da8e8e`](https://github.com/nodejs/node/commit/99da8e8e02)] [#12442](https://github.com/nodejs/node/pull/12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47`](https://github.com/nodejs/node/commit/91383e47fd)] [#12001](https://github.com/nodejs/node/pull/12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd23`](https://github.com/nodejs/node/commit/b514bd231e)] [#11391](https://github.com/nodejs/node/pull/11391). -
Myles Borins authored
This floats https://github.com/npm/npm/pull/16791 onto npm v5.0.0 to fix an edge case that was found in citgm PR-URL: https://github.com/nodejs/node/pull/13305 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
- May 30, 2017
-
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/13276 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/13220 Reviewed-By:
-
Ben Noordhuis authored
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - TUBITAK Kamu SM SSL Kok Sertifikasi - Surum 1 Certificates removed: - ApplicationCA - Japanese Government - Microsec e-Szigno Root CA - TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H6 - WellsSecure Public Root Certificate Authority PR-URL: https://github.com/nodejs/node/pull/13279 Reviewed-By:
-
Ben Noordhuis authored
This is the certdata.txt[0] that ships in NSS 3.30.2, released on 2017-04-20. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_30_2_RTM/lib/ckfw/builtins/certdata.txt PR-URL: https://github.com/nodejs/node/pull/13279 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/13232 Ref: https://github.com/nodejs/CTC/issues/92 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Rich Trott authored
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: https://github.com/nodejs/node/pull/13231 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/12949 Fixes: https://github.com/nodejs/node/issues/12364 Fixes: https://github.com/nodejs/node/issues/12630 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12710 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/12710 Reviewed-By:
-
Daniel Bevenius authored
When upgrading OpenSSL, Step 6 in upgrading guide explains the steps that need to be taken if asm files need updating. This might not always be the case and something that needs to be checked from release to release. This commit adds an example of using github to manually compare two tags to see if any changes were made to asm files. PR-URL: https://github.com/nodejs/node/pull/13234 Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Daniel Bevenius authored
VerifyCallback returns 1 in two locations but CHECK_CERT_REVOKED in a third return statment. This commit suggests that CHECK_OK is used instead of 1. CHECK_OK is also used as the return value in CheckWhitelistedServerCert so it seems to be consitent change to make. PR-URL: https://github.com/nodejs/node/pull/13241 Reviewed-By:
-
Rich Trott authored
Check that callbacks are not executed when errors are expected to be thrown. PR-URL: https://github.com/nodejs/node/pull/13226 Reviewed-By:
-
Daijiro Wachi authored
doc/api/fs.md + L314: Missing code-language flag doc/api/stream.md + L2120: Do not use definitions with the same identifier + L2121: Do not use definitions with the same identifier + L2122: Do not use definitions with the same identifier doc/api/v8.md + L157: Move definitions to the end of the file + L158: Move definitions to the end of the file + L159: Move definitions to the end of the file + L160: Move definitions to the end of the file PR-URL: https://github.com/nodejs/node/pull/13236 Reviewed-By:
-
- May 29, 2017
-
-
Peter Marshall authored
Backport new virtual methods from 18a26cfe174 ("Add memory protection API to ArrayBuffer::Allocator") PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By:Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
kozyatinskiy authored
Original commit message: [PATCH] [inspector] finally removed *ExecuteScript from inspector We don't need hints from embedder any more. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2773143002 Cr-Commit-Position: refs/heads/master@{#44158} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By: -
Peter Marshall authored
Original commit message: [debugger,api] deprecate everything in v8-debug.h R=clemensh@chromium.org, jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2727393003 Cr-Commit-Position: refs/heads/master@{#43714} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By: -
hpayer authored
Original commit message: [PATCH] Rename idle garbage collection callback flag. TBR=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2867863002 Cr-Commit-Position: refs/heads/master@{#45173} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By: -
hpayer authored
Original commit message: [Api] Add an idle time garbage collection callback flag to GCCallbackFlags. BUG=chromium:718484 Review-Url: https://codereview.chromium.org/2867073002 Cr-Commit-Position: refs/heads/master@{#45167} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By: -
Peter Marshall authored
Because 5.8 still had other uses of the removed flag, there are some extra changes in Heap::ConfigureHeap and api.cc:SetResourceConstraints. Original commit message: [heap] Remove max_executable_size resource constraint. BUG=chromium:716032 Review-Url: https://codereview.chromium.org/2890603007 Cr-Commit-Position: refs/heads/master@{#45400} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By: -
Michael Achenbach authored
Original commit message: [PATCH] Merged: Make Object::GetOwnPropertyDescriptor() take a Name, not a String. Revision: b5e610c19208ef854755eec67011ca7aff008bf4 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=vogelheim@chromium.org Bug: Change-Id: I396b559b28aab6afa138db747711e50cd0da3da7 Reviewed-on: https://chromium-review.googlesource.com/513927 Reviewed-by:Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/6.0@{#5} Cr-Branched-From: 97dbf624a5eeffb3a8df36d24cdb2a883137385f-refs/heads/6.0.286@{#1} Cr-Branched-From: 12e6f1cb5cd9616da7b9d4a7655c088778a6d415-refs/heads/master@{#45439} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By:
-
Michaël Zasso authored
Node.js 8.0.0 is API/ABI forward-compatible with V8 6.0. The current module version is 55 and corresponds to V8 5.8. This increments the number by two to prevent incompatibility with modules compiled from Node master. PR-URL: https://github.com/nodejs/node/pull/12995 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Anna Henningsen authored
Assign a `PromiseWrap` instance to Promises that do not have one yet when the PromiseHook is being called. Fixes: https://github.com/nodejs/node/issues/13237 PR-URL: https://github.com/nodejs/node/pull/13242 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com> Reviewed-By:
Matthew Loring <mattloring@google.com>
-
Matt Loring authored
Promises do not have any internal fields by default. V8 recently added the capability of configuring the number of internal fields on promises. This change adds an internal field to promises allowing promises to be wrapped directly by the PromiseWrap object. In addition to cleaner code this avoids an extra object allocation per promise and speeds up promise creation with async_hooks enabled by ~2x. PR-URL: https://github.com/nodejs/node/pull/13242 Ref: https://github.com/nodejs/node/pull/13224 Reviewed-By:
-
- May 28, 2017
-
-
Michael Dawson authored
In the api docs there were some instances of behaviour and many more with behavior. I was asked as part of a review on a different PR which one to use and went with behavior to be consistent with the majority. Our style guide states that American English spelling is preferred. PR-URL: https://github.com/nodejs/node/pull/13245 Reviewed-By:
-
Peter Dave Hello authored
PR-URL: https://github.com/nodejs/node/pull/10626 Reviewed-By:
-
Aditya Anand authored
PR-URL: https://github.com/nodejs/node/pull/13215 Refs: https://github.com/nodejs/node/issues/12586 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/13208 Reviewed-By:
-
Bradley T. Hughes authored
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081 PR-URL: https://github.com/nodejs/node/pull/12193 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/13142 Reviewed-By:
-
