- Nov 21, 2020
-
-
Rich Trott authored
Two minor punctuation fixes for v8.md. PR-URL: https://github.com/nodejs/node/pull/36192 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36168 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36142 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com> Reviewed-By:
-
- Nov 20, 2020
-
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/35323 Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/36153 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Baruch Odem authored
PR-URL: https://github.com/nodejs/node/pull/36033 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36106 Reviewed-By:
-
Gabriel Schulhof authored
Change the documentation for `napi_define_class` in such a way that it mentions wrapping C++ class instances as a possible use for the API, rather than making the assumption that it is the use case for the API. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Co-authored-by:
-
Gabriel Schulhof authored
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by:
-
Myles Borins authored
There are only 2 cores available so we shouldn't be using -j8 Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: https://github.com/nodejs/node/pull/36169 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36118 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36140 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36141 Reviewed-By:
-
Anders Kaseorg authored
This was missed in commit 35b17d9a. Refs: https://github.com/nodejs/node/issues/34278 Refs: https://github.com/nodejs/node/pull/35171 Signed-off-by:
Anders Kaseorg <andersk@mit.edu> PR-URL: https://github.com/nodejs/node/pull/36131 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
- Nov 19, 2020
-
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36115 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Benjamin Gruenbaum authored
PR-URL: https://github.com/nodejs/node/pull/36048 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36149 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/36135 Reviewed-By:
Harshitha K P <harshitha014@gmail.com>
-
raisinten authored
PR-URL: https://github.com/nodejs/node/pull/36128 Reviewed-By:
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/26317 PR-URL: https://github.com/nodejs/node/pull/36032 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35781 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Andrew Casey authored
For consumers that aren't interested in *why* a `statSync` call failed, allocating and throwing an exception is an unnecessary expense. This PR adds an option that will cause it to return `undefined` in such cases instead. As a motivating example, the JavaScript & TypeScript language service shared between Visual Studio and Visual Studio Code is stuck with synchronous file IO for architectural and backward-compatibility reasons. It frequently needs to speculatively check for the existence of files and directories that may not exist (and cares about file vs directory, so `existsSync` is insufficient), but ignores file system entries it can't access, regardless of the reason. Benchmarking the language service is difficult because it's so hard to get good coverage of both code bases and user behaviors, but, as a representative metric, we measured batch compilation of a few hundred popular projects (by star count) from GitHub and found that, on average, we saved about 1-2% of total compilation time. We speculate that the savings could be even more significant in interactive (language service or watch mode) scenarios, where the same (non-existent) files need to be polled over and over again. It's not a huge improvement, but it's a very small change and it will affect a lot of users (and CI runs). For reference, our measurements were against `v12.x` (3637a061 at the time) on an Ubuntu Server desktop with an SSD. PR-URL: https://github.com/nodejs/node/pull/33716 Reviewed-By:
-
Anna Henningsen authored
Because the following gives basically no actionable information on its own, neither in the error message nor in the stack trace: (node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead. at emitMakeCallbackDeprecation (domain.js:123:13) at process.topLevelDomainCallback (domain.js:135:5) at process.callbackTrampoline (internal/async_hooks.js:124:14) PR-URL: https://github.com/nodejs/node/pull/36136 Reviewed-By:Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36122 Reviewed-By:
-
Rishabh Mehan authored
PR-URL: https://github.com/nodejs/node/pull/33735 Reviewed-By:
-
Nikola Glavina authored
PR-URL: https://github.com/nodejs/node/pull/34180 Fixes: https://github.com/nodejs/node/issues/34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Ole André Vadla Ravnås authored
So that Xcode's Python 3 gets picked up. PR-URL: https://github.com/nodejs/node/pull/35983 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/36127 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Luigi Pinca authored
Ensure that the write occurs in the same tick where the socket is destroyed by the other peer. PR-URL: https://github.com/nodejs/node/pull/36120 Fixes: https://github.com/nodejs/node/issues/36081 Fixes: https://github.com/nodejs/node/issues/4066 Reviewed-By:
-
- Nov 18, 2020
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36132 Reviewed-By:
-
Rich Trott authored
The existing text about processes not responding is unclear, at least to me. Suggestions for clarification welcome, but I think the best thing might be to state that the process may stop responding and leave it at that. The explanantion (about asynchronous listeners) is not clear to me. (Why would the fact that the listeners are asynchronous matter?) If it's an unnecessary detail (as seems likely), let's remove it. PR-URL: https://github.com/nodejs/node/pull/36117 Reviewed-By:
-
Michael Dawson authored
Refs: https://github.com/nodejs/node-addon-api/issues/764 Improve the consistency of how we get a context when needed. We generally used env->context() in N-API but there were are few exceptions that this PR addresses. Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/36068 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com>
-
woodfairy authored
After conducting several benchmarks, I noticed performance losses of 5-10%. As OS X is not a performance critical platform, as already mentioned by @bnoordhuis, I have removed the -no_pie flag at least for this platform. I'd love to enable PIE for other platforms if the 5-10% speed loss is not too high. I would be happy to hear your opinion on this. Refs: https://github.com/nodejs/node/issues/33425 PR-URL: https://github.com/nodejs/node/pull/35704 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Rich Trott authored
Use events instead of setTimeout() calls. Fixes: https://github.com/nodejs/node/issues/36078 PR-URL: https://github.com/nodejs/node/pull/36129 Reviewed-By:
-
mayank agarwal authored
added test for uncovered if statement in lib/fs.js PR-URL: https://github.com/nodejs/node/pull/35918 Reviewed-By:
-
- Nov 17, 2020
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/36124 Reviewed-By:
-
Beth Griggs authored
This is a security release. Notable changes: Vulnerabilities fixed: * CVE-2020-8277: Denial of Service through DNS request (High). A Node.js application that allows an attacker to trigger a DNS request for a host of their choice could trigger a Denial of Service by getting the application to resolve a DNS record with a larger number of responses. PR-URL: https://github.com/nodejs-private/node-private/pull/233
-
Beth Griggs authored
This is a security release. Notable changes: Vulnerabilities fixed: * CVE-2020-8277: Denial of Service through DNS request (High). A Node.js application that allows an attacker to trigger a DNS request for a host of their choice could trigger a Denial of Service by getting the application to resolve a DNS record with a larger number of responses. PR-URL: https://github.com/nodejs-private/node-private/pull/234
-
Michaël Zasso authored
This is a security release. Notable changes: Vulnerabilities fixed: * CVE-2020-8277: Denial of Service through DNS request (High). A Node.js application that allows an attacker to trigger a DNS request for a host of their choice could trigger a Denial of service by getting the application to resolve a DNS record with a larger number of responses. PR-URL: https://github.com/nodejs-private/node-private/pull/232
-
Michael Dawson authored
Original commit message: If there are more ttls returned than the maximum provided by the requestor, then the *naddrttls response would be larger than the actual number of elements in the addrttls array. This bug could lead to invalid memory accesses in applications using c-ares. This behavior appeared to break with PR https://github.com/c-ares/c-ares/pull/257 Fixes: https://github.com/c-ares/c-ares/issues/371 Reported By: Momtchil Momtchev (@mmomtchev) Fix By: Brad House (@bradh352) Refs: https://github.com/nodejs/node/issues/36063 Signed-off-by:
Beth Griggs <bgriggs@redhat.com>
-
