- Oct 02, 2017
-
-
Bryan English authored
No need to require it on each of those function calls. PR-URL: https://github.com/nodejs/node/pull/15647 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Trivikram Kamat authored
PR-URL: https://github.com/nodejs/node/pull/15624 Refs: https://github.com/nodejs/node/issues/14985 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Sam Roberts authored
Fixes warnings by Coverity Scan of inefficiences when passing by value instead of passing by const reference. PR-URL: https://github.com/nodejs/node/pull/15615 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Trivikram Kamat authored
PR-URL: https://github.com/nodejs/node/pull/15612 Refs: https://github.com/nodejs/node/issues/14985 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Anatoli Papirovski authored
Use the ability of nextTick and setImmediate to pass arguments instead of creating closures or binding. Add tests that cover the vast majority of error emits. PR-URL: https://github.com/nodejs/node/pull/15586 Reviewed-By:
-
Anna Henningsen authored
https://github.com/nodejs/node/pull/15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. PR-URL: https://github.com/nodejs/node/pull/15639 Refs: https://github.com/nodejs/node/pull/15428 Refs: f27b5e4b Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Jack Horton authored
PR-URL: https://github.com/nodejs/node/pull/15690 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Rich Trott authored
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: https://github.com/nodejs/node/pull/15705 Fixes: https://github.com/nodejs/node/issues/15700 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
- Oct 01, 2017
-
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/15682 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Ben Noordhuis authored
Entries in the `net.Server#_workers` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: https://github.com/nodejs/node/pull/15679 Fixes: https://github.com/nodejs/node/issues/15651 Reviewed-By:
-
Bryan English authored
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. PR-URL: https://github.com/nodejs/node/pull/15662 Fixes: https://github.com/nodejs/node/issues/15655 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/15675 Reviewed-By:
-
- Sep 30, 2017
-
-
Michael Dawson authored
n-api uses size_t for the size of strings when specifying string lengths. V8 only supports a size of int. Add a check so that an error will be returned if the user passes in a string with a size larger than will fit into an int. PR-URL: https://github.com/nodejs/node/pull/15611 Reviewed-By:
-
Rimas Misevičius authored
PR-URL: https://github.com/nodejs/node/pull/15642 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Sam Roberts authored
The node frame (aka loop) timing API did not land, it depends on https://github.com/libuv/libuv/pull/1489 which is still a WIP. See: https://github.com/nodejs/node/pull/14680#discussion_r140605664 PR-URL: https://github.com/nodejs/node/pull/15641 Reviewed-By:
-
Rimas Misevičius authored
Fix remaining calculation in the PercentDecode function to match the definition in URL standard: https://url.spec.whatwg.org/#remaining PR-URL: https://github.com/nodejs/node/pull/15637 Reviewed-By:
-
Daniel Bevenius authored
There is an unnecessary using TracingController in node_trace_writer.h and this commit removes it. PR-URL: https://github.com/nodejs/node/pull/15646 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/15649 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
- Sep 29, 2017
-
-
Jeremiah Senkpiel authored
Cherry-pick from ayo Ayo commit log: > Previously there wasn't any clear indicator when you hit the overflow > other than possibly unexpected behavior, and I think emitting a warning > may be appropriate. > PR-URL: https://github.com/ayojs/ayo/pull/71 > Reviewed-By:
Scott Trinh <scott@scotttrinh.com> > Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> > Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> > Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> PR-URL: https://github.com/nodejs/node/pull/15627 Reviewed-By:
-
Rami Moshe authored
PR-URL: https://github.com/nodejs/node/pull/15603 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
Benedikt Meurer authored
PR-URL: https://github.com/nodejs/node/pull/15677 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
- Sep 28, 2017
-
-
Michaël Zasso authored
Original commit message: Avoid disassembling Interpreted Regexp code I found that v8 will crash when --print-code is turned on while Regexp is interpreted. It crashes when trying to print Relocation info during Disassembly. It should probably avoid printing out disassembly when the Code object is a bytecode regexp. Bug: Change-Id: I35b531cb03996a303248652871452266c78fee38 Reviewed-on: https://chromium-review.googlesource.com/642127 Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47718} PR-URL: https://github.com/nodejs/node/pull/15599 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/15578 Fixes: https://github.com/nodejs/node/issues/15576 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/6.1.534.38...6.1.534.42 PR-URL: https://github.com/nodejs/node/pull/15521 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Thomas Corbière authored
PR-URL: https://github.com/nodejs/node/pull/15609 Reviewed-By:
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/13769 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Greg Alexander authored
Add openSSL error stack to the exception object thrown from crypto. The new exception property is only added to the object if the error stack has not cleared out prior to calling ThrowCryptoError. PR-URL: https://github.com/nodejs/node/pull/15518 Refs: https://github.com/nodejs/node/issues/5444 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/14154 Reviewed-By:
-
Matej Krajčovič authored
PR-URL: https://github.com/nodejs/node/pull/13424 Refs: https://github.com/nodejs/node/issues/11135 Reviewed-By:
-
David Benjamin authored
There is no need to reach into quite so many internals to decode an extension. PR-URL: https://github.com/nodejs/node/pull/15348 Reviewed-By:
-
David Benjamin authored
This accessor exists in OpenSSL 1.0.2, so it may be used already. This is cherry-picked from PR #8491. PR-URL: https://github.com/nodejs/node/pull/15348 Reviewed-By:
-
JP Wesselink authored
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: https://github.com/nodejs/node/pull/15179 Fixes: https://github.com/nodejs/node/issues/15012 Refs: https://github.com/nodejs/node/pull/5656 Refs: https://github.com/nodejs/node/pull/2571 Refs: https://github.com/nodejs/node/pull/7097 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Yorkie Liu authored
PR-URL: https://github.com/nodejs/node/pull/15148 Reviewed-By:
-
James M Snell authored
Make the `http2` module always available. The `--expose-http2` cli flag is made a non-op PR-URL: https://github.com/nodejs/node/pull/15535 Reviewed-By:
-
Lance Ball authored
This deprecates the current REPLServer.prototype.turnOffEditorMode and adds a private function for turnOffEditorMode which handles the necessary internal changes required instead of having them scattered about. PR-URL: https://github.com/nodejs/node/pull/15136 Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
-
Benjamin Coe authored
Add es-module to CI_JS_SUITES/js_test_suites, so that tests run in CI. Update test/README adding es-module section. PR-URL: https://github.com/nodejs/node/pull/15276 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Bryan English authored
Makes `Connection: keep-alive` behave correctly when making client connections to UNIX domain sockets. Prior to this, connections would never be re-used, but the keep-alive would cause the connections to stick around until they time out. This would lead to an eventual EMFILE error due to all the connections staying open. This was due to http.Agent not properly supporting UNIX domain sockets. PR-URL: https://github.com/nodejs/node/pull/13214 Reviewed-By:
-
João Reis authored
The event manifest specifies the MethodID field as a 32 bit integer. The 32 bit node executable publishes this correctly, but the 64 bit executable published a 64 bit integer, making the event undecodable. PR-URL: https://github.com/nodejs/node/pull/15563 Reviewed-By:
Hitesh Kanwathirtha <hiteshk@microsoft.com>
-
Antoine AMARA authored
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. PR-URL: https://github.com/nodejs/node/pull/15501 Fixes: https://github.com/nodejs/node/issues/15390 Reviewed-By:
-
Bryan English authored
For consistency with the rest of the crypto classes, exposes the ECDH class. Originally, only the createECDH function was exposed, and there was no real reason to hide the class. PR-URL: https://github.com/nodejs/node/pull/8188 Reviewed-By:
-
