- Nov 21, 2013
-
-
Timothy J Fontaine authored
-
- Nov 20, 2013
-
-
Trevor Norris authored
The TryCatch was not being checked after calling the unload asyncQueue callback in AsyncWrap::MakeCallback.
-
Ben Noordhuis authored
-
Ben Noordhuis authored
This is a cherry-pick of commit joyent/libuv@0520464.
-
- Nov 19, 2013
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
Conflicts: AUTHORS ChangeLog deps/uv/AUTHORS deps/uv/ChangeLog deps/uv/README.md deps/uv/build.mk deps/uv/src/unix/core.c deps/uv/src/unix/darwin-proctitle.c deps/uv/src/unix/darwin.c deps/uv/src/unix/fsevents.c deps/uv/src/unix/udp.c deps/uv/src/version.c deps/v8/src/platform-solaris.cc deps/v8/test/cctest/test-api.cc lib/tls.js src/node.h src/node_version.h
-
- Nov 16, 2013
-
-
Ben Noordhuis authored
Before this commit, passing --debugger and other V8 debug switches to node.js made node print a usage message and exit. Rewrite the debug argument parser so it only consumes switches that we understand and pass everything else as-is to V8. A side effect of this change is that switches like --debugger_agent and --debugger_port now work. That kind of obsoletes our debugger switches because they implement pretty much the same functionality but let's leave them in for now for the sake of convenience and backwards compatibility. Fixes #6526.
-
Trevor Norris authored
In many cases values expected to be unsigned were converted to a signed integer. Also include some small code cleanup.
-
Trevor Norris authored
Fixes #6490
-
Trevor Norris authored
Buffer#write() was showing the deprecation warning when only buf.write('string') was passed. This is incorrect since the encoding is always optional. Argument order should follow: Buffer#write(string[, offset[, length]][, encoding]) (yeah, not confusing at all)
-
- Nov 15, 2013
-
-
Ben Noordhuis authored
Node.js. It's not just for SF hipsters anymore.
-
Ben Noordhuis authored
This commit introduces some long lines but it's HTML so it's okay.
-
- Nov 14, 2013
-
-
Ben Noordhuis authored
-
Trevor Norris authored
-
Trevor Norris authored
Add HasExternalData API to check if Object has externally allocated memory, and accompanying tests.
-
- Nov 13, 2013
-
-
Fedor Indutny authored
-
Tim Wood authored
Emitting an event within a `EventEmitter#once` callback of the same event name will cause subsequent `EventEmitter#once` listeners of the same name to be called multiple times. var emitter = new EventEmitter(); emitter.once('e', function() { emitter.emit('e'); console.log(1); }); emitter.once('e', function() { console.log(2); }); emitter.emit('e'); // Output // 2 // 1 // 2 Fix the issue, by calling the listener method only if it was not already called. -
Trevor Norris authored
-
Trevor Norris authored
BaseObject is a class that just handles the Persistent handle attached to the class instance. This also removed WeakObject. Reordering the inheritance chain helps prevent unneeded calls on instances that don't call MakeCallback.
-
Trevor Norris authored
-
Trevor Norris authored
They didn't need to be defined in the body of the constructor.
-
Ben Noordhuis authored
Enter the context explicitly, don't rely on the fact that there is a Context::Scope a few stack frames below because it may be gone someday
-
Ben Noordhuis authored
env->context() may or may not create a new Local. It currently does not but don't depend on that behavior, create a HandleScope first.
-
Ben Noordhuis authored
Don't depend on any HandleScope objects that may or may not have been created in src/stream_wrap.cc, create them explicitly.
-
Ben Noordhuis authored
Make it more difficult to accidentally leak handles by removing the top-level HandleScope. Now if there's no valid HandleScope now, V8 will complain and, in debug builds, abort.
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* npm: Upgrade to 1.3.14 * uv: Upgrade to v0.10.19 * child_process: don't assert on stale file descriptor events (Fedor Indutny) * darwin: Fix "Not Responding" in Mavericks activity monitor (Fedor Indutny) * debugger: Fix bug in sb() with unnamed script (Maxim Bogushevich) * repl: do not insert duplicates into completions (Maciej Małecki) * src: Fix memory leak on closed handles (Timothy J Fontaine) * tls: prevent stalls by using read(0) (Fedor Indutny) * v8: use correct timezone information on Solaris (Maciej Małecki)
-
Timothy J Fontaine authored
Fixes a 4 byte leak on handles closing. AKA The Walmart leak. MakeCallback doesn't have a HandleScope. That means the callers scope will retain ownership of created handles from MakeCallback and related. There is by default a wrapping HandleScope before uv_run, if the caller doesn't have a HandleScope on the stack the global will take ownership which won't be reaped until the uv loop exits. If a uv callback is fired, and there is no enclosing HandleScope in the cb, you will appear to leak 4-bytes for every invocation. Take heed. cc @hueniverse
-
Timothy J Fontaine authored
-
- Nov 12, 2013
-
-
yangguo@chromium.org authored
`timezone` variable contains the difference, in seconds, between UTC and local standard time (see `man 3 localtime` on Solaris). Call to `tzset` is required to apply contents of `TZ` variable to `timezone` variable. BUG=v8:2064 Review URL: https://chromiumcodereview.appspot.com/10967066 Patch from Maciej Małecki <me@mmalecki.com>. This is a back-port of upstream commit r12802 and a forward port of commit 9fa953d3 from the v0.8 branch. V8 3.22 in the master branch contains the patch so no further forward-porting is necessary.
-
Maciej Małecki authored
Fix invalid `hasOwnProperty` function usage. For example, before in the REPL: ``` > Ar<Tab> Array Array ArrayBuffer ``` Now: ``` > Ar<Tab> Array ArrayBuffer ``` Fixes #6255. Closes #6498.
-
- Nov 11, 2013
-
-
Ben Noordhuis authored
Create a HandleScope before calling the Environment::GetCurrent() that takes a v8::Isolate* as an argument because it creates a handle with the call to v8::Isolate::CurrentContext().
-
- Nov 12, 2013
-
-
Trevor Norris authored
MakeCallback can only be called from a valid v8::HandleScope. Fixed #6487
-
- Nov 11, 2013
-
-
Ben Noordhuis authored
This commit removes the simple/test-event-emitter-memory-leak test for being unreliable with the new garbage collector: the memory pressure exerted by the test case is too low for the garbage collector to kick in. It can be made to work again by limiting the heap size with the --max_old_space_size=x flag but that won't be very reliable across platforms and architectures.
-
Timothy J Fontaine authored
-
- Nov 10, 2013
-
-
Ben Noordhuis authored
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl and update src/node_crypto.cc to make use of the new format. Fixes #6013.
-
Ben Noordhuis authored
This is a file from the NSS project containing root certificate data. It can be downloaded from: https://mxr.mozilla.org/mozilla/source/security/nss/lib/ckfw/builtins/certdata.txt?raw=1 Once downloaded, running `perl tools/mk-ca-bundle.pl` will update src/node_root_certs.h. Commit, rebuild and go.
-
Ben Noordhuis authored
Remove unneeded functionality and tweak the generated output so we can #include it in C++ source code.
-