- Dec 04, 2018
-
-
willhayslett authored
Converted the 'message' argument values from the last two free socket assert.strictEqual() calls to code comments as they fail to provide the necessary details and values specific to why the test is failing. The default message returned from the strictEqual() call should provide sufficient details for debugging errors. PR-URL: https://github.com/nodejs/node/pull/19525 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
juggernaut451 authored
PR-URL: https://github.com/nodejs/node/pull/19092 Fixes: https://github.com/nodejs/node/issues/14544 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
josephleon authored
Fixes: https://github.com/nodejs/node/issues/19412 PR-URL: https://github.com/nodejs/node/pull/19416 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Ujjwal Sharma authored
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-io-1068 to test-tty-stdin-end - Rename test-regress-GH-io-1811 to test-zlib-kmaxlength-rangeerror - Rename test-regress-GH-node-9326 to test-kill-segfault-freebsd - Rename test-timers-regress-GH-9765 to test-timers-setimmediate-infinite-loop - Rename test-tls-pfx-gh-5100-regr to test-tls-pfx-authorizationerror - Rename test-tls-regr-gh-5108 to test-tls-tlswrap-segfault PR-URL: https://github.com/nodejs/node/pull/19332 Fixes: https://github.com/nodejs/node/issues/19105 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com>
-
Gerhard Stoebich authored
Correct async hooks resource names to match the implementation: `TCPSERVER` => `TCPSERVERWRAP` Refs: #17157 PR-URL: https://github.com/nodejs/node/pull/24684 Refs: https://github.com/nodejs/node/pull/17157 Refs: https://github.com/nodejs/node/pull/24001 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
- Dec 01, 2018
-
-
Sam Roberts authored
Backport of https://github.com/nodejs/node/pull/24679 PR-URL: https://github.com/nodejs/node/pull/24682 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
- Nov 28, 2018
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/24575 Refs: https://github.com/nodejs/node/pull/24551 Refs: https://github.com/nodejs/node/pull/12958 Refs: https://github.com/nodejs/node/pull/12957 Refs: https://github.com/nodejs/node/pull/8325 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Jagannath Bhat authored
PR-URL: https://github.com/nodejs/node/pull/23978 Reviewed-By:
-
Rich Trott authored
Simplify text/content. PR-URL: https://github.com/nodejs/node/pull/23990 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/23989 Reviewed-By:
-
Richard Lau authored
Add `11.x` and mark `10.x` as `lts`. PR-URL: https://github.com/nodejs/node/pull/23980 Reviewed-By:
-
Esteban Sotillo authored
PR-URL: https://github.com/nodejs/node/pull/23956 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
mritunjaygoutam12 authored
PR-URL: https://github.com/nodejs/node/pull/23968 Reviewed-By:
-
Shobhit Chittora authored
PR-URL: https://github.com/nodejs/node/pull/22416 Fixes: https://github.com/nodejs/node/issues/20749 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Ouyang Yadong authored
Using the same "constants" string in c++. PR-URL: https://github.com/nodejs/node/pull/23894 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23902 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/23967 Reviewed-By:
-
Rich Trott authored
Per branding guidelines from the Foundation, use Node.js and not Node. PR-URL: https://github.com/nodejs/node/pull/23967 Reviewed-By:
-
Denis McDonald authored
PR-URL: https://github.com/nodejs/node/pull/23970 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/8102 PR-URL: https://github.com/nodejs/node/pull/23914 Reviewed-By:
-
Rich Trott authored
We removed the mailing list from the README and other places quite some time ago. Core devs don't monitor it much. However, it is still linked in a couple places in the docs directory. Remove those links. PR-URL: https://github.com/nodejs/node/pull/23932 Reviewed-By:
-
Myles Borins authored
Building node against versions of the dependencies that differ from the ones we vendor will result in a non ABI compatible version of Node.js This patch adds a note to make it explicit that if individuals build node against different versions of a dependency they should make a custom NODE_MODULE_VERSION. PR-URL: https://github.com/nodejs/node/pull/22237 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23931 Refs: https://github.com/nodejs/node/issues/23930 Reviewed-By:
-
Adam Majer authored
In commit bff53c5a, a check was added for very specific OpenSSL format. Unfortunately, when OpenSSL is compiled in FIPS mode, this check fails. Added additional regex to satisfy OpenSSL version strings in both regular and FIPS modes. PR-URL: https://github.com/nodejs/node/pull/23871 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/23881 Reviewed-By:
-
Loic authored
PR-URL: https://github.com/nodejs/node/pull/23829 Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23864 Reviewed-By:
-
Refael Ackermann authored
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: https://github.com/nodejs/node/pull/23778 Reviewed-By:
-
Rich Trott authored
Clarify in Travis results that the commit message linting is for the commit message and not something else. PR-URL: https://github.com/nodejs/node/pull/23742 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
-
Rich Trott authored
Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: https://github.com/nodejs/node/pull/23572#issuecomment-430850382 Refs: https://github.com/nodejs/node/pull/22842#issuecomment-430850049 PR-URL: https://github.com/nodejs/node/pull/23725 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Rich Trott authored
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: https://github.com/nodejs/node/pull/23307#issuecomment-428435859 PR-URL: https://github.com/nodejs/node/pull/23397 Reviewed-By:
-
Rich Trott authored
Use Travis-CI to check the formatting of the first commit in a pull request. This will hopefully reduce formatting errors and nits about them in pull requests. PR-URL: https://github.com/nodejs/node/pull/22452 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
Michaël Zasso authored
- In release guide - In Travis config Refs: https://github.com/nodejs/node/pull/20109 PR-URL: https://github.com/nodejs/node/pull/22991 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/22417 Reviewed-By:
George Adams <george.adams@uk.ibm.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Timothy Gu authored
Remove macOS-specific steps, and reduce warnings due to compilation with clang. PR-URL: https://github.com/nodejs/node/pull/21459 Reviewed-By:
-
Richard Lau authored
Run `make lint-md-build` to install the markdown linter. PR-URL: https://github.com/nodejs/node/pull/21215 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/ayojs/ayo/pull/14 Refs: https://github.com/ayojs/ayo/pull/75 Co-authored-by:
Jeremiah Senkpiel <fishrock123@rocketmail.com> PR-URL: https://github.com/nodejs/node/pull/21059 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/23763 Reviewed-By:
-
Nolan Rigo authored
PR-URL: https://github.com/nodejs/node/pull/23800 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
erickwendel authored
PR-URL: https://github.com/nodejs/node/pull/23605 Reviewed-By:
-
