- Jan 27, 2018
-
-
Ben Noordhuis authored
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1. Write them out in full and get rid of a few overlong lines in the process. PR-URL: https://github.com/nodejs/node/pull/18332 Reviewed-By:James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Seth Brenith authored
Long ago, V8 was much faster switching on string lengths than values. That is no longer the case, so we can simplify a couple of methods. PR-URL: https://github.com/nodejs/node/pull/18351 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Rich Trott authored
* provide block scoping to prevent unintended side effects * remove confusing and unnecessary assertion message * use consisitent `actual, expected` argument order for assertions PR-URL: https://github.com/nodejs/node/pull/18340 Reviewed-By:
-
Rich Trott authored
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: https://github.com/nodejs/node/issues/18269 PR-URL: https://github.com/nodejs/node/pull/18382 Reviewed-By:
-
James M Snell authored
lchown and lchownSync were opening file descriptors without closing them. Looks like it has been that way for 7 years. Does anyone actually use these functions? PR-URL: https://github.com/nodejs/node/pull/18329 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
- Jan 26, 2018
-
-
Yang Guo authored
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: https://github.com/nodejs/node/pull/18312 Reviewed-By:
-
Matheus Marchini authored
Before these changes, only V8 added postmortem metadata to Node's binary, limiting the possibilities for debugger's developers to add some features that rely on investigating Node's internal structures. These changes are first steps towards empowering debug tools to navigate Node's internal structures. One example of what can be achieved with this is shown at nodejs/llnode#122 (a command which prints information about handles and requests on the queue for a core dump file). Node postmortem metadata are prefixed with nodedbg_. This also adds tests to validate if all postmortem metadata are calculated correctly, plus some documentation on what is postmortem metadata and a few care to be taken to avoid breaking it. Ref: https://github.com/nodejs/llnode/pull/122 Ref: https://github.com/nodejs/post-mortem/issues/46 PR-URL: https://github.com/nodejs/node/pull/14901 Refs: https://github.com/nodejs/post-mortem/issues/46 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18378 Fixes: https://github.com/nodejs/node/issues/18377 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
- Jan 25, 2018
-
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/18369 Fixes: https://github.com/nodejs/code-and-learn/issues/58 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Kyle Farnung authored
Update performance_state to use AliasedBuffer and update usage sites. PR-URL: https://github.com/nodejs/node/pull/18300 Reviewed-By:
-
Ali Ijaz Sheikh authored
4c4af643 accidentally dropped the significant whitespace from this test when it was landed. Add the whitespace back. Refs: https://github.com/nodejs/node/pull/17489 PR-URL: https://github.com/nodejs/node/pull/18360 Reviewed-By:
-
Ali Ijaz Sheikh authored
Original commit message: [tracing] implement TRACE_EVENT_ADD_WITH_TIMESTAMP Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icb3cf7b7f96704e1eaa4c5fbf773b94b70cddc85 Reviewed-on: https://chromium-review.googlesource.com/861302 Reviewed-by:Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#50549} Refs: https://github.com/v8/v8/commit/c3bb73f6b95c280cee3a4d6b03c87fce93d617c7 Refs: https://github.com/nodejs/node/issues/17349 PR-URL: https://github.com/nodejs/node/pull/18196 Refs: https://github.com/nodejs/node/pull/18360 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Ali Ijaz Sheikh authored
Original commit message: [tracing] allow embedders to provide own tracing timestamps Make it possible for embedders to provide their own tracing timetamps by providing an overridable virtual function on V8's tracing controller. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I727e633cb7f63d4b41c2e427ecca3c9174c90bfe Reviewed-on: https://chromium-review.googlesource.com/847690 Reviewed-by: -
Gus Caplan authored
Original commit message: [api,modules] Allow GetModuleNamespace on unevaluated modules. Bug: v8:7217 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I97b067254355eb91e12b92eba92631cbc3ce8000 Reviewed-on: https://chromium-review.googlesource.com/839280 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50395} Backport-PR-URL: https://github.com/nodejs/node/pull/17489 PR-URL: https://github.com/nodejs/node/pull/18038 Refs: https://github.com/v8/v8/commit/0c35b7252aaeedf4871a78935075808439726853 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
cjihrig authored
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of https://github.com/v8/v8/commit/61bf2cc69217a4e9c7a40bb74269508fa26c2062 - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of https://github.com/v8/v8/commit/c00bb6da1cef9f7e9dab842904232255717f8291 and https://github.com/v8/v8/commit/cb46310a799eb0d60a613ead0af8c8200c5338b1 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of https://github.com/v8/v8/commit/61bf2cc69217a4e9c7a40bb74269508fa26c2062 Refs: https://github.com/nodejs/node-v8/pull/34 PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By: -
cjihrig authored
This commit renames V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT to V8DBG_CLASS_MAP__INSTANCE_TYPE__UINT16_T following upstream changes. PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Ben Noordhuis authored
Stop using the copy of clang that is bundled with Google's build tools and start using the compiler that is installed on the buildbots. It stopped working on one of the machines because it looked in the wrong place for system headers and is not representative of how users build Node.js on their systems. PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Michaël Zasso authored
The option was removed in [1] to use compiler option instead. [1]: https://github.com/v8/v8/commit/0b9acc20e2f54ca14eae9f4733eef404d3309121 PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Michaël Zasso authored
It is necessary to enable more C++ features in order to build V8 6.4. PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.4. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By:
-
Rod Vagg authored
This reverts commit 920c1320. Reverted along with d9b59def as this breaks compilation from downloadable source tarballs. Ref: https://github.com/nodejs/node/pull/17407 PR-URL: https://github.com/nodejs/node/pull/18287 Reviewed-By:
-
Rod Vagg authored
This reverts commit c6682636. Reverted along with d9b59def as this breaks compilation from downloadable source tarballs. Ref: https://github.com/nodejs/node/pull/17407 PR-URL: https://github.com/nodejs/node/pull/18287 Reviewed-By:
-
Rod Vagg authored
This reverts commit d9b59def. Breaks downloadable source tarball builds as we remove some files prior to creating a tarball but those files are included in the comprehensive list of dependencies listed in .deps. Ref: https://github.com/nodejs/node/pull/17407 PR-URL: https://github.com/nodejs/node/pull/18287 Reviewed-By:
-
Rod Vagg authored
This reverts commit 2cb9e2a6. Reverted along with d9b59def as this introduces freshness checks that are too stringent without the comprehensive dependency checking of introduced in d9b59def so `make test` won't work with this. Ref: https://github.com/nodejs/node/pull/17407 PR-URL: https://github.com/nodejs/node/pull/18287 Reviewed-By:
-
Peter Dalgaard-Jensen authored
Improve documentation of callback signature of http2Stream.pushStream() function to align with the changes made in https://github.com/nodejs/node/pull/17406. PR-URL: https://github.com/nodejs/node/pull/18258 Fixes: https://github.com/nodejs/node/issues/18198 Refs: https://github.com/nodejs/node/pull/17406 Reviewed-By:
-
Peter Dalgaard-Jensen authored
Update documentation of modules.md for require.resolve.paths() to include the possibillity of null as a return value if the request string given matches a core module name. PR-URL: https://github.com/nodejs/node/pull/18350 Fixes: https://github.com/nodejs/node/issues/18230 Reviewed-By:
-
Ali Ijaz Sheikh authored
This fixes a bug in the CPU profiler where some ticks were attributed to the wrong file. Original commit message: [cpu-profiler] Fix script name when recording inlining info Use the script name from the shared function info to create an inline entry. Otherwise functions are attributed to the wrong file in the CpuProfileNode. See https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs/issues/89 Bug: v8:7203, v8:7241 Change-Id: I8ea31943741770e6611275a9c93375922b934547 Reviewed-on: https://chromium-review.googlesource.com/848093 Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#50339} Refs: https://github.com/v8/v8/commit/76c3ac58b00e08e3e2fecc3f7169bd64d91c8f75 PR-URL: https://github.com/nodejs/node/pull/18298 Reviewed-By:
-
Ali Ijaz Sheikh authored
Override the V8 TracingController to provide uv_hrtime based timestamps. This allows tracing timestamps to be comparable with process.hrtime timestamps. Fixes: https://github.com/nodejs/node/issues/17349 PR-URL: https://github.com/nodejs/node/pull/18196 Reviewed-By:
-
Ali Ijaz Sheikh authored
Original commit message: [tracing] implement TRACE_EVENT_ADD_WITH_TIMESTAMP Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icb3cf7b7f96704e1eaa4c5fbf773b94b70cddc85 Reviewed-on: https://chromium-review.googlesource.com/861302 Reviewed-by: -
Ali Ijaz Sheikh authored
Original commit message: [tracing] allow embedders to provide own tracing timestamps Make it possible for embedders to provide their own tracing timetamps by providing an overridable virtual function on V8's tracing controller. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I727e633cb7f63d4b41c2e427ecca3c9174c90bfe Reviewed-on: https://chromium-review.googlesource.com/847690 Reviewed-by:
-
- Jan 24, 2018
-
-
Luigi Pinca authored
The `n` argument of `BufferList.prototype.concat()` is not the number of `Buffer` instances in the list, but their total length when concatenated. PR-URL: https://github.com/nodejs/node/pull/18239 Reviewed-By:
-
Luigi Pinca authored
To avoid a function call `BufferList.prototype.concat()` is not called when there is only a buffer in the list. That buffer is instead accessed directly. PR-URL: https://github.com/nodejs/node/pull/18239 Reviewed-By:
-
Ruben Bridgewater authored
This makes `assert.ifError` stricter by only accepting `null` and `undefined` from now on. Before any truthy value was accepted. PR-URL: https://github.com/nodejs/node/pull/18247 Reviewed-By:
-
Ruben Bridgewater authored
Destructure the necessary Error classes from internal/errors. This improves the readability of the error creation. PR-URL: https://github.com/nodejs/node/pull/18247 Reviewed-By:
-
Ruben Bridgewater authored
It is hard to know where ifError is actually triggered due to the original error being thrown. This changes it by wrapping the original error in a AssertionError. This has the positive effect of also making clear that it is indeed a assertion function that triggered that error. The original stack can still be accessed by checking the `actual` property. PR-URL: https://github.com/nodejs/node/pull/18247 Reviewed-By:
-
Ruben Bridgewater authored
The offset was formerly coerced to a integer and this reimplements that. PR-URL: https://github.com/nodejs/node/pull/18215 Fixes: https://github.com/nodejs/node/issues/18208 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17615 Reviewed-By:
-
