- Jul 09, 2020
-
-
Xu Meng authored
Since the PR https://github.com/libuv/libuv/pull/2753 has been landed, we need to revert the code change in PR https://github.com/nodejs/node/pull/32338. PR-URL: https://github.com/nodejs/node/pull/33629 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/33602 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anna Henningsen authored
This is not a big concern, because right now, all (non-test) inputs to the parser are `'\0'`-terminated, but we should be future-proof here and not perform these OOB reads. PR-URL: https://github.com/nodejs/node/pull/33640 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Lucas Holmquist authored
PR-URL: https://github.com/nodejs/node/pull/33590 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
sapics authored
Replace redirected urls with the final ones. Replace http urls with https ones. PR-URL: https://github.com/nodejs/node/pull/33614 Reviewed-By:
-
Daniel Bevenius authored
This commit suggest using MaybeLocal.ToLocal and passing in the Local<String> node_opts. It also introduces a variable, arg_v8, of type Local<String> to enable the use of ToLocal. The motivation for doing this is that the following MaybeLocal::ToLocalChecked and MaybeLocal::FromMaybe calls can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33599 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/33597 Reviewed-By:
-
Tom Nagle authored
PR-URL: https://github.com/nodejs/node/pull/33547 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
cjihrig authored
This commit adds stdin, stderr, and stdout options to WASI, which allow the stdio streams to be configured. PR-URL: https://github.com/nodejs/node/pull/33544 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Derek Lewis authored
Prior to this commit, Markdown fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the one shown in the CommonMark spec. Refs: https://github.com/commonmark/commonmark-spec/blob/1103710025f340702edcb070be41f9982b6544d5/spec.txt#L131 PR-URL: https://github.com/nodejs/node/pull/33542 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Maciej Kacper Jagiełło authored
PR-URL: https://github.com/nodejs/node/pull/33541 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, JavaScript fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the one with the highest frequency in the doc/api/ dir. Stats: > 'js' => 1091, > 'javascript' => 2, PR-URL: https://github.com/nodejs/node/pull/33531 Reviewed-By:
-
Ruben Bridgewater authored
The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: https://github.com/nodejs/node/issues/32907 Signed-off-by:
-
Ruben Bridgewater authored
The current name of most of the global console functions is "bound consoleCall". This is changed to the actual functions name e.g., "log" or "error". Signed-off-by:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Ruben Bridgewater authored
This makes sure internal console properties are not visible during default inspection. They are still visible when inspecting the console with `showHidden` set to `true`. These properties are confusing while working with the REPL and easily show up. Signed-off-by:
-
Ruben Bridgewater authored
This check is always truthy. Thus, it's removed. Signed-off-by:
-
Ruben Bridgewater authored
This makes sure errors are fully inspected during exit. That is important to provide as many debugging information to the user as possible. Signed-off-by:
-
Pranshu Srivastava authored
added writableHighWaterMark, writableLength, and writableFinished properties with test. Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33506 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33146 Reviewed-By:
-
Zeke Sikelianos authored
These are changed to either ```text or ```console. PR-URL: https://github.com/nodejs/node/pull/33028 Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/33592 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Richard Lau authored
s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python Refs: https://github.com/nodejs/node/pull/32609 PR-URL: https://github.com/nodejs/node/pull/33589 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Pranshu Srivastava authored
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33188 Reviewed-By:
Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Gabriel Schulhof authored
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: https://github.com/nodejs/node/pull/33570 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
Daniel Bevenius authored
This commit removes the unused using declarations reported by lint-cpp. PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Ash Cripps authored
Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: https://github.com/nodejs/node/pull/33500 Reviewed-By:
-
Richard Lau authored
`check-imports.py` was missing some unused `using` statements as it was not matching on word boundaries (e.g. `MaybeLocal` was considered a use of `Local`). Fix that and add some unit tests (which required the script to be renamed to drop the `-` so it could be imported into the test script). PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By:
-
Daniel Bevenius authored
This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fn. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: https://github.com/nodejs/node/pull/33554 Reviewed-By:
-
Robert Nagy authored
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: https://github.com/nodejs/node/issues/4066 PR-URL: https://github.com/nodejs/node/pull/33539 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33555 Reviewed-By:
-
Thomas authored
On Windows there is a program "find.exe" located in C:\Windows\System32, which is usually in the PATH before MSYS version of that program (required for running makefile). The Windows version of the program uses different CLI syntax, which results in errors like "File not found - *node_modules*" This commit specifies the full path to the program, which is also properly handled by MSYS on Windows. PR-URL: https://github.com/nodejs/node/pull/33136 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, Bash fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the less-obscure variant. PR-URL: https://github.com/nodejs/node/pull/33510 Reviewed-By:
-
Ben Bucksch authored
When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an instance of Object Expected: TypeError [ERR_INVALID_ARG_TYPE]: The "key.key property" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined This seems like a copy&paste bug. Somebody copied from the end of the function, where this is correct, to here, where it's wrong. PR-URL: https://github.com/nodejs/node/pull/33482 Fixes: https://github.com/nodejs/node/issues/33480 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org>
-
Derek Lewis authored
Prior to this commit, shell fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standarize on the one with the highest frequency in the doc/api/ dir. Stats: > 'console' => 54, > 'shell' => 2, PR-URL: https://github.com/nodejs/node/pull/33486 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, C fenced code blocks in Markdown files had inconsistent info strings. This has been corrected to standardize on the lowercase variant, which matches the others, is the typical file extension for C files, and is the CSS class used by highlight.js despite representing a minority of appearances in the doc/api/ dir. Stats: > 'C' => 181, > 'c' => 3, Refs: https://github.com/highlightjs/highlight.js/pull/2577 PR-URL: https://github.com/nodejs/node/pull/33507 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.1.0 PR-URL: https://github.com/nodejs/node/pull/33526 Reviewed-By:
-
Joyee Cheung authored
When the user tries to activate the inspector that is already active on a different port and host, we previously just silently reset the port and host stored in the Environment without actually doing anything for that to be effective. After this patch, we throw an error telling the user to close the active inspector before invoking `inspector.open()` again. PR-URL: https://github.com/nodejs/node/pull/33015 Fixes: https://github.com/nodejs/node/issues/33012 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33354 Reviewed-By:
-
Ben Noordhuis authored
Be careful when emitting the 'beforeExit' event. It's not allowed to call into the runtime when a termination exception is pending. Fixes: https://github.com/nodejs/node/issues/33377 PR-URL: https://github.com/nodejs/node/pull/33386 Reviewed-By:
-
cjihrig authored
This commit migrates the WASI C++ code from UncheckedCalloc() to std::vectors. PR-URL: https://github.com/nodejs/node/pull/33525 Reviewed-By:
-
