- Mar 21, 2018
-
-
Ruben Bridgewater authored
This ports the errors to the new error system. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Ruben Bridgewater authored
This updates all internal errors to the new error type. While doing so it removes unused errors. A few errors currently seem to have the wrong type. To identify them later, comments were added next to the error type. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This implements a function based system. Instead of passing in the error code as first argument, the error code itself is a error class. It already contains the correct error type, so while adding a new error no one has to think about the error type anymore. In case a single error code has more than one error type, the error class has properties for the non default error types. Those can be used as fallback. This prevents typos, makes the implementation easier and it is less verbose when writing the code for a new error. The implementation itself does not interfere with the old implementation. So the old and the new system can co-exist and it is possible to slowly migrate the old ones to the new system. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
This also fixes the three entries that did not pass. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
Move the print statements below a console.log call. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18758 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Ruben Bridgewater authored
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18745 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Ruben Bridgewater authored
Prohibit the usage of `assert.doesNotThrow()`. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Ruben Bridgewater authored
Add punctuation and comments about code that should not throw. Also remove a obsolete test and refactor some tests. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By:
-
Ruben Bridgewater authored
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By:
-
Ruben Bridgewater authored
This adds puctiations to the comments, uses a capital letters for the first character, removes a few obsolete comments and switches to assert.ok when suitable. It also moves all `assert.deepEqual()` and `assert.deepStrictEqual()` tests to the appropriate file. Backport-PR-URL: https://github.com/nodejs/node/pull/19244 PR-URL: https://github.com/nodejs/node/pull/18610 Reviewed-By:
-
Daniel Bevenius authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19504 PR-URL: https://github.com/nodejs/node/pull/18558 Reviewed-By:
-
Daniel Bevenius authored
This commit add SetUpTestCase and TearDownTestCase functions that will be called once per test case. Currently we only have SetUp/TearDown which are called for each test. This commit moves the initialization and configuration of Node and V8 to be done on a per test case basis, but gives each test a new Isolate. Backport-PR-URL: https://github.com/nodejs/node/pull/19504 PR-URL: https://github.com/nodejs/node/pull/18558 Reviewed-By:
-
Myles Borins authored
Did not remove ActivationsFinder from `src/runtime/runtime-compiler.cc` as in the original commit as the Class is still being used prior to f0acede landing Original Commit Message: Deoptimization and multithreading. When using Lockers and Unlockers it is possible to create a scenario where multiple threads point to the same optimized code object. When that happens, if one of the threads triggers deoptimization, then the stack replacement needs to happen in the stacks of all threads. With this CL, the deoptimizer visits all threads to do so. The CL also adds three tests where V8 used to crash due to this issue. Bug: v8:6563 Change-Id: I74e9af472d4833aa8d13e579df45133791f6a503 Reviewed-on: https://chromium-review.googlesource.com/670783 Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com> Cr-Commit-Position: refs/heads/master@{#48060} PR-URL: https://github.com/nodejs/node/pull/19477 Fixes: https://github.com/nodejs/node/issues/19274 Refs: https://github.com/v8/v8/commit/596d55a Refs: https://github.com/v8/v8/commit/f0acede Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Benedikt Meurer <benedikt.meurer@gmail.com>
-
Michaël Zasso authored
In https://github.com/nodejs/node/commit/bae5de1949b8fed3b6f0653e7c1e9d860666e5af, a deprecation (DEP0089) was added to the docs and another one (DEP0098) was removed by mistake. This commit restores it. PR-URL: https://github.com/nodejs/node/pull/19482 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
- Mar 20, 2018
-
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/18801 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure util.isRegExp and util.isDate will not abort in case more than one argument is passed to the function. PR-URL: https://github.com/nodejs/node/pull/19223 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Daniel Bevenius authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19253 PR-URL: https://github.com/nodejs/node/pull/18893 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Flarna authored
These changes avoid a busy wait loop in V8 CPU Profiler thread for windows (except for short intervals). It would be good if this is also backported to Node.js v9 and LTS releases as this busy loop effectively disallows the use of cpu-profiler in windows production setups. Original commit message 15c0c3a8ba: ``` [profiler] use Sleep() on windows for long profile intervals. See nodejs/diagnostics#170 R=franzih@chromium.org Change-Id: Iecc3bb27707b0d2afbb23fd9823d5cd4d725be6e Reviewed-on: https://chromium-review.googlesource.com/931102 Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51466} ``` Original commit message 43e2fb1c3d: ``` [profiler] fix sleeping on windows for long intervals. R=franzih@chromium.org Change-Id: I5717db794fc797e7c3b0b8f122ddb6dc0702a99e Reviewed-on: https://chromium-review.googlesource.com/941126 Reviewed-by:
-
Tobias Nießen authored
Backport-PR-URL: https://github.com/nodejs/node/pull/19347 PR-URL: https://github.com/nodejs/node/pull/18644 Reviewed-By:
-
Trivikram authored
Backport-PR-URL: https://github.com/nodejs/node/pull/18848 PR-URL: https://github.com/nodejs/node/pull/18848 Reviewed-By:
-
Daniel Bevenius authored
This commit introduces a copyHooks function that can be used by storeActiveHooks and restoreActiveHooks to remove some code duplication. PR-URL: https://github.com/nodejs/node/pull/19391 Reviewed-By:
-
Daniel Bevenius authored
Commit 870229e6 ("src: Add ABORT macro") replaced the abort call with the abort macro in util-inl.h. This commit removes the include as it is not needed anymore. PR-URL: https://github.com/nodejs/node/pull/19427 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Rich Trott authored
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. PR-URL: https://github.com/nodejs/node/pull/19395 Reviewed-By:
-
Gabriel Schulhof authored
Place the test_make_callback async_hooks-related test into its own file. PR-URL: https://github.com/nodejs/node/pull/19392 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19429 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Ujjwal Sharma authored
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-io-1068 to test-tty-stdin-end - Rename test-regress-GH-io-1811 to test-zlib-kmaxlength-rangeerror - Rename test-regress-GH-node-9326 to test-kill-segfault-freebsd - Rename test-timers-regress-GH-9765 to test-timers-setimmediate-infinite-loop - Rename test-tls-pfx-gh-5100-regr to test-tls-pfx-authorizationerror - Rename test-tls-regr-gh-5108 to test-tls-tlswrap-segfault PR-URL: https://github.com/nodejs/node/pull/19332 Fixes: https://github.com/nodejs/node/issues/19105 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Shingo Inoue <leko.noor@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/19400 Reviewed-By:
-
James M Snell authored
Use of a MaybeStackBuffer was just silly. Fix a long standing todo Reduce code duplication a bit. PR-URL: https://github.com/nodejs/node/pull/19400 Reviewed-By:
-
James M Snell authored
Most of the inlines were leftovers from a much older design iteration and are largely pointless or counter productive. PR-URL: https://github.com/nodejs/node/pull/19400 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19390 Reviewed-By:
-
Daniel Bevenius authored
Currently, there is an AsyncWrap constructor that is only used by PromiseWrap. This constructor has a body which is very similar to the other AsyncWrap constructor. This commit suggests updating the private constructor that is used by PromiseWrap and also have the second constructor delegate to this one to avoid the code duplication. PR-URL: https://github.com/nodejs/node/pull/19366 Reviewed-By:
-
Ujjwal Sharma authored
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-9819 to test-crypto-tostring-segfault - Rename test-regress-GH-5051 to test-http-addrequest-localaddress - Rename test-regress-GH-5727 to test-net-listen-invalid-port - Rename test-regress-GH-5927 to test-tty-stdin-pipe - Rename test-regress-GH-6235 to test-v8-global-setter PR-URL: https://github.com/nodejs/node/pull/19275 Refs: https://github.com/nodejs/node/issues/19105 Reviewed-By:
-
Rich Trott authored
Remove "Examples:" labels that announce things that are clearly examples. PR-URL: https://github.com/nodejs/node/pull/19270 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Sergey Golovin authored
PR-URL: https://github.com/nodejs/node/pull/19035 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Michael Dawson authored
Add checks for a pending exception in napi_make_callback after the callback has been invoked. If there is a pending exception then we need to avoid checking the result as that will not be able to complete properly. Add additional checks to the unit test for napi_make_callback to catch this case. PR-URL: https://github.com/nodejs/node/pull/19362 Fixes: https://github.com/nodejs/node-addon-api/issues/235 Reviewed-By:
-
Rich Trott authored
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. Fixes: https://github.com/nodejs/node/issues/18251 PR-URL: https://github.com/nodejs/node/pull/19349 Reviewed-By:
-
Kyle Robinson Young authored
PR-URL: https://github.com/nodejs/node/pull/19385 Reviewed-By:
-
