Unverified Commit 36f664ef authored by Myles Borins's avatar Myles Borins
Browse files

deps: V8: backport 596d55a from upstream

Did not remove ActivationsFinder from `src/runtime/runtime-compiler.cc`
as in the original commit as the Class is still being used prior to
f0acede landing

Original Commit Message:

    Deoptimization and multithreading.

    When using Lockers and Unlockers it is possible to create a
    scenario where multiple threads point to the same optimized
    code object. When that happens, if one of the threads triggers
    deoptimization, then the stack replacement needs to happen in
    the stacks of all threads.
    With this CL, the deoptimizer visits all threads to do so.
    The CL also adds three tests where V8 used to crash due to this
    issue.

    Bug: v8:6563
    Change-Id: I74e9af472d4833aa8d13e579df45133791f6a503
    Reviewed-on: https://chromium-review.googlesource.com/670783


Reviewed-by: default avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com>
    Cr-Commit-Position: refs/heads/master@{#48060}

PR-URL: https://github.com/nodejs/node/pull/19477
Fixes: https://github.com/nodejs/node/issues/19274
Refs: https://github.com/v8/v8/commit/596d55a
Refs: https://github.com/v8/v8/commit/f0acede


Reviewed-By: default avatarGus Caplan <me@gus.host>
Reviewed-By: default avatarYang Guo <yangguo@chromium.org>
Reviewed-By: default avatarFranziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: default avatarBenedikt Meurer <benedikt.meurer@gmail.com>
parent a4c28d77
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment