- Sep 13, 2019
-
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/29509 PR-URL: https://github.com/nodejs/node/pull/29510 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Ben Noordhuis authored
The code generator takes a dict and turns it into a namedtuple. The dict contains the key "async", which is a keyword in python 3.7, and rejected by the namedtuple constructor. Rename it to "async_" to avoid the clash. Fixes: https://github.com/nodejs/node/issues/29326 PR-URL: https://github.com/nodejs/node/pull/29340 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Sep 12, 2019
-
-
Anna Henningsen authored
The fallback code is no longer used when exporting to readable-stream. Refs: https://github.com/nodejs/node/pull/29475 PR-URL: https://github.com/nodejs/node/pull/29514 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Chetan Karande authored
PR-URL: https://github.com/nodejs/node/pull/29506 Reviewed-By:
-
cjihrig authored
Notable changes: - `uv_tcp_close_reset()` has been added. - `uv_udp_set_source_membership()` has been added. - A double free in `uv_free_cpu_info()` on OpenBSD has been fixed. - Defined, but empty environment variables can now be read on Windows. - Several improvements to the cmake build process. - The `EILSEQ` error code is now mapped by libuv. PR-URL: https://github.com/nodejs/node/pull/29508 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Anna Henningsen authored
This has no longer been flaky since V8 7.5. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333 Fixes: https://github.com/nodejs/node/issues/26401 PR-URL: https://github.com/nodejs/node/pull/29511 Reviewed-By:
-
João Reis authored
Support for UV_FS_O_FILEMAP was added in libuv in version 1.31.0. This exposes the flag in fs.constants. Refs: https://github.com/libuv/libuv/pull/2295 PR-URL: https://github.com/nodejs/node/pull/29260 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
-
Anna Henningsen authored
This feature is not expected to receive breaking changes to its API and is used in real-world applications. As discussed at the last collaborator summit (Berlin May 2019), the `worker_threads` module can be considered stable once our Web Messaging implementation is compatible with Web Platform Tests. As of b34f05ec, that is the case. Fixes: https://github.com/nodejs/node/issues/22940 PR-URL: https://github.com/nodejs/node/pull/29512 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
cclauss authored
PR-URL: https://github.com/nodejs/node/pull/25878 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
- Sep 10, 2019
-
-
Anna Henningsen authored
Run cleanup for all relevant subdirectories, and exclude generated source files (e.g. `out/Release/...`) from coverage reporting. Also enable running `make cctest` again (It’s unclear to me why this was disabled, as it does reduce coverage unnecessarily). PR-URL: https://github.com/nodejs/node/pull/29487 Reviewed-By:
-
Nick Schonning authored
Child items not aligned to parent are flagged by list-item-bullet-indent PR-URL: https://github.com/nodejs/node/pull/29488 Reviewed-By:
-
Nick Schonning authored
Address markdownlint rule MD032. Flagged a few mixed list styles. PR-URL: https://github.com/nodejs/node/pull/29467 Reviewed-By:
-
cclauss authored
PR-URL: https://github.com/nodejs/node/pull/29473 Reviewed-By:
-
Anna Henningsen authored
Once `worker.terminate()` is called, the Worker instance will be destroyed as soon as possible anyway, so in order to make the Promise returned by `worker.terminate()` resolve always, it should be okay to just call `.ref()` on it and keep the main event loop alive temporarily. PR-URL: https://github.com/nodejs/node/pull/29484 Reviewed-By:
-
Anna Henningsen authored
Replace a wrong comment with a correct assertion and await all async operations inside the async function. PR-URL: https://github.com/nodejs/node/pull/29483 Reviewed-By:
-
Anna Henningsen authored
Limit the number of messages processed without interruption on a given `MessagePort` to prevent event loop starvation, but still make sure that all messages are emitted that were already in the queue when emitting began. This aligns the behaviour better with the web. Refs: https://github.com/nodejs/node/pull/28030 PR-URL: https://github.com/nodejs/node/pull/29315 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Sep 09, 2019
-
-
Ben Noordhuis authored
The test spawns a subprocess with the `--abort-on-uncaught-exception` flag and expects it to terminate with a SIGABRT signal. On systems where core dumps are enabled, that actually generates an unnecessary core dump. Set `ulimit -c 0` before spawning the subprocess. Fixes: https://github.com/nodejs/node/issues/29286 PR-URL: https://github.com/nodejs/node/pull/29478 Reviewed-By:
-
Nimit Aggarwal authored
Fixed the documentation to reflect the changes in the default value of worker.exitedAfterDisconnect PR-URL: https://github.com/nodejs/node/pull/29404 Fixes: https://github.com/nodejs/node/issues/28837 Refs: https://github.com/nodejs/node/pull/3743 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Gabriel Schulhof authored
We should strive to use weak persistent references consistently throughout the code, since using `v8::Persistent` directly results in having to change many sites in the code when the way we use it changes. N-API uses `v8impl::Reference` internally when maintaining a weak persistent reference is necessary. So far, `v8impl::CallbackBundle` was using `v8::Persistent` directly in order to weakly reference the JS function backed by a N-API callback. The change introduced here reduces `v8impl::CallbackBundle` to a simple structure and uses a `v8impl::Reference` to weakly reference the N-API callback with which it is associated. The structure is freed by the `napi_finalize` callback of the `v8impl::Reference`. This brings N-API use of `v8::Persistent` completely under the `v8impl::Reference` umbrella, rendering our use of weak references consistent. PR-URL: https://github.com/nodejs/node/pull/29479 Reviewed-By:
-
XhmikosR authored
PR-URL: https://github.com/nodejs/node/pull/29452 Reviewed-By:
-
Michael Dawson authored
Update minimum AIX OS level to 7.2 TL2. Looks like this will be the version we can get into the CI so should be the base level for 13.X and above and will be in support for the life of 13.X. PR-URL: https://github.com/nodejs/node/pull/29476 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Rich Trott authored
test/async-hooks/test-signalwrap.js passes with the test.py test runner but fails if run directly with the `node` executable. Modify the test so it passes in both cases. PR-URL: https://github.com/nodejs/node/pull/28306 Reviewed-By:
-
- Sep 08, 2019
-
-
Anna Henningsen authored
Do not crash when the session is no longer available. Fixes: https://github.com/nodejs/node/issues/29457 PR-URL: https://github.com/nodejs/node/pull/29459 Reviewed-By:
-
Gabriel Schulhof authored
PR-URL: https://github.com/nodejs/node/pull/29461 Reviewed-By:
-
Anna Henningsen authored
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: https://github.com/nodejs/node/pull/29317 Reviewed-By:
-
- Sep 07, 2019
-
-
Rich Trott authored
Update remark-preset-lint-node to 1.9.0, which adds linting for multiple consecutive blank lines. PR-URL: https://github.com/nodejs/node/pull/29447 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/29447 Reviewed-By:
-
Kirill Fomichev authored
PerformanceObserver should add to observing only unique entry types. PR-URL: https://github.com/nodejs/node/pull/29442 Reviewed-By:
-
Kirill Fomichev authored
When all existed PerformanceObserver instances removed for type `gc` GC callbacks should be removed. PR-URL: https://github.com/nodejs/node/pull/29444 Reviewed-By:
-
Michael Dawson authored
Simplify/clarify wording documenting n-api execute callback. PR-URL: https://github.com/nodejs/node/pull/29441 Reviewed-By:
-
Anna Henningsen authored
If there’s a lot of data waiting on a given stream, send it out early, if possible. This helps trigger the backpressure mechanism introduced in 8a4a1931 at a better time. PR-URL: https://github.com/nodejs/node/pull/29398 Reviewed-By:
-
James M Snell authored
Co-Authored-By:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/29437 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
- Sep 06, 2019
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/29434 Reviewed-By:
-
Anna Henningsen authored
Allow generic iterables as transfer list arguments, as well as an options object with a `transfer` option, for web compatibility. PR-URL: https://github.com/nodejs/node/pull/29319 Refs: https://github.com/nodejs/node/pull/28033#discussion_r289964991 Reviewed-By:
-
Nick Schonning authored
Markdownlint flags this with MD029 rule. Markdown renders will usually use list continuation number if it can. Explicitly adding it to the list item child scope makes it clearer. PR-URL: https://github.com/nodejs/node/pull/29332 Reviewed-By:
-
Chetan Karande authored
Update writable stream code example using async iterator to use safer `finished()` method instead of a `finish` event to avoid uncaught exceptions Fixes: https://github.com/nodejs/node/issues/29397 PR-URL: https://github.com/nodejs/node/pull/29425 Reviewed-By:
-
Ben Noordhuis authored
Document the `promiseResolve` option to `async_hooks.createHook()`. This seems to have been overlooked in commit b605b153 ("async_hooks: support promise resolve hook") from September 2017. It is documented elsewhere in the async_hooks API documentation, except where you actually pass it in. PR-URL: https://github.com/nodejs/node/pull/29405 Reviewed-By:
-
Kirill Fomichev authored
Import http2 internal bindings on each collectHttp2Stats call is not required. PR-URL: https://github.com/nodejs/node/pull/29419 Reviewed-By:
-
Maledong authored
There're some URLs with old links, change them together from 'http' to 'https'. Notice: 1. Since files of CHANGELOG may be generated through tools, I don't intend to change them together as the history track. 2. All the files in the 'deps' are of 3-rd parties, they will be overwritten for the next update, so avoid modifications for them. PR-URL: https://github.com/nodejs/node/pull/29422 Reviewed-By:
-
