- Sep 07, 2018
-
-
Daniel Bevenius authored
There are two minor issues in the AsyncHook constructor, if the object passed in has an after and/or destroy property that are not functions the errors thrown will still be: TypeError [ERR_ASYNC_CALLBACK]: before must be a function This commit updates the code and adds a unit test. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19000 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Wilson authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18928 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
flickz authored
Fixes: https://github.com/nodejs/node/issues/18639 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18716 Refs: https://github.com/nodejs/node/issues/18639 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
陈刚 authored
`readable.push()` supports `undefined` in non-object mode, but it was not previously documented. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18283 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Robert Rossmann authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/15606 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Ruben Bridgewater authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/13857 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Sep 03, 2018
-
-
sylkat authored
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: https://github.com/nodejs/node/pull/22663 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/22591 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
- Aug 24, 2018
-
-
Junliang Yan authored
Original commit message: s390x: fix high 32-bit word corruption issue R=joransiu@ca.ibm.com Change-Id: I9a2cf0f3e4a33dc4b86c83acfefcd27968bbcdb4 Reviewed-on: https://chromium-review.googlesource.com/1176424 Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55143} Refs: v8/v8@ca95cd9 PR-URL: https://github.com/nodejs/node/pull/22375 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
- Aug 18, 2018
-
-
Myles Borins authored
This also sets the test as flaky PR-URL: https://github.com/nodejs/node/pull/22379 Refs: https://github.com/nodejs/node/issues/21188 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Gabriel Schulhof authored
Avoid using `v8::FunctionTemplate::New()` when using `v8::Function::New()` suffices. This ensures that individual functions can be gc-ed and that functions can be created dynamically without running out of memory. Backport-PR-URL: https://github.com/nodejs/node/pull/22202 PR-URL: https://github.com/nodejs/node/pull/21688 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Gus Caplan <me@gus.host>
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/20295 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Rich Trott authored
When a test times out, the contents of stdout and stderr can often be highly valuable in debugging. Provide that information. Refs: https://github.com/nodejs/node/issues/19906#issuecomment-382073888 PR-URL: https://github.com/nodejs/node/pull/20260 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/19855 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Include the exit code in test failures. This will give us more information during the currently-puzzling failures that provide no information in CI such as: ``` 03:10:10 not ok 563 parallel/test-fs-truncate 03:10:10 --- 03:10:10 duration_ms: 1.119 03:10:10 severity: fail 03:10:10 stack: |- 03:10:10 ... ``` PR-URL: https://github.com/nodejs/node/pull/19855 Reviewed-By:
-
Rich Trott authored
Improve description of `encoding` option. (This change is also applied to `buf.indexOf()`.) Improve punctuation. Wrap at 80 characters. PR-URL: https://github.com/nodejs/node/pull/19904 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Richard Lau authored
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. PR-URL: https://github.com/nodejs/node/pull/20368 Fixes: https://github.com/nodejs/node/issues/20341 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
jvelezpo authored
This is been removed because of this: the source is not provided it adds 105ko of useless files It's only used in the android and fuchsia GN builds Fixes: #20280 PR-URL: https://github.com/nodejs/node/pull/20304 Fixes: https://github.com/nodejs/node/issues/20280 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20307 Reviewed-By:
-
Vse Mozhet Byt authored
Modernize: * Replace `var` with `const` / `let`. * Replace common functions with arrow functions. * Use destructuring. * Use `String.prototype.padStart()`, `String.prototype.endsWith()`. Optimize: * Reduce function calls. * Reduce intermediate variables. * Cache retrieved object properties. * Move RegExp declaration out of a cycle. * Simplify RegExps. * Replace RegExp with string when string suffices. * Remove conditions that cannot be false. * Replace for..in with `Object.keys().forEach()`. Also, eliminate needlessly complicated function chains: * `ondone` callback only checks errors; * if there is an error, it is called once and throws, then script exits; * if there are no errors, it is noop; * so there is no need to wrap it into `once()` function * and there is no need to call it without errors; * we can eliminate it and replace with `throw` where an error occurs; * we can also replace `onprogress` callback with `console.log` in place; * at last, we can eliminate `waiting` counter and `once()` utility. The new script produces results identical to the old ones. PR-URL: https://github.com/nodejs/node/pull/20188 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20071 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/20047 Reviewed-By:
-
Bartosz Sosnowski authored
Adds NASM installation to the Boxstarter script. Refs: https://github.com/nodejs/node/issues/19918 PR-URL: https://github.com/nodejs/node/pull/19950 Reviewed-By:
-
Steven R. Loomis authored
- argv[0] was being emitted into a utf-8 stream, but argv[0] may not be legal utf-8 - fix by not emitting argv[0] (was only for a source comment) - partially resolves https://github.com/nodejs/node/issues/17077 PR-URL: https://github.com/nodejs/node/pull/19756 Fixes: https://github.com/nodejs/node/issues/17077 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19521 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Tobias Nießen authored
The src directory does not contain any JavaScript files, so there is no need to match it. PR-URL: https://github.com/nodejs/node/pull/19521 Reviewed-By:
-
Vse Mozhet Byt authored
Also, move a declaration of unrelated variable closer to its only context. PR-URL: https://github.com/nodejs/node/pull/19692 Reviewed-By:
-
Vse Mozhet Byt authored
* Unify first letters case. * Unify periods. * Delete excess spaces. * Add some blank lines as logical delimiters. * Remove obvious comments. * Combine short lines, rewrap lines more logically. * Fix typos. * "XXX" -> "TODO:", OSX -> macOS. PR-URL: https://github.com/nodejs/node/pull/19696 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19612 Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19539 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19599 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19512 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19512 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19473 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19475 Reviewed-By:
-
Trivikram authored
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: https://github.com/nodejs/node/issues/19067 PR-URL: https://github.com/nodejs/node/pull/19384 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/19140 Reviewed-By:
-
Teddy Katz authored
Refs: https://github.com/nodejs/node/issues/21803 PR-URL: https://github.com/nodejs/node/pull/22036 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/19246 Reviewed-By:
-
